You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benno Evers <be...@mesosphere.com> on 2018/01/17 16:10:44 UTC
Re: Review Request 62447: Reverted usage of `-isystem` flag.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62447/
-----------------------------------------------------------
(Updated Jan. 17, 2018, 4:10 p.m.)
Review request for mesos, Benjamin Bannier and Till Toenshoff.
Changes
-------
Rebased onto latest master.
Summary (updated)
-----------------
Reverted usage of `-isystem` flag.
Repository: mesos
Description (updated)
-------
This flag breaks the build of mesos against system libraries
installed under /usr, because it generates a command line
of `-isystem /usr/include`, which is explicitly not supported
by gcc. See also https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70129
Diffs (updated)
-----
3rdparty/CMakeLists.txt 579aed83fc5c9cee17cf9b4b289a91705f64ceda
configure.ac 59292885b506e9b6fab14107174db11739a587b8
Diff: https://reviews.apache.org/r/62447/diff/3/
Changes: https://reviews.apache.org/r/62447/diff/2-3/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 62447: Reverted usage of `-isystem` flag.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62447/#review195613
-----------------------------------------------------------
FAIL: Failed to apply the dependent review: 62161.
Failed command: `python.exe .\support\apply-reviews.py -n -r 62161`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62447
Relevant logs:
- [apply-review-62161-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62447/logs/apply-review-62161-stdout.log):
```
error: missing binary patch data for '3rdparty/boost-1.65.0.tar.gz'
error: binary patch does not apply to '3rdparty/boost-1.65.0.tar.gz'
error: 3rdparty/boost-1.65.0.tar.gz: patch does not apply
```
- Mesos Reviewbot Windows
On Jan. 17, 2018, 4:10 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62447/
> -----------------------------------------------------------
>
> (Updated Jan. 17, 2018, 4:10 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This flag breaks the build of mesos against system libraries
> installed under /usr, because it generates a command line
> of `-isystem /usr/include`, which is explicitly not supported
> by gcc. See also https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70129
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt 579aed83fc5c9cee17cf9b4b289a91705f64ceda
> configure.ac 59292885b506e9b6fab14107174db11739a587b8
>
>
> Diff: https://reviews.apache.org/r/62447/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 62447: Reverted usage of the -isystem flag for
includes (1/3).
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
> On Jan. 24, 2018, 8:47 a.m., Mesos Reviewbot Windows wrote:
> > FAIL: Mesos tests failed to build.
> >
> > Reviews applied: `['65308', '62447']`
> >
> > Failed command: `cmake.exe --build . --target mesos-tests --config Debug`
> >
> > All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62447
> >
> > Relevant logs:
> >
> > - [mesos-tests-build-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62447/logs/mesos-tests-build-cmake-stdout.log):
> >
> > ```
> > D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(1799): warning C4996: 'strcat': This function or variable may be unsafe. Consider using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
> > D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(1814): warning C4996: 'strcat': This function or variable may be unsafe. Consider using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
> > D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(1818): warning C4996: 'strcat': This function or variable may be unsafe. Consider using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
> > D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(1826): warning C4996: 'strcat': This function or variable may be unsafe. Consider using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
> > D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(2363): warning C4996: 'strdup': The POSIX name for this item is deprecated. Instead, use the ISO C and C++ conformant name: _strdup. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
> > D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(2377): warning C4996: 'stricmp': The POSIX name for this item is deprecated. Instead, use the ISO C and C++ conformant name: _stricmp. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
> > D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\seterror.c(189): warning C4996: 'strerror': This function or variable may be unsafe. Consider using strerror_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
> > D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(236): warning C4996: 'strcpy': This function or variable may be unsafe. Consider using strcpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
> > D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(241): warning C4996: 'strcat': This function or variable may be unsafe. Consider using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
> > D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(253): warning C4996: 'strcat': This function or variable may be unsafe. Consider using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
> > D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(278): warning C4996: 'stricmp': The POSIX name for this item is deprecated. Instead, use the ISO C and C++ conformant name: _stricmp. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
> > D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(289): warning C4996: 'strcpy': This function or variable may be unsafe. Consider using strcpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
> > D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(290): warning C4996: 'strcat': This function or variable may be unsafe. Consider using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
> > D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(293): warning C4996: 'strcpy': This function or variable may be unsafe. Consider using strcpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
> > D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\plugins\cram.c(138): warning C4477: 'snprintf' : format string '%lu' requires an argument of type 'unsigned long', but variadic argument 1 has type 'time_t' [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
> > D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\plugins\cram.c(157): warning C4996: 'sprintf': This function or variable may be unsafe. Consider using sprintf_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
> > D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\plugins\cram.c(293): warning C4996: 'strncpy': This function or variable may be unsafe. Consider using strncpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
> >
> >
> > "D:\DCOS\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
> > "D:\DCOS\mesos\src\mesos.vcxproj" (default target) (12) ->
> > (ClCompile target) ->
> > D:\DCOS\mesos\mesos\src\executor\executor.cpp(233): error C2039: 'eraseenv': is not a member of 'os' [D:\DCOS\mesos\src\mesos.vcxproj]
> > D:\DCOS\mesos\mesos\src\executor\executor.cpp(233): error C3861: 'eraseenv': identifier not found [D:\DCOS\mesos\src\mesos.vcxproj]
> >
> > 112 Warning(s)
> > 2 Error(s)
> >
> > Time Elapsed 00:03:21.54
> > ```
> >
> > - [mesos-tests-CMakeOutput.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62447/logs/mesos-tests-CMakeOutput.log):
> >
> > ```
> > Creating directory "cmTC_026cb.dir\Debug\".
> > Creating directory "D:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\".
> > Creating directory "cmTC_026cb.dir\Debug\cmTC_026cb.tlog\".
> > InitializeBuildStatus:
> > Creating "cmTC_026cb.dir\Debug\cmTC_026cb.tlog\unsuccessfulbuild" because "AlwaysCreate" was specified.
> > ClCompile:
> > C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\bin\HostX64\x64\CL.exe /c /Zi /W3 /WX- /diagnostics:classic /Od /Ob0 /D WIN32 /D _WINDOWS /D COMPILER_SUPPORTS_CXX11 /D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /GR /Fo"cmTC_026cb.dir\Debug\" /Fd"cmTC_026cb.dir\Debug\vc141.pdb" /Gd /TP /errorReport:queue D:\DCOS\mesos\CMakeFiles\CMakeTmp\src.cxx
> > Microsoft (R) C/C++ Optimizing Compiler Version 19.12.25830.2 for x64
> > Copyright (C) Microsoft Corporation. All rights reserved.
> >
> > cl /c /Zi /W3 /WX- /diagnostics:classic /Od /Ob0 /D WIN32 /D _WINDOWS /D COMPILER_SUPPORTS_CXX11 /D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /GR /Fo"cmTC_026cb.dir\Debug\" /Fd"cmTC_026cb.dir\Debug\vc141.pdb" /Gd /TP /errorReport:queue D:\DCOS\mesos\CMakeFiles\CMakeTmp\src.cxx
> > src.cxx
> >
> > Link:
> > C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\bin\HostX64\x64\link.exe /ERRORREPORT:QUEUE /OUT:"D:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\cmTC_026cb.exe" /INCREMENTAL /NOLOGO kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib /MANIFEST /MANIFESTUAC:"level='asInvoker' uiAccess='false'" /manifest:embed /DEBUG /PDB:"D:/DCOS/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_026cb.pdb" /SUBSYSTEM:CONSOLE /TLBID:1 /DYNAMICBASE /NXCOMPAT /IMPLIB:"D:/DCOS/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_026cb.lib" /MACHINE:X64 /machine:x64 cmTC_026cb.dir\Debug\src.obj
> > cmTC_026cb.vcxproj -> D:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\cmTC_026cb.exe
> > FinalizeBuildStatus:
> > Deleting file "cmTC_026cb.dir\Debug\cmTC_026cb.tlog\unsuccessfulbuild".
> > Touching "cmTC_026cb.dir\Debug\cmTC_026cb.tlog\cmTC_026cb.lastbuildstate".
> > Done Building Project "D:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_026cb.vcxproj" (default targets).
> >
> > Build succeeded.
> > 0 Warning(s)
> > 0 Error(s)
> >
> > Time Elapsed 00:00:01.20
> >
> > Source file was:
> > int main() { return 0; }
> > ```
> >
> > - [mesos-tests-CMakeError.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62447/logs/mesos-tests-CMakeError.log):
> >
> > ```
> > PrepareForBuild:
> > Creating directory "cmTC_230ca.dir\Debug\".
> > Creating directory "D:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\".
> > Creating directory "cmTC_230ca.dir\Debug\cmTC_230ca.tlog\".
> > InitializeBuildStatus:
> > Creating "cmTC_230ca.dir\Debug\cmTC_230ca.tlog\unsuccessfulbuild" because "AlwaysCreate" was specified.
> > ClCompile:
> > C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\bin\HostX64\x64\CL.exe /c /Zi /W3 /WX- /diagnostics:classic /MP /Od /Ob0 /D WIN32 /D _WINDOWS /D UNICODE /D _UNICODE /D "CMAKE_INTDIR=\"Debug\"" /D _UNICODE /D UNICODE /Gm- /RTC1 /MTd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /Fo"cmTC_230ca.dir\Debug\" /Fd"cmTC_230ca.dir\Debug\vc141.pdb" /Gd /TC /errorReport:queue D:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c
> > Microsoft (R) C/C++ Optimizing Compiler Version 19.12.25830.2 for x64
> > Copyright (C) Microsoft Corporation. All rights reserved.
> >
> > cl /c /Zi /W3 /WX- /diagnostics:classic /MP /Od /Ob0 /D WIN32 /D _WINDOWS /D UNICODE /D _UNICODE /D "CMAKE_INTDIR=\"Debug\"" /D _UNICODE /D UNICODE /Gm- /RTC1 /MTd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /Fo"cmTC_230ca.dir\Debug\" /Fd"cmTC_230ca.dir\Debug\vc141.pdb" /Gd /TC /errorReport:queue D:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c
> > CheckIncludeFile.c
> >
> > D:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c(1): fatal error C1083: Cannot open include file: 'pthread.h': No such file or directory [D:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_230ca.vcxproj]
> > Done Building Project "D:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_230ca.vcxproj" (default targets) -- FAILED.
> >
> > Build FAILED.
> >
> > "D:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_230ca.vcxproj" (default target) (1) ->
> > (ClCompile target) ->
> > D:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c(1): fatal error C1083: Cannot open include file: 'pthread.h': No such file or directory [D:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_230ca.vcxproj]
> >
> > 0 Warning(s)
> > 1 Error(s)
> >
> > Time Elapsed 00:00:00.63
> >
> >
> > ```
The build of master was broken upstream; it's getting fixed.
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62447/#review196137
-----------------------------------------------------------
On Jan. 24, 2018, 8:18 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62447/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2018, 8:18 a.m.)
>
>
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This flag break the build of mesos against system libraries
> installed under /usr, because it generates a command line
> of `-isystem /usr/include`, which is explicitly not supported
> by gcc. See also https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70129
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt 579aed83fc5c9cee17cf9b4b289a91705f64ceda
> configure.ac fc34ff44a20cc34c8ceeca0d9afac2fab49b86a6
> docs/cmake-examples.md e7274a48a9b73abce4e5c00fc9b5bef6e9a9ad82
> m4/libnl3.m4 238ac6e01ea6d1897bd307a84ca522250f34c0fa
> src/Makefile.am fe8f689c6b82a88e6e114d5d2082183b3cf4ed54
>
>
> Diff: https://reviews.apache.org/r/62447/diff/5/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 62447: Reverted usage of the -isystem flag for
includes (1/3).
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62447/#review196137
-----------------------------------------------------------
FAIL: Mesos tests failed to build.
Reviews applied: `['65308', '62447']`
Failed command: `cmake.exe --build . --target mesos-tests --config Debug`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62447
Relevant logs:
- [mesos-tests-build-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62447/logs/mesos-tests-build-cmake-stdout.log):
```
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(1799): warning C4996: 'strcat': This function or variable may be unsafe. Consider using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(1814): warning C4996: 'strcat': This function or variable may be unsafe. Consider using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(1818): warning C4996: 'strcat': This function or variable may be unsafe. Consider using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(1826): warning C4996: 'strcat': This function or variable may be unsafe. Consider using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(2363): warning C4996: 'strdup': The POSIX name for this item is deprecated. Instead, use the ISO C and C++ conformant name: _strdup. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(2377): warning C4996: 'stricmp': The POSIX name for this item is deprecated. Instead, use the ISO C and C++ conformant name: _stricmp. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\seterror.c(189): warning C4996: 'strerror': This function or variable may be unsafe. Consider using strerror_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(236): warning C4996: 'strcpy': This function or variable may be unsafe. Consider using strcpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(241): warning C4996: 'strcat': This function or variable may be unsafe. Consider using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(253): warning C4996: 'strcat': This function or variable may be unsafe. Consider using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(278): warning C4996: 'stricmp': The POSIX name for this item is deprecated. Instead, use the ISO C and C++ conformant name: _stricmp. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(289): warning C4996: 'strcpy': This function or variable may be unsafe. Consider using strcpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(290): warning C4996: 'strcat': This function or variable may be unsafe. Consider using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(293): warning C4996: 'strcpy': This function or variable may be unsafe. Consider using strcpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\plugins\cram.c(138): warning C4477: 'snprintf' : format string '%lu' requires an argument of type 'unsigned long', but variadic argument 1 has type 'time_t' [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\plugins\cram.c(157): warning C4996: 'sprintf': This function or variable may be unsafe. Consider using sprintf_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\plugins\cram.c(293): warning C4996: 'strncpy': This function or variable may be unsafe. Consider using strncpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
"D:\DCOS\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
"D:\DCOS\mesos\src\mesos.vcxproj" (default target) (12) ->
(ClCompile target) ->
D:\DCOS\mesos\mesos\src\executor\executor.cpp(233): error C2039: 'eraseenv': is not a member of 'os' [D:\DCOS\mesos\src\mesos.vcxproj]
D:\DCOS\mesos\mesos\src\executor\executor.cpp(233): error C3861: 'eraseenv': identifier not found [D:\DCOS\mesos\src\mesos.vcxproj]
112 Warning(s)
2 Error(s)
Time Elapsed 00:03:21.54
```
- [mesos-tests-CMakeOutput.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62447/logs/mesos-tests-CMakeOutput.log):
```
Creating directory "cmTC_026cb.dir\Debug\".
Creating directory "D:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\".
Creating directory "cmTC_026cb.dir\Debug\cmTC_026cb.tlog\".
InitializeBuildStatus:
Creating "cmTC_026cb.dir\Debug\cmTC_026cb.tlog\unsuccessfulbuild" because "AlwaysCreate" was specified.
ClCompile:
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\bin\HostX64\x64\CL.exe /c /Zi /W3 /WX- /diagnostics:classic /Od /Ob0 /D WIN32 /D _WINDOWS /D COMPILER_SUPPORTS_CXX11 /D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /GR /Fo"cmTC_026cb.dir\Debug\" /Fd"cmTC_026cb.dir\Debug\vc141.pdb" /Gd /TP /errorReport:queue D:\DCOS\mesos\CMakeFiles\CMakeTmp\src.cxx
Microsoft (R) C/C++ Optimizing Compiler Version 19.12.25830.2 for x64
Copyright (C) Microsoft Corporation. All rights reserved.
cl /c /Zi /W3 /WX- /diagnostics:classic /Od /Ob0 /D WIN32 /D _WINDOWS /D COMPILER_SUPPORTS_CXX11 /D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /GR /Fo"cmTC_026cb.dir\Debug\" /Fd"cmTC_026cb.dir\Debug\vc141.pdb" /Gd /TP /errorReport:queue D:\DCOS\mesos\CMakeFiles\CMakeTmp\src.cxx
src.cxx
Link:
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\bin\HostX64\x64\link.exe /ERRORREPORT:QUEUE /OUT:"D:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\cmTC_026cb.exe" /INCREMENTAL /NOLOGO kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib /MANIFEST /MANIFESTUAC:"level='asInvoker' uiAccess='false'" /manifest:embed /DEBUG /PDB:"D:/DCOS/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_026cb.pdb" /SUBSYSTEM:CONSOLE /TLBID:1 /DYNAMICBASE /NXCOMPAT /IMPLIB:"D:/DCOS/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_026cb.lib" /MACHINE:X64 /machine:x64 cmTC_026cb.dir\Debug\src.obj
cmTC_026cb.vcxproj -> D:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\cmTC_026cb.exe
FinalizeBuildStatus:
Deleting file "cmTC_026cb.dir\Debug\cmTC_026cb.tlog\unsuccessfulbuild".
Touching "cmTC_026cb.dir\Debug\cmTC_026cb.tlog\cmTC_026cb.lastbuildstate".
Done Building Project "D:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_026cb.vcxproj" (default targets).
Build succeeded.
0 Warning(s)
0 Error(s)
Time Elapsed 00:00:01.20
Source file was:
int main() { return 0; }
```
- [mesos-tests-CMakeError.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62447/logs/mesos-tests-CMakeError.log):
```
PrepareForBuild:
Creating directory "cmTC_230ca.dir\Debug\".
Creating directory "D:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\".
Creating directory "cmTC_230ca.dir\Debug\cmTC_230ca.tlog\".
InitializeBuildStatus:
Creating "cmTC_230ca.dir\Debug\cmTC_230ca.tlog\unsuccessfulbuild" because "AlwaysCreate" was specified.
ClCompile:
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\bin\HostX64\x64\CL.exe /c /Zi /W3 /WX- /diagnostics:classic /MP /Od /Ob0 /D WIN32 /D _WINDOWS /D UNICODE /D _UNICODE /D "CMAKE_INTDIR=\"Debug\"" /D _UNICODE /D UNICODE /Gm- /RTC1 /MTd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /Fo"cmTC_230ca.dir\Debug\" /Fd"cmTC_230ca.dir\Debug\vc141.pdb" /Gd /TC /errorReport:queue D:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c
Microsoft (R) C/C++ Optimizing Compiler Version 19.12.25830.2 for x64
Copyright (C) Microsoft Corporation. All rights reserved.
cl /c /Zi /W3 /WX- /diagnostics:classic /MP /Od /Ob0 /D WIN32 /D _WINDOWS /D UNICODE /D _UNICODE /D "CMAKE_INTDIR=\"Debug\"" /D _UNICODE /D UNICODE /Gm- /RTC1 /MTd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /Fo"cmTC_230ca.dir\Debug\" /Fd"cmTC_230ca.dir\Debug\vc141.pdb" /Gd /TC /errorReport:queue D:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c
CheckIncludeFile.c
D:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c(1): fatal error C1083: Cannot open include file: 'pthread.h': No such file or directory [D:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_230ca.vcxproj]
Done Building Project "D:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_230ca.vcxproj" (default targets) -- FAILED.
Build FAILED.
"D:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_230ca.vcxproj" (default target) (1) ->
(ClCompile target) ->
D:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c(1): fatal error C1083: Cannot open include file: 'pthread.h': No such file or directory [D:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_230ca.vcxproj]
0 Warning(s)
1 Error(s)
Time Elapsed 00:00:00.63
```
- Mesos Reviewbot Windows
On Jan. 24, 2018, 4:18 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62447/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2018, 4:18 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This flag break the build of mesos against system libraries
> installed under /usr, because it generates a command line
> of `-isystem /usr/include`, which is explicitly not supported
> by gcc. See also https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70129
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt 579aed83fc5c9cee17cf9b4b289a91705f64ceda
> configure.ac fc34ff44a20cc34c8ceeca0d9afac2fab49b86a6
> docs/cmake-examples.md e7274a48a9b73abce4e5c00fc9b5bef6e9a9ad82
> m4/libnl3.m4 238ac6e01ea6d1897bd307a84ca522250f34c0fa
> src/Makefile.am fe8f689c6b82a88e6e114d5d2082183b3cf4ed54
>
>
> Diff: https://reviews.apache.org/r/62447/diff/5/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 62447: Reverted usage of the -isystem flag for
includes (1/3).
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62447/
-----------------------------------------------------------
(Updated Jan. 24, 2018, 4:18 p.m.)
Review request for mesos, Benjamin Bannier and Till Toenshoff.
Repository: mesos
Description
-------
This flag break the build of mesos against system libraries
installed under /usr, because it generates a command line
of `-isystem /usr/include`, which is explicitly not supported
by gcc. See also https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70129
Diffs (updated)
-----
3rdparty/CMakeLists.txt 579aed83fc5c9cee17cf9b4b289a91705f64ceda
configure.ac fc34ff44a20cc34c8ceeca0d9afac2fab49b86a6
docs/cmake-examples.md e7274a48a9b73abce4e5c00fc9b5bef6e9a9ad82
m4/libnl3.m4 238ac6e01ea6d1897bd307a84ca522250f34c0fa
src/Makefile.am fe8f689c6b82a88e6e114d5d2082183b3cf4ed54
Diff: https://reviews.apache.org/r/62447/diff/5/
Changes: https://reviews.apache.org/r/62447/diff/4-5/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 62447: Reverted usage of the -isystem flag for
includes (1/3).
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62447/#review196127
-----------------------------------------------------------
FAIL: Mesos tests failed to build.
Reviews applied: `['65308', '62447']`
Failed command: `cmake.exe --build . --target mesos-tests --config Debug`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62447
Relevant logs:
- [mesos-tests-build-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62447/logs/mesos-tests-build-cmake-stdout.log):
```
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(1799): warning C4996: 'strcat': This function or variable may be unsafe. Consider using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(1814): warning C4996: 'strcat': This function or variable may be unsafe. Consider using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(1818): warning C4996: 'strcat': This function or variable may be unsafe. Consider using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(1826): warning C4996: 'strcat': This function or variable may be unsafe. Consider using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(2363): warning C4996: 'strdup': The POSIX name for this item is deprecated. Instead, use the ISO C and C++ conformant name: _strdup. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(2377): warning C4996: 'stricmp': The POSIX name for this item is deprecated. Instead, use the ISO C and C++ conformant name: _stricmp. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\seterror.c(189): warning C4996: 'strerror': This function or variable may be unsafe. Consider using strerror_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(236): warning C4996: 'strcpy': This function or variable may be unsafe. Consider using strcpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(241): warning C4996: 'strcat': This function or variable may be unsafe. Consider using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(253): warning C4996: 'strcat': This function or variable may be unsafe. Consider using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(278): warning C4996: 'stricmp': The POSIX name for this item is deprecated. Instead, use the ISO C and C++ conformant name: _stricmp. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(289): warning C4996: 'strcpy': This function or variable may be unsafe. Consider using strcpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(290): warning C4996: 'strcat': This function or variable may be unsafe. Consider using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(293): warning C4996: 'strcpy': This function or variable may be unsafe. Consider using strcpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\plugins\cram.c(138): warning C4477: 'snprintf' : format string '%lu' requires an argument of type 'unsigned long', but variadic argument 1 has type 'time_t' [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\plugins\cram.c(157): warning C4996: 'sprintf': This function or variable may be unsafe. Consider using sprintf_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\plugins\cram.c(293): warning C4996: 'strncpy': This function or variable may be unsafe. Consider using strncpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
"D:\DCOS\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
"D:\DCOS\mesos\src\mesos.vcxproj" (default target) (12) ->
(ClCompile target) ->
D:\DCOS\mesos\mesos\src\executor\executor.cpp(233): error C2039: 'eraseenv': is not a member of 'os' [D:\DCOS\mesos\src\mesos.vcxproj]
D:\DCOS\mesos\mesos\src\executor\executor.cpp(233): error C3861: 'eraseenv': identifier not found [D:\DCOS\mesos\src\mesos.vcxproj]
112 Warning(s)
2 Error(s)
Time Elapsed 00:03:22.30
```
- [mesos-tests-CMakeOutput.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62447/logs/mesos-tests-CMakeOutput.log):
```
Creating directory "cmTC_38149.dir\Debug\".
Creating directory "D:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\".
Creating directory "cmTC_38149.dir\Debug\cmTC_38149.tlog\".
InitializeBuildStatus:
Creating "cmTC_38149.dir\Debug\cmTC_38149.tlog\unsuccessfulbuild" because "AlwaysCreate" was specified.
ClCompile:
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\bin\HostX64\x64\CL.exe /c /Zi /W3 /WX- /diagnostics:classic /Od /Ob0 /D WIN32 /D _WINDOWS /D COMPILER_SUPPORTS_CXX11 /D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /GR /Fo"cmTC_38149.dir\Debug\" /Fd"cmTC_38149.dir\Debug\vc141.pdb" /Gd /TP /errorReport:queue D:\DCOS\mesos\CMakeFiles\CMakeTmp\src.cxx
Microsoft (R) C/C++ Optimizing Compiler Version 19.12.25830.2 for x64
Copyright (C) Microsoft Corporation. All rights reserved.
cl /c /Zi /W3 /WX- /diagnostics:classic /Od /Ob0 /D WIN32 /D _WINDOWS /D COMPILER_SUPPORTS_CXX11 /D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /GR /Fo"cmTC_38149.dir\Debug\" /Fd"cmTC_38149.dir\Debug\vc141.pdb" /Gd /TP /errorReport:queue D:\DCOS\mesos\CMakeFiles\CMakeTmp\src.cxx
src.cxx
Link:
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\bin\HostX64\x64\link.exe /ERRORREPORT:QUEUE /OUT:"D:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\cmTC_38149.exe" /INCREMENTAL /NOLOGO kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib /MANIFEST /MANIFESTUAC:"level='asInvoker' uiAccess='false'" /manifest:embed /DEBUG /PDB:"D:/DCOS/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_38149.pdb" /SUBSYSTEM:CONSOLE /TLBID:1 /DYNAMICBASE /NXCOMPAT /IMPLIB:"D:/DCOS/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_38149.lib" /MACHINE:X64 /machine:x64 cmTC_38149.dir\Debug\src.obj
cmTC_38149.vcxproj -> D:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\cmTC_38149.exe
FinalizeBuildStatus:
Deleting file "cmTC_38149.dir\Debug\cmTC_38149.tlog\unsuccessfulbuild".
Touching "cmTC_38149.dir\Debug\cmTC_38149.tlog\cmTC_38149.lastbuildstate".
Done Building Project "D:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_38149.vcxproj" (default targets).
Build succeeded.
0 Warning(s)
0 Error(s)
Time Elapsed 00:00:01.24
Source file was:
int main() { return 0; }
```
- [mesos-tests-CMakeError.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62447/logs/mesos-tests-CMakeError.log):
```
PrepareForBuild:
Creating directory "cmTC_297e9.dir\Debug\".
Creating directory "D:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\".
Creating directory "cmTC_297e9.dir\Debug\cmTC_297e9.tlog\".
InitializeBuildStatus:
Creating "cmTC_297e9.dir\Debug\cmTC_297e9.tlog\unsuccessfulbuild" because "AlwaysCreate" was specified.
ClCompile:
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\bin\HostX64\x64\CL.exe /c /Zi /W3 /WX- /diagnostics:classic /MP /Od /Ob0 /D WIN32 /D _WINDOWS /D UNICODE /D _UNICODE /D "CMAKE_INTDIR=\"Debug\"" /D _UNICODE /D UNICODE /Gm- /RTC1 /MTd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /Fo"cmTC_297e9.dir\Debug\" /Fd"cmTC_297e9.dir\Debug\vc141.pdb" /Gd /TC /errorReport:queue D:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c
Microsoft (R) C/C++ Optimizing Compiler Version 19.12.25830.2 for x64
Copyright (C) Microsoft Corporation. All rights reserved.
cl /c /Zi /W3 /WX- /diagnostics:classic /MP /Od /Ob0 /D WIN32 /D _WINDOWS /D UNICODE /D _UNICODE /D "CMAKE_INTDIR=\"Debug\"" /D _UNICODE /D UNICODE /Gm- /RTC1 /MTd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /Fo"cmTC_297e9.dir\Debug\" /Fd"cmTC_297e9.dir\Debug\vc141.pdb" /Gd /TC /errorReport:queue D:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c
CheckIncludeFile.c
D:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c(1): fatal error C1083: Cannot open include file: 'pthread.h': No such file or directory [D:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_297e9.vcxproj]
Done Building Project "D:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_297e9.vcxproj" (default targets) -- FAILED.
Build FAILED.
"D:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_297e9.vcxproj" (default target) (1) ->
(ClCompile target) ->
D:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c(1): fatal error C1083: Cannot open include file: 'pthread.h': No such file or directory [D:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_297e9.vcxproj]
0 Warning(s)
1 Error(s)
Time Elapsed 00:00:00.63
```
- Mesos Reviewbot Windows
On Jan. 24, 2018, 2:57 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62447/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2018, 2:57 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This flag break the build of mesos against system libraries
> installed under /usr, because it generates a command line
> of `-isystem /usr/include`, which is explicitly not supported
> by gcc. See also https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70129
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt 579aed83fc5c9cee17cf9b4b289a91705f64ceda
> configure.ac fc34ff44a20cc34c8ceeca0d9afac2fab49b86a6
> m4/libnl3.m4 238ac6e01ea6d1897bd307a84ca522250f34c0fa
> src/Makefile.am fe8f689c6b82a88e6e114d5d2082183b3cf4ed54
>
>
> Diff: https://reviews.apache.org/r/62447/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 62447: Reverted usage of the -isystem flag for
includes (1/3).
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62447/
-----------------------------------------------------------
(Updated Jan. 24, 2018, 2:57 p.m.)
Review request for mesos, Benjamin Bannier and Till Toenshoff.
Summary (updated)
-----------------
Reverted usage of the -isystem flag for includes (1/3).
Repository: mesos
Description (updated)
-------
This flag break the build of mesos against system libraries
installed under /usr, because it generates a command line
of `-isystem /usr/include`, which is explicitly not supported
by gcc. See also https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70129
Diffs (updated)
-----
3rdparty/CMakeLists.txt 579aed83fc5c9cee17cf9b4b289a91705f64ceda
configure.ac fc34ff44a20cc34c8ceeca0d9afac2fab49b86a6
m4/libnl3.m4 238ac6e01ea6d1897bd307a84ca522250f34c0fa
src/Makefile.am fe8f689c6b82a88e6e114d5d2082183b3cf4ed54
Diff: https://reviews.apache.org/r/62447/diff/4/
Changes: https://reviews.apache.org/r/62447/diff/3-4/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 62447: Reverted usage of `-isystem` flag.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62447/#review196005
-----------------------------------------------------------
Sorry for not coming back to this review earlier, and thanks for not dropping the ball.
There are still a number of uses of `-isystem` in the mesos, process, and stout build setups, and in the cmake documentation. We should strive for updating all of these.
- Benjamin Bannier
On Jan. 17, 2018, 5:10 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62447/
> -----------------------------------------------------------
>
> (Updated Jan. 17, 2018, 5:10 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This flag breaks the build of mesos against system libraries
> installed under /usr, because it generates a command line
> of `-isystem /usr/include`, which is explicitly not supported
> by gcc. See also https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70129
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt 579aed83fc5c9cee17cf9b4b289a91705f64ceda
> configure.ac 59292885b506e9b6fab14107174db11739a587b8
>
>
> Diff: https://reviews.apache.org/r/62447/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>