You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2015/12/08 20:24:50 UTC
Re: Review Request 40256: [6/7] Fixed handling of multiple offer
operations in PersistentVolumeTest.SendingCheckpointResourcesMessage.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40256/
-----------------------------------------------------------
(Updated Dec. 8, 2015, 7:24 p.m.)
Review request for mesos, Jie Yu, Michael Park, and Neil Conway.
Bugs: MESOS-3065
https://issues.apache.org/jira/browse/MESOS-3065
Repository: mesos
Description
-------
Fixed handling of multiple offer operations in PersistentVolumeTest.SendingCheckpointResourcesMessage.
Diffs (updated)
-----
src/tests/persistent_volume_tests.cpp 01b3c13751a5558d5f06edb8f650c8644dc54486
Diff: https://reviews.apache.org/r/40256/diff/
Testing (updated)
-------
This is the sixth in a chain of 7 patches. This patch was required in order to fix the `PersistentVolumeTest.SendingCheckpointResourcesMessage` test, which was broken by the addition of authorization to the `CREATE` and `DESTROY` offer operations. The test was previously both creating and destroying a persistent volume in a single `acceptOffer` message. However, our `validate` method for `DESTROY` offer operations correctly enforces that in order to delete a volume, the volume should be present in the checkpointed resources of the relevant Agent. This is likely not the case if the `CREATE` and `DESTROY` operations are both in the same message.
`make check` was used to test after all patches were applied.
Thanks,
Greg Mann
Re: Review Request 40256: [6/7] Fixed handling of multiple offer
operations in PersistentVolumeTest.SendingCheckpointResourcesMessage.
Posted by Greg Mann <gr...@mesosphere.io>.
> On Dec. 18, 2015, 8:05 p.m., Jie Yu wrote:
> > src/tests/persistent_volume_tests.cpp, line 99
> > <https://reviews.apache.org/r/40256/diff/4/?file=1170705#file1170705line99>
> >
> > Looks like `MasterFlags` is not needed anymore with implicit roles. Can you do a sweep to remove it in a subsequent patch?
Simply removing `MasterFlags` results in an uninteresting mock function call error, probably because of a method triggered by adding an unknown role. I'm happy to take care of this, but I'd prefer to wait until I have some more time. I've created a JIRA to track this here: https://issues.apache.org/jira/browse/MESOS-4205 Sound OK to you?
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40256/#review111249
-----------------------------------------------------------
On Dec. 18, 2015, 9:38 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40256/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2015, 9:38 a.m.)
>
>
> Review request for mesos, Jie Yu, Michael Park, and Neil Conway.
>
>
> Bugs: MESOS-3065
> https://issues.apache.org/jira/browse/MESOS-3065
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed handling of multiple offer operations in PersistentVolumeTest.SendingCheckpointResourcesMessage.
>
>
> Diffs
> -----
>
> src/tests/persistent_volume_tests.cpp 01b3c13751a5558d5f06edb8f650c8644dc54486
>
> Diff: https://reviews.apache.org/r/40256/diff/
>
>
> Testing
> -------
>
> This is the sixth in a chain of 7 patches. This patch was required in order to fix the `PersistentVolumeTest.SendingCheckpointResourcesMessage` test, which was broken by the addition of authorization to the `CREATE` and `DESTROY` offer operations. The test was previously both creating and destroying a persistent volume in a single `acceptOffer` message. However, our `validate` method for `DESTROY` offer operations correctly enforces that in order to delete a volume, the volume should be present in the checkpointed resources of the relevant Agent. This is likely not the case if the `CREATE` and `DESTROY` operations are both in the same message.
>
> `make check` was used to test after all patches were applied.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 40256: [6/7] Fixed handling of multiple offer
operations in PersistentVolumeTest.SendingCheckpointResourcesMessage.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40256/#review111249
-----------------------------------------------------------
Ship it!
src/tests/persistent_volume_tests.cpp (line 99)
<https://reviews.apache.org/r/40256/#comment171351>
Looks like `MasterFlags` is not needed anymore with implicit roles. Can you do a sweep to remove it in a subsequent patch?
- Jie Yu
On Dec. 18, 2015, 9:38 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40256/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2015, 9:38 a.m.)
>
>
> Review request for mesos, Jie Yu, Michael Park, and Neil Conway.
>
>
> Bugs: MESOS-3065
> https://issues.apache.org/jira/browse/MESOS-3065
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed handling of multiple offer operations in PersistentVolumeTest.SendingCheckpointResourcesMessage.
>
>
> Diffs
> -----
>
> src/tests/persistent_volume_tests.cpp 01b3c13751a5558d5f06edb8f650c8644dc54486
>
> Diff: https://reviews.apache.org/r/40256/diff/
>
>
> Testing
> -------
>
> This is the sixth in a chain of 7 patches. This patch was required in order to fix the `PersistentVolumeTest.SendingCheckpointResourcesMessage` test, which was broken by the addition of authorization to the `CREATE` and `DESTROY` offer operations. The test was previously both creating and destroying a persistent volume in a single `acceptOffer` message. However, our `validate` method for `DESTROY` offer operations correctly enforces that in order to delete a volume, the volume should be present in the checkpointed resources of the relevant Agent. This is likely not the case if the `CREATE` and `DESTROY` operations are both in the same message.
>
> `make check` was used to test after all patches were applied.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 40256: [6/7] Fixed handling of multiple offer
operations in PersistentVolumeTest.SendingCheckpointResourcesMessage.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40256/
-----------------------------------------------------------
(Updated Dec. 18, 2015, 9:38 a.m.)
Review request for mesos, Jie Yu, Michael Park, and Neil Conway.
Changes
-------
Rebase.
Bugs: MESOS-3065
https://issues.apache.org/jira/browse/MESOS-3065
Repository: mesos
Description
-------
Fixed handling of multiple offer operations in PersistentVolumeTest.SendingCheckpointResourcesMessage.
Diffs (updated)
-----
src/tests/persistent_volume_tests.cpp 01b3c13751a5558d5f06edb8f650c8644dc54486
Diff: https://reviews.apache.org/r/40256/diff/
Testing
-------
This is the sixth in a chain of 7 patches. This patch was required in order to fix the `PersistentVolumeTest.SendingCheckpointResourcesMessage` test, which was broken by the addition of authorization to the `CREATE` and `DESTROY` offer operations. The test was previously both creating and destroying a persistent volume in a single `acceptOffer` message. However, our `validate` method for `DESTROY` offer operations correctly enforces that in order to delete a volume, the volume should be present in the checkpointed resources of the relevant Agent. This is likely not the case if the `CREATE` and `DESTROY` operations are both in the same message.
`make check` was used to test after all patches were applied.
Thanks,
Greg Mann