You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/11/17 12:57:27 UTC
[GitHub] [incubator-echarts] dvdkon opened a new pull request #13636: feat(axis): custom axis tick/label positions. close #13627
dvdkon opened a new pull request #13636:
URL: https://github.com/apache/incubator-echarts/pull/13636
<!-- Please fill in the following information to help us review your PR more efficiently. -->
## Brief Information
This pull request is in the type of:
- [ ] bug fixing
- [x] new feature
- [ ] others
### What does this PR do?
Add option `customValues` to `axisTick` and `axisLabel`, which allow the user to specify tick/label positions.
### Fixed issues
#13627 (my own issue)
## Details
### Before: What was the problem?
See issue #13627
### After: How is it fixed in this PR?
The new option allows for completely custom tick/label positions, for example:
```js
xAxis: {
type: 'value',
axisLabel: {
customValues: [0, 4, 7, 8, 9]
},
axisTick: {
alignWithLabel: true,
customValues: [0, 0.5, 1, 1.5, 2, 8, 9]
},
}
```
## Usage
### Are there any API changes?
- [x] The API has been changed.
In axis:
- `axisTick.customValues: (string | number | Date)[]`
- `axisLabel.customValues: (string | number | Date)[]`
Array of axis values on which a tick/label will be present (automatic tick generation is disabled)
### Related test cases or examples to use the new APIs
`test/axis-customTicks.html`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #13636: feat(axis): custom axis tick/label positions. close #13627
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #13636:
URL: https://github.com/apache/incubator-echarts/pull/13636#issuecomment-728909835
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/incubator-echarts/wiki/How-to-make-a-pull-request).
Document changes are required in this PR. Please also make a PR to [apache/incubator-echarts-doc](https://github.com/apache/incubator-echarts-doc) for document changes. When the doc PR is merged, the maintainers will remove the `PR: awaiting doc` label.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pissang commented on pull request #13636: feat(axis): custom axis tick/label positions. close #13627
Posted by GitBox <gi...@apache.org>.
pissang commented on pull request #13636:
URL: https://github.com/apache/incubator-echarts/pull/13636#issuecomment-729349436
We are planning features similar. Will discuss it together
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] dvdkon commented on pull request #13636: feat(axis): custom axis tick/label positions. close #13627
Posted by GitBox <gi...@apache.org>.
dvdkon commented on pull request #13636:
URL: https://github.com/apache/incubator-echarts/pull/13636#issuecomment-729480133
Thanks! That would be nice, I made this PR because it was quick and I wanted the feature sooner, but as long as ECharts has this functionality in some way, I'm happy.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pissang edited a comment on pull request #13636: feat(axis): custom axis tick/label positions. close #13627
Posted by GitBox <gi...@apache.org>.
pissang edited a comment on pull request #13636:
URL: https://github.com/apache/incubator-echarts/pull/13636#issuecomment-729349436
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org