You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by ru...@apache.org on 2020/10/26 00:56:08 UTC
[incubator-superset] branch master updated: style: fix labels
vertical align (#11415)
This is an automated email from the ASF dual-hosted git repository.
rusackas pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git
The following commit(s) were added to refs/heads/master by this push:
new 0ab1537 style: fix labels vertical align (#11415)
0ab1537 is described below
commit 0ab15373fae651bbb6854b40e9c252e38812b444
Author: Maxime Beauchemin <ma...@gmail.com>
AuthorDate: Sun Oct 25 17:55:22 2020 -0700
style: fix labels vertical align (#11415)
* style: fix labels vertical align
* addressed comments
* just adding the space for now
* fix timer
---
superset-frontend/src/components/DatabaseSelector.tsx | 3 +--
superset-frontend/src/components/Label/index.tsx | 1 +
superset-frontend/src/components/Timer.tsx | 4 ++--
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/superset-frontend/src/components/DatabaseSelector.tsx b/superset-frontend/src/components/DatabaseSelector.tsx
index f426e1a..52c3f7a 100644
--- a/superset-frontend/src/components/DatabaseSelector.tsx
+++ b/superset-frontend/src/components/DatabaseSelector.tsx
@@ -183,8 +183,7 @@ export default function DatabaseSelector({
function renderDatabaseOption(db: any) {
return (
<span title={db.database_name}>
- <Label bsStyle="default">{db.backend}</Label>
- {db.database_name}
+ <Label bsStyle="default">{db.backend}</Label> {db.database_name}
</span>
);
}
diff --git a/superset-frontend/src/components/Label/index.tsx b/superset-frontend/src/components/Label/index.tsx
index e87451f..44403be 100644
--- a/superset-frontend/src/components/Label/index.tsx
+++ b/superset-frontend/src/components/Label/index.tsx
@@ -42,6 +42,7 @@ const SupersetLabel = styled(BootstrapLabel)`
white-space: nowrap;
overflow: hidden;
text-overflow: ellipsis;
+ vertical-align: middle;
&:first-of-type {
margin-left: 0;
diff --git a/superset-frontend/src/components/Timer.tsx b/superset-frontend/src/components/Timer.tsx
index 3586103..22b11f4 100644
--- a/superset-frontend/src/components/Timer.tsx
+++ b/superset-frontend/src/components/Timer.tsx
@@ -30,8 +30,8 @@ interface TimerProps {
}
const TimerLabel = styled(Label)`
- width: 80px;
- text-align: right;
+ width: 96px;
+ text-align: center;
`;
export default function Timer({