You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/05/13 09:31:43 UTC

[GitHub] [incubator-seatunnel] ashulin opened a new pull request, #1871: [Api-Draft] SeaTunnel Source support Spark engine.

ashulin opened a new pull request, #1871:
URL: https://github.com/apache/incubator-seatunnel/pull/1871

   <!--
   
   Thank you for contributing to SeaTunnel! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
   
     - Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
   
     - Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
   
   -->
   
   ## Purpose of this pull request
   
   <!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
   
   Coordinated sources are not yet supported.
   The micro-batch reader is not yet implemented.
   The continuous reader is missing RPC.
   
   ## Check list
   
   * [ ] Code changed are covered with tests, or it does not need tests for reason:
   * [ ] If any new Jar binary package adding in your PR, please add License Notice according
     [New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
   * [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] ashulin commented on pull request #1871: [Api-Draft] SeaTunnel Source support Spark engine.

Posted by GitBox <gi...@apache.org>.
ashulin commented on PR #1871:
URL: https://github.com/apache/incubator-seatunnel/pull/1871#issuecomment-1127727528

   @ruanwenjun Please code review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] ruanwenjun merged pull request #1871: [Api-Draft] SeaTunnel Source support Spark engine.

Posted by GitBox <gi...@apache.org>.
ruanwenjun merged PR #1871:
URL: https://github.com/apache/incubator-seatunnel/pull/1871


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] ruanwenjun commented on pull request #1871: [Api-Draft] SeaTunnel Source support Spark engine.

Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on PR #1871:
URL: https://github.com/apache/incubator-seatunnel/pull/1871#issuecomment-1127155301

   CI failed due to code style
   ```java
   Error:  /home/runner/work/incubator-seatunnel/incubator-seatunnel/seatunnel-connectors/seatunnel-connectors-seatunnel/seatunnel-connectors-seatunnel-fake/src/main/java/org/apache/seatunnel/connectors/seatunnel/fake/source/FakeSourceSplitEnumerator.java:[26,7] 
   error: FakeSourceSplitEnumerator is not abstract and does not override abstract method currentUnassignedSplitSize() in SourceSplitEnumerator
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org