[GitHub] [beam] TheNeuralBit commented on a change in pull request #12521: [BEAM-8125] Add verifyDeterministic test to SchemaCoderTest

[GitBox <gi...@apache.org>]

TheNeuralBit commented on a change in pull request #12521:
URL: https://github.com/apache/beam/pull/12521#discussion_r468822570



##########
File path: sdks/java/core/src/test/java/org/apache/beam/sdk/schemas/SchemaCoderTest.java
##########
@@ -290,5 +329,31 @@ public void coderConsistentWithEquals() throws Exception {
         }
       }
     }
+
+    @Test
+    public void verifyDeterministic() throws Exception {
+      if (expectDeterministic) {
+        assertDeterministic(coder);
+      } else {
+        assertNonDeterministic(coder);
+      }
+    }
+  }
+
+  private static void assertDeterministic(SchemaCoder coder) {

Review comment:
       Thanks! Added a commit to use verifyDeterministic.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org