[GitHub] [beam] tvalentyn commented on a change in pull request #12150: [BEAM-10398] Use GitHub Actions in wheels release process for Python

[GitBox <gi...@apache.org>]

tvalentyn commented on a change in pull request #12150:
URL: https://github.com/apache/beam/pull/12150#discussion_r449160887



##########
File path: release/src/main/scripts/build_release_candidate.sh
##########
@@ -170,26 +174,50 @@ if [[ $confirmation = "y" ]]; then
   git clone ${GIT_REPO_URL}
   cd ${BEAM_ROOT_DIR}
   git checkout ${RELEASE_BRANCH}
+  git push origin "${RELEASE_BRANCH}"
+  RELEASE_COMMIT=$(git rev-parse --verify HEAD)
 
-  echo '-------------------Generating Python Artifacts-----------------'
-  cd sdks/python
-  virtualenv ${LOCAL_PYTHON_VIRTUALENV}
+  echo '-------------------Creating Python Virtualenv-----------------'
+  python3 -m venv ${LOCAL_PYTHON_VIRTUALENV}

Review comment:
       Python 3 sounds good. The version of Python 3 would likely be 3.6 or higher giving that most 3.5 is reaching EOL, so not too concerned about fstrings.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org