You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Laszlo Hornyak <la...@gmail.com> on 2014/02/02 18:03:19 UTC
Re: Review Request 17335: cleanup around seemingly impossible cast
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17335/
-----------------------------------------------------------
(Updated Feb. 2, 2014, 5:03 p.m.)
Review request for cloudstack, Alena Prokharchyk, Alex Huang, and Min Chen.
Changes
-------
Added Alena Prokharchyk API component owner as reviewer
Repository: cloudstack-git
Description
-------
- changed type parameters on details map in CreateSecondaryStagingStoreCmd - <String, String> was misleading since the it can not work with a string value and it is never a string
- introducing the type parameters allowed some simplifications in getDetails()
- added unit test
Diffs
-----
api/src/org/apache/cloudstack/api/command/admin/storage/CreateSecondaryStagingStoreCmd.java 1480e75
api/test/org/apache/cloudstack/api/command/admin/storage/CreateSecondaryStagingStoreCmdTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/17335/diff/
Testing
-------
- all unit tests passed
- checked all references and usage of the details field, injection with the @Parameter annotation
Thanks,
Laszlo Hornyak
Re: Review Request 17335: cleanup around seemingly impossible cast
Posted by Laszlo Hornyak <la...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17335/#review34060
-----------------------------------------------------------
License header!
- Laszlo Hornyak
On Feb. 2, 2014, 5:03 p.m., Laszlo Hornyak wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17335/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2014, 5:03 p.m.)
>
>
> Review request for cloudstack, Alena Prokharchyk, Alex Huang, and Min Chen.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> - changed type parameters on details map in CreateSecondaryStagingStoreCmd - <String, String> was misleading since the it can not work with a string value and it is never a string
> - introducing the type parameters allowed some simplifications in getDetails()
> - added unit test
>
>
> Diffs
> -----
>
> api/src/org/apache/cloudstack/api/command/admin/storage/CreateSecondaryStagingStoreCmd.java 1480e75
> api/test/org/apache/cloudstack/api/command/admin/storage/CreateSecondaryStagingStoreCmdTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/17335/diff/
>
>
> Testing
> -------
>
> - all unit tests passed
> - checked all references and usage of the details field, injection with the @Parameter annotation
>
>
> Thanks,
>
> Laszlo Hornyak
>
>
Re: Review Request 17335: cleanup around seemingly impossible cast
Posted by Pierre-Luc Dion <pd...@apache.org>.
> On Dec. 1, 2014, 4:16 a.m., Pierre-Luc Dion wrote:
> > commited: b838436e58a6e7df89d960c7805edc3fd3ed91a4
> > also added license header with commit: ed6016cf8ee655cb15796b8ffca9f6c29cf8d90d
Into master only.
- Pierre-Luc
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17335/#review63333
-----------------------------------------------------------
On Feb. 2, 2014, 5:03 p.m., Laszlo Hornyak wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17335/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2014, 5:03 p.m.)
>
>
> Review request for cloudstack, Alena Prokharchyk, Alex Huang, and Min Chen.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> - changed type parameters on details map in CreateSecondaryStagingStoreCmd - <String, String> was misleading since the it can not work with a string value and it is never a string
> - introducing the type parameters allowed some simplifications in getDetails()
> - added unit test
>
>
> Diffs
> -----
>
> api/src/org/apache/cloudstack/api/command/admin/storage/CreateSecondaryStagingStoreCmd.java 1480e75
> api/test/org/apache/cloudstack/api/command/admin/storage/CreateSecondaryStagingStoreCmdTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/17335/diff/
>
>
> Testing
> -------
>
> - all unit tests passed
> - checked all references and usage of the details field, injection with the @Parameter annotation
>
>
> Thanks,
>
> Laszlo Hornyak
>
>
Re: Review Request 17335: cleanup around seemingly impossible cast
Posted by Pierre-Luc Dion <pd...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17335/#review63333
-----------------------------------------------------------
Ship it!
commited: b838436e58a6e7df89d960c7805edc3fd3ed91a4
also added license header with commit: ed6016cf8ee655cb15796b8ffca9f6c29cf8d90d
- Pierre-Luc Dion
On Feb. 2, 2014, 5:03 p.m., Laszlo Hornyak wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17335/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2014, 5:03 p.m.)
>
>
> Review request for cloudstack, Alena Prokharchyk, Alex Huang, and Min Chen.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> - changed type parameters on details map in CreateSecondaryStagingStoreCmd - <String, String> was misleading since the it can not work with a string value and it is never a string
> - introducing the type parameters allowed some simplifications in getDetails()
> - added unit test
>
>
> Diffs
> -----
>
> api/src/org/apache/cloudstack/api/command/admin/storage/CreateSecondaryStagingStoreCmd.java 1480e75
> api/test/org/apache/cloudstack/api/command/admin/storage/CreateSecondaryStagingStoreCmdTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/17335/diff/
>
>
> Testing
> -------
>
> - all unit tests passed
> - checked all references and usage of the details field, injection with the @Parameter annotation
>
>
> Thanks,
>
> Laszlo Hornyak
>
>
Re: Review Request 17335: cleanup around seemingly impossible cast
Posted by Daan Hoogland <da...@gmail.com>.
will you add the license header then?
On Thu, Apr 17, 2014 at 7:36 PM, Laszlo Hornyak <la...@gmail.com>wrote:
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17335/
>
> On April 17th, 2014, 2:08 p.m. UTC, *daan Hoogland* wrote:
>
> Lazslo, you still want this reviewed/applied?
>
> Yes a review would be nice
>
>
> - Laszlo
>
> On February 2nd, 2014, 5:03 p.m. UTC, Laszlo Hornyak wrote:
> Review request for cloudstack, Alena Prokharchyk, Alex Huang, and Min
> Chen.
> By Laszlo Hornyak.
>
> *Updated Feb. 2, 2014, 5:03 p.m.*
> *Repository: * cloudstack-git
> Description
>
> - changed type parameters on details map in CreateSecondaryStagingStoreCmd - <String, String> was misleading since the it can not work with a string value and it is never a string
> - introducing the type parameters allowed some simplifications in getDetails()
> - added unit test
>
> Testing
>
> - all unit tests passed
> - checked all references and usage of the details field, injection with the @Parameter annotation
>
> Diffs
>
> - api/src/org/apache/cloudstack/api/command/admin/storage/CreateSecondaryStagingStoreCmd.java
> (1480e75)
> - api/test/org/apache/cloudstack/api/command/admin/storage/CreateSecondaryStagingStoreCmdTest.java
> (PRE-CREATION)
>
> View Diff <https://reviews.apache.org/r/17335/diff/>
>
--
Daan
Re: Review Request 17335: cleanup around seemingly impossible cast
Posted by Laszlo Hornyak <la...@gmail.com>.
> On April 17, 2014, 2:08 p.m., daan Hoogland wrote:
> > Lazslo, you still want this reviewed/applied?
Yes a review would be nice
- Laszlo
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17335/#review40645
-----------------------------------------------------------
On Feb. 2, 2014, 5:03 p.m., Laszlo Hornyak wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17335/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2014, 5:03 p.m.)
>
>
> Review request for cloudstack, Alena Prokharchyk, Alex Huang, and Min Chen.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> - changed type parameters on details map in CreateSecondaryStagingStoreCmd - <String, String> was misleading since the it can not work with a string value and it is never a string
> - introducing the type parameters allowed some simplifications in getDetails()
> - added unit test
>
>
> Diffs
> -----
>
> api/src/org/apache/cloudstack/api/command/admin/storage/CreateSecondaryStagingStoreCmd.java 1480e75
> api/test/org/apache/cloudstack/api/command/admin/storage/CreateSecondaryStagingStoreCmdTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/17335/diff/
>
>
> Testing
> -------
>
> - all unit tests passed
> - checked all references and usage of the details field, injection with the @Parameter annotation
>
>
> Thanks,
>
> Laszlo Hornyak
>
>
Re: Review Request 17335: cleanup around seemingly impossible cast
Posted by daan Hoogland <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17335/#review40645
-----------------------------------------------------------
Lazslo, you still want this reviewed/applied?
- daan Hoogland
On Feb. 2, 2014, 5:03 p.m., Laszlo Hornyak wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17335/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2014, 5:03 p.m.)
>
>
> Review request for cloudstack, Alena Prokharchyk, Alex Huang, and Min Chen.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> - changed type parameters on details map in CreateSecondaryStagingStoreCmd - <String, String> was misleading since the it can not work with a string value and it is never a string
> - introducing the type parameters allowed some simplifications in getDetails()
> - added unit test
>
>
> Diffs
> -----
>
> api/src/org/apache/cloudstack/api/command/admin/storage/CreateSecondaryStagingStoreCmd.java 1480e75
> api/test/org/apache/cloudstack/api/command/admin/storage/CreateSecondaryStagingStoreCmdTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/17335/diff/
>
>
> Testing
> -------
>
> - all unit tests passed
> - checked all references and usage of the details field, injection with the @Parameter annotation
>
>
> Thanks,
>
> Laszlo Hornyak
>
>