[jira] Commented: (MCHECKSTYLE-38) checsktyle:check seems to fail on warning too

["Brett Porter (JIRA)" <ji...@codehaus.org>]

    [ http://jira.codehaus.org/browse/MCHECKSTYLE-38?page=comments#action_63121 ] 

Brett Porter commented on MCHECKSTYLE-38:
-----------------------------------------

since this was in a release version, I'm not going to change the pending RC which was already voted on.

Is it unreasonable to fail on warnings? Would introducing a parameter that let them choose, defaulting to the current behaviour be acceptable?

> checsktyle:check seems to fail on warning too
> ---------------------------------------------
>
>          Key: MCHECKSTYLE-38
>          URL: http://jira.codehaus.org/browse/MCHECKSTYLE-38
>      Project: Maven 2.x Checkstyle Plugin
>         Type: Bug

>     Versions: 2.0
>     Reporter: Vincent Massol
>  Attachments: checkstyle-result.xml
>
>
> failOnViolation=true is supposed to fail only on errors but it seems to be failing on warnings too. See attached checkstyle result file which leads to
> {noformat}
> [...]
> [INFO] [checkstyle:check {execution: default}]
> [INFO] ------------------------------------------------------------------------
> [ERROR] BUILD FAILURE
> [INFO] ------------------------------------------------------------------------
> [INFO] You have 194 checkstyle violations.
> [INFO] ------------------------------------------------------------------------
> {noformat}
> I think the problem is that the code checks for an <error> tag whereas it should check for the "severity" attribute instead.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira