You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Alex Herbert (Jira)" <ji...@apache.org> on 2022/10/14 11:36:00 UTC
[jira] [Reopened] (NUMBERS-117) Redundant methods in several TestUtils classes
[ https://issues.apache.org/jira/browse/NUMBERS-117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Herbert reopened NUMBERS-117:
----------------------------------
> Redundant methods in several TestUtils classes
> ----------------------------------------------
>
> Key: NUMBERS-117
> URL: https://issues.apache.org/jira/browse/NUMBERS-117
> Project: Commons Numbers
> Issue Type: Improvement
> Reporter: Heinrich Bohne
> Priority: Minor
> Fix For: 1.0-beta1
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The following methods from the class {{TestUtils}} in the module _commons-numbers-core_ are redundant:
> |{{assertEquals(double, double, double)}}|{{Assertions.assertEquals(double, double, double)}} already considers two {{NaN}} values equal, so the two methods are equivalent.|
> |{{assertEquals(String, double, double, double)}}|Equivalent to {{Assertions.assertEquals(double, double, double, String)}}, as explained above|
> |{{assertSame(double, double)}}|Equivalent to {{Assertions.assertEquals(double, double)}}|
> |{{assertEquals(double[], double[], double)}}|Equivalent to {{Assertions.assertArrayEquals(double[], double[], double)}}|
> |{{assertEquals(String, double[], double[], double)}}|Equivalent to {{Assertions.assertArrayEquals(double[], double[], double, String)}}|
> |{{assertEquals(String, float[], float[], float)}}|Equivalent to {{Assertions.assertArrayEquals(float[], float[], float, String)}}|
> Similarly, the following methods from the class {{TestUtils}} in the module _commons-numbers-complex-streams_ are redundant:
> |{{assertEquals(double, double, double)}}|Equivalent to {{Assertions.assertEquals(double, double, double)}}, as explained above|
> |{{assertEquals(String, double, double, double)}}|Equivalent to {{Assertions.assertEquals(double, double, double, String)}}, as explained above|
> |{{assertSame(double[], double[])}}|Equivalent to {{Assertions.assertArrayEquals(double[], double[])}}|
> |{{assertSame(float[], float[])}}|Equivalent to {{Assertions.assertArrayEquals(float[], float[])}}|
> |{{assertSame(double, double)}}|Equivalent to {{Assertions.assertEquals(double, double)}}|
> |{{assertEquals(String, double[], double[], double)}}|Equivalent to {{Assertions.assertArrayEquals(double[], double[], double, String)}}|
> |{{assertEquals(String, float[], float[], float)}}|Equivalent to {{Assertions.assertArrayEquals(float[], float[], float, String)}}|
> |{{equalsIncludingNaN(double, double, double)}}|Equivalent to {{Precision.equalsIncludingNaN(double, double, double)}}|
> Finally, the following methods from the class {{TestUtils}} in the module _commons-numbers-complex_ are redundant:
> |{{assertEquals(double, double, double)}}|Equivalent to {{Assertions.assertEquals(double, double, double)}}, as explained above|
> |{{assertEquals(String, double, double, double)}}|Equivalent to {{Assertions.assertEquals(double, double, double, String)}}, as explained above|
> |{{assertSame(double, double)}}|Equivalent to {{Assertions.assertEquals(double, double)}}|
> |{{assertEquals(double[], double[], double)}}|Equivalent to {{Assertions.assertArrayEquals(double[], double[], double)}}|
> |{{assertEquals(String, double[], double[], double)}}|Equivalent to {{Assertions.assertArrayEquals(double[], double[], double, String)}}|
> |{{assertEquals(String, float[], float[], float)}}|Equivalent to {{Assertions.assertArrayEquals(float[], float[], float, String)}}|
> |{{equalsIncludingNaN(double, double, double)}}|Equivalent to {{Precision.equalsIncludingNaN(double, double, double)}}|
--
This message was sent by Atlassian Jira
(v8.20.10#820010)