You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@mesos.apache.org by "Jie Yu (JIRA)" <ji...@apache.org> on 2016/08/15 17:17:21 UTC

[jira] [Commented] (MESOS-6020) Remove `slavePid` from the Containerizer::launch API.

    [ https://issues.apache.org/jira/browse/MESOS-6020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15421292#comment-15421292 ] 

Jie Yu commented on MESOS-6020:
-------------------------------

commit 5f06d10b7b07bc80cd0ab77b37ce885ad9807257
Author: Gilbert Song <so...@gmail.com>
Date:   Mon Aug 15 10:16:35 2016 -0700

    Consolidated two executorEnvironment() calls in docker containerizer.
    
    Review: https://reviews.apache.org/r/51075/

> Remove `slavePid` from the Containerizer::launch API.
> -----------------------------------------------------
>
>                 Key: MESOS-6020
>                 URL: https://issues.apache.org/jira/browse/MESOS-6020
>             Project: Mesos
>          Issue Type: Task
>            Reporter: Jie Yu
>            Assignee: Gilbert Song
>
> Looks like we only pass in `slavePid` to construct executor environment variables for both containerizers.
> We should just construct the executor environment variables in the agent and pass them to Containerizer::launch.
> Given that containerizer interface will have to support launching sub-containers. Sub-containers might have a different set of environment variables than the executor.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)