[GitHub] [guacamole-client] mike-jumper commented on a diff in pull request #883: GUACAMOLE-1803: Update session recording playback at least once per second and allow arbitrary seeking.

["mike-jumper (via GitHub)" <gi...@apache.org>]

mike-jumper commented on code in PR #883:
URL: https://github.com/apache/guacamole-client/pull/883#discussion_r1228387914


##########
guacamole-common-js/src/main/webapp/modules/SessionRecording.js:
##########
@@ -684,14 +766,13 @@ Guacamole.SessionRecording = function SessionRecording(source) {
             // Pull the upcoming frame
             var next = frames[currentFrame + 1];
 
-            // Calculate the real timestamp corresponding to when the next
-            // frame begins
-            var nextRealTimestamp = next.timestamp - startVideoTimestamp + startRealTimestamp;
+            // Add the offset to the next frame timestamp to calculate the delay
+            var delay = toRelativeTimestamp(next.timestamp) - currentPosition;

Review Comment:
   Might we be able to avoid `refreshIntervalExecutor` entirely by using `refreshInterval` as the upper bound for `delay` here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org