You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/08/23 03:22:21 UTC
[jira] [Commented] (AVRO-1901) craeting a record called "Exception"
leads to generated code not compiling
[ https://issues.apache.org/jira/browse/AVRO-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15432064#comment-15432064 ]
ASF GitHub Bot commented on AVRO-1901:
--------------------------------------
GitHub user radai-rosenblatt opened a pull request:
https://github.com/apache/avro/pull/115
fix AVRO-1901 - record named "Exception" generated bad code
catch fully qualified java.lang.Exception in record template
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/radai-rosenblatt/avro bad-record-names
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/avro/pull/115.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #115
----
commit 03878971e081e9ae92afac1e474582065e95e012
Author: radai-rosenblatt <ra...@gmail.com>
Date: 2016-08-23T03:16:58Z
AVRO-1901 - add test case demonstrating issue
commit 26e81a21e30365924e8f6d4ddddbb250ef5b0404
Author: radai-rosenblatt <ra...@gmail.com>
Date: 2016-08-23T03:18:18Z
AVRO-1901 - fix issue by catching java.lang.Exception (fully qualified)
----
> craeting a record called "Exception" leads to generated code not compiling
> --------------------------------------------------------------------------
>
> Key: AVRO-1901
> URL: https://issues.apache.org/jira/browse/AVRO-1901
> Project: Avro
> Issue Type: Bug
> Components: java
> Affects Versions: 1.7.7, 1.8.1, 1.9.0
> Reporter: radai rosenblatt
>
> consider the following *.avsc file:
> {code:title=Exception.avsc}
> {
> "type": "record",
> "name": "Exception",
> "namespace": "com.acme",
> "fields" : [
> {"name": "value", "type": "int"}
> ],
> "doc": "Will not submit to your fascist naming conventions"
> }
> {code}
> the generated java code will contain:
> {code:title=Exception.java}
> ...
> @override
> public Exception build() {
> try {
> ...
> return record;
> } catch (Exception e) { //boom
> throw new org.apache.avro.AvroRuntimeException(e);
> }
> }
> {code}
> which fails to compile because Exception refers to the generated class (which does not extend Throwable)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)