You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@myfaces.apache.org by GitBox <gi...@apache.org> on 2022/09/02 15:17:48 UTC

[GitHub] [myfaces] volosied commented on a diff in pull request #300: MYFACES-4450: Render tabindex for outputLabel

volosied commented on code in PR #300:
URL: https://github.com/apache/myfaces/pull/300#discussion_r961789954


##########
shared/src/main/java/org/apache/myfaces/shared/renderkit/html/CommonPropertyUtils.java:
##########
@@ -531,11 +531,7 @@ public static void renderLabelPassthroughPropertiesWithoutEvents(ResponseWriter
             long commonPropertiesMarked, UIComponent component) 
     throws IOException
     {
-        if ((commonPropertiesMarked & CommonPropertyConstants.ACCESSKEY_PROP) != 0)
-        {
-            HtmlRendererUtils.renderHTMLStringAttribute(writer, component,
-                    HTML.ACCESSKEY_ATTR, HTML.ACCESSKEY_ATTR);
-        }
+        renderAccesskeyTabindexProperties(writer, commonPropertiesMarked, component);

Review Comment:
   ACCESSKEY_PROP is rendered within renderAccesskeyTabindexProperties, so the only addition is the tabindex 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org