You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "John Casey (JIRA)" <ji...@codehaus.org> on 2007/04/04 20:35:20 UTC

[jira] Created: (DOXIA-106) When using a template from a custom skin, default images and css from doxia-site-renderer are not copied to rendered site

When using a template from a custom skin, default images and css from doxia-site-renderer are not copied to rendered site
-------------------------------------------------------------------------------------------------------------------------

                 Key: DOXIA-106
                 URL: http://jira.codehaus.org/browse/DOXIA-106
             Project: doxia
          Issue Type: Bug
          Components: Site Renderer
    Affects Versions: 1.0-alpha-8
         Environment: maven-site-plugin 2.0-beta-5; maven 2.0.5
            Reporter: John Casey


I've created my own Velocity template for rendering site pages, and included it in my own site skin. The skin makes no changes to the built-by image, or the maven-base or print CSS files. However, when I use the new skin, none of these files are found in the site. This leads to massive formatting problems and missing icons/images all over the place.

When I copy the images/ and css/ directories out of the doxia-site-renderer/src/main/resources/... directory structure into my skin, all is fine.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (DOXIA-106) When using a template from a custom skin, default images and css from doxia-site-renderer are not copied to rendered site

Posted by "Grégory Joseph (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/DOXIA-106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=139456#action_139456 ] 

Grégory Joseph commented on DOXIA-106:
--------------------------------------

I might be wrong - but it seems the same issue happens for plugins/reports resources, which becomes a problem - how could the skin author know what reports will be included and copy all their icons/resources ?

> When using a template from a custom skin, default images and css from doxia-site-renderer are not copied to rendered site
> -------------------------------------------------------------------------------------------------------------------------
>
>                 Key: DOXIA-106
>                 URL: http://jira.codehaus.org/browse/DOXIA-106
>             Project: Maven Doxia
>          Issue Type: Bug
>          Components: Site Renderer
>    Affects Versions: 1.0-alpha-8
>         Environment: maven-site-plugin 2.0-beta-5; maven 2.0.5
>            Reporter: John Casey
>
> I've created my own Velocity template for rendering site pages, and included it in my own site skin. The skin makes no changes to the built-by image, or the maven-base or print CSS files. However, when I use the new skin, none of these files are found in the site. This leads to massive formatting problems and missing icons/images all over the place.
> When I copy the images/ and css/ directories out of the doxia-site-renderer/src/main/resources/... directory structure into my skin, all is fine.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] Commented: (DOXIA-106) When using a template from a custom skin, default images and css from doxia-site-renderer are not copied to rendered site

Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/DOXIA-106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_92094 ] 

Dennis Lundberg commented on DOXIA-106:
---------------------------------------

This is the behavior that I would expect. Anyone who creates a skin should supply the needed images and style sheets for it.

Were you expecting the images and style sheets to be "inherited" from a parent skin, or site renderer itself?

> When using a template from a custom skin, default images and css from doxia-site-renderer are not copied to rendered site
> -------------------------------------------------------------------------------------------------------------------------
>
>                 Key: DOXIA-106
>                 URL: http://jira.codehaus.org/browse/DOXIA-106
>             Project: doxia
>          Issue Type: Bug
>          Components: Site Renderer
>    Affects Versions: 1.0-alpha-8
>         Environment: maven-site-plugin 2.0-beta-5; maven 2.0.5
>            Reporter: John Casey
>
> I've created my own Velocity template for rendering site pages, and included it in my own site skin. The skin makes no changes to the built-by image, or the maven-base or print CSS files. However, when I use the new skin, none of these files are found in the site. This leads to massive formatting problems and missing icons/images all over the place.
> When I copy the images/ and css/ directories out of the doxia-site-renderer/src/main/resources/... directory structure into my skin, all is fine.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (DOXIA-106) When using a template from a custom skin, default images and css from doxia-site-renderer are not copied to rendered site

Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/DOXIA-106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dennis Lundberg closed DOXIA-106.
---------------------------------

       Resolution: Won't Fix
    Fix Version/s:     (was: 1.0)

> When using a template from a custom skin, default images and css from doxia-site-renderer are not copied to rendered site
> -------------------------------------------------------------------------------------------------------------------------
>
>                 Key: DOXIA-106
>                 URL: http://jira.codehaus.org/browse/DOXIA-106
>             Project: Maven Doxia
>          Issue Type: Bug
>          Components: Site Renderer
>    Affects Versions: 1.0-alpha-8
>         Environment: maven-site-plugin 2.0-beta-5; maven 2.0.5
>            Reporter: John Casey
>
> I've created my own Velocity template for rendering site pages, and included it in my own site skin. The skin makes no changes to the built-by image, or the maven-base or print CSS files. However, when I use the new skin, none of these files are found in the site. This leads to massive formatting problems and missing icons/images all over the place.
> When I copy the images/ and css/ directories out of the doxia-site-renderer/src/main/resources/... directory structure into my skin, all is fine.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (DOXIA-106) When using a template from a custom skin, default images and css from doxia-site-renderer are not copied to rendered site

Posted by "Grégory Joseph (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/DOXIA-106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=139454#action_139454 ] 

Grégory Joseph commented on DOXIA-106:
--------------------------------------

Based on the names of the css files, I'd actually expect maven-base.css to always be copied (possibly overriden if the skin author should chose so), whereas maven-theme.css would be where the actual theming happens. Having maven-base.css there would help when new versions of the site components are released, providing good defaults until the skin author wants to further customize them.

> When using a template from a custom skin, default images and css from doxia-site-renderer are not copied to rendered site
> -------------------------------------------------------------------------------------------------------------------------
>
>                 Key: DOXIA-106
>                 URL: http://jira.codehaus.org/browse/DOXIA-106
>             Project: Maven Doxia
>          Issue Type: Bug
>          Components: Site Renderer
>    Affects Versions: 1.0-alpha-8
>         Environment: maven-site-plugin 2.0-beta-5; maven 2.0.5
>            Reporter: John Casey
>
> I've created my own Velocity template for rendering site pages, and included it in my own site skin. The skin makes no changes to the built-by image, or the maven-base or print CSS files. However, when I use the new skin, none of these files are found in the site. This leads to massive formatting problems and missing icons/images all over the place.
> When I copy the images/ and css/ directories out of the doxia-site-renderer/src/main/resources/... directory structure into my skin, all is fine.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] Issue Comment Edited: (DOXIA-106) When using a template from a custom skin, default images and css from doxia-site-renderer are not copied to rendered site

Posted by "Grégory Joseph (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/DOXIA-106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=139456#action_139456 ] 

gjoseph edited comment on DOXIA-106 at 6/24/08 11:22 AM:
----------------------------------------------------------------

I'd expect the same for all resources, not just the css - currently skins have to copy all resources, icons etc. Having overridable defaults would be nice.

      was (Author: gjoseph):
    I might be wrong - but it seems the same issue happens for plugins/reports resources, which becomes a problem - how could the skin author know what reports will be included and copy all their icons/resources ?
  
> When using a template from a custom skin, default images and css from doxia-site-renderer are not copied to rendered site
> -------------------------------------------------------------------------------------------------------------------------
>
>                 Key: DOXIA-106
>                 URL: http://jira.codehaus.org/browse/DOXIA-106
>             Project: Maven Doxia
>          Issue Type: Bug
>          Components: Site Renderer
>    Affects Versions: 1.0-alpha-8
>         Environment: maven-site-plugin 2.0-beta-5; maven 2.0.5
>            Reporter: John Casey
>
> I've created my own Velocity template for rendering site pages, and included it in my own site skin. The skin makes no changes to the built-by image, or the maven-base or print CSS files. However, when I use the new skin, none of these files are found in the site. This leads to massive formatting problems and missing icons/images all over the place.
> When I copy the images/ and css/ directories out of the doxia-site-renderer/src/main/resources/... directory structure into my skin, all is fine.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Issue Comment Edited: (DOXIA-106) When using a template from a custom skin, default images and css from doxia-site-renderer are not copied to rendered site

Posted by "Grégory Joseph (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/DOXIA-106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=139454#action_139454 ] 

gjoseph edited comment on DOXIA-106 at 6/24/08 10:33 AM:
----------------------------------------------------------------

Based on the names of the css files, I'd actually expect maven-base.css to always be copied (possibly overriden if the skin author should chose so), whereas maven-theme.css would be where the actual theming happens. Having maven-base.css there would help when new versions of the site components are released, providing good defaults until the skin author wants to further customize them. (and generally avoiding unnecessary copy pasting of these files)

      was (Author: gjoseph):
    Based on the names of the css files, I'd actually expect maven-base.css to always be copied (possibly overriden if the skin author should chose so), whereas maven-theme.css would be where the actual theming happens. Having maven-base.css there would help when new versions of the site components are released, providing good defaults until the skin author wants to further customize them.
  
> When using a template from a custom skin, default images and css from doxia-site-renderer are not copied to rendered site
> -------------------------------------------------------------------------------------------------------------------------
>
>                 Key: DOXIA-106
>                 URL: http://jira.codehaus.org/browse/DOXIA-106
>             Project: Maven Doxia
>          Issue Type: Bug
>          Components: Site Renderer
>    Affects Versions: 1.0-alpha-8
>         Environment: maven-site-plugin 2.0-beta-5; maven 2.0.5
>            Reporter: John Casey
>
> I've created my own Velocity template for rendering site pages, and included it in my own site skin. The skin makes no changes to the built-by image, or the maven-base or print CSS files. However, when I use the new skin, none of these files are found in the site. This leads to massive formatting problems and missing icons/images all over the place.
> When I copy the images/ and css/ directories out of the doxia-site-renderer/src/main/resources/... directory structure into my skin, all is fine.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira