You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/11/25 07:07:47 UTC

[GitHub] [pulsar] abhilashmandaliya opened a new issue #8694: advertisedListener should have advertisedPort as well

abhilashmandaliya opened a new issue #8694:
URL: https://github.com/apache/pulsar/issues/8694


   **Is your enhancement request related to a problem? Please describe.**
   From pulsar 2.6.x, you guys have introduced `advertisedListeners` which is a useful feature. But the problem with that is, it uses the broker/web port underneath which is a problem. Let's say I have 2 containers running pulsar broker and they have the same public IP because they are on the same physical host (e.g. IP 192.168.201.202). So both of them tries to create health check topic with 8080 ports and it fails. Both of them forms the address 192.168.201.202:8080 and of course, it's not possible to serve two nodes on the same port on the same machine. 
   
   **Describe the solution you'd like**
   There should be an option to advertise ports separately. Maybe 4 separate ports(advertisedBrokerPort, advertisedBrokerPortTls, webServicePort, webServicePortTls) from where the outside world can connect.
   
   **Describe alternatives you've considered**
   My colleague and I had created an end-to-end solution for this where we exposed all 4 ports I mentioned above at https://github.com/ashishshinde/pulsar/tree/advertised-ports-master-rebase. While raising a PR, I found that you guys have already worked halfway by creating advertisedListeners. The advertisedListeners is anyways not documented on the main site so we can also think of our alternative. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] abhilashmandaliya commented on issue #8694: advertisedListener should have advertisedPort as well

Posted by GitBox <gi...@apache.org>.
abhilashmandaliya commented on issue #8694:
URL: https://github.com/apache/pulsar/issues/8694#issuecomment-734219275


   > @abhilashmandaliya I think the advertisedListeners does not works for webservice. Could you please send a PIP to the dev mail thread? So that we can have a discussion with the new feature( advertise ports separately) as well.
   
   @codelipenghui  how can I generate PIP?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] abhilashmandaliya closed issue #8694: advertisedListener should have advertisedPort as well

Posted by GitBox <gi...@apache.org>.
abhilashmandaliya closed issue #8694:
URL: https://github.com/apache/pulsar/issues/8694


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] codelipenghui commented on issue #8694: advertisedListener should have advertisedPort as well

Posted by GitBox <gi...@apache.org>.
codelipenghui commented on issue #8694:
URL: https://github.com/apache/pulsar/issues/8694#issuecomment-733725301


   @Huanli-Meng @Jennifer88huang I think we can add a document for the `advertisedListeners`. You can find some details about the advertisedListeners at https://github.com/apache/pulsar/wiki/PIP-61%3A-Advertised-multiple-addresses. If you have any problems you can ping me.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] Anonymitaet commented on issue #8694: advertisedListener should have advertisedPort as well

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on issue #8694:
URL: https://github.com/apache/pulsar/issues/8694#issuecomment-749847876


   I've removed the `doc-required` label since @Huanli-Meng has added the doc.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] codelipenghui commented on issue #8694: advertisedListener should have advertisedPort as well

Posted by GitBox <gi...@apache.org>.
codelipenghui commented on issue #8694:
URL: https://github.com/apache/pulsar/issues/8694#issuecomment-734522504


   @abhilashmandaliya You can draft a PIP with google doc? and send it to the dev@pulsar.apache.org mail list so that we can discuss the new feature there. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] codelipenghui commented on issue #8694: advertisedListener should have advertisedPort as well

Posted by GitBox <gi...@apache.org>.
codelipenghui commented on issue #8694:
URL: https://github.com/apache/pulsar/issues/8694#issuecomment-733724059


   @abhilashmandaliya I think the advertisedListeners does not works for webservice. Could you please send a PIP to the dev mail thread? So that we can have a discussion with the new feature( advertise ports separately) as well.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] abhilashmandaliya commented on issue #8694: advertisedListener should have advertisedPort as well

Posted by GitBox <gi...@apache.org>.
abhilashmandaliya commented on issue #8694:
URL: https://github.com/apache/pulsar/issues/8694#issuecomment-742982743


   > @abhilashmandaliya You can draft a PIP with google doc? and send it to the [dev@pulsar.apache.org](mailto:dev@pulsar.apache.org) mail list so that we can discuss the new feature there.
   
   it is here @codelipenghui https://docs.google.com/document/d/1YelHBuFAAYkmRNWzhVg4j39-VovGb9Ng2_Vg6zbCqGM/edit?usp=sharing


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org