[jira] [Commented] (ARROW-2167) [C++] Building Orc extensions fails with the default BUILD_WARNING_LEVEL=Production

["Phillip Cloud (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARROW-2167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16367476#comment-16367476 ] 

Phillip Cloud commented on ARROW-2167:
--------------------------------------

ping [~jim.crist]

> [C++] Building Orc extensions fails with the default BUILD_WARNING_LEVEL=Production
> -----------------------------------------------------------------------------------
>
>                 Key: ARROW-2167
>                 URL: https://issues.apache.org/jira/browse/ARROW-2167
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++
>    Affects Versions: 0.8.0
>            Reporter: Phillip Cloud
>            Priority: Major
>
> Building orc_ep fails because there are a bunch of upstream warnings like not providing {{override}} on virtual destructor subclasses, and using {{0}} as the {{nullptr}} constant and the default {{BUILD_WARNING_LEVEL}} is {{Production}} which includes {{-Wall}} (all warnings as errors).
> I see that there are different possible options for {{BUILD_WARNING_LEVEL}} so it's possible for developers to deal with this issue.
> It seems easier to let EPs build with whatever the default warning level is for the project rather than force our defaults on those projects.
> Generally speaking, are we using our own CXX_FLAGS for EPs other than Orc?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)