You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by "Edelson, Justin" <Ju...@mtvi.com> on 2004/05/11 18:11:47 UTC

[email] is email in bugzilla?

I'm trying to find where to submit a patch for email. It doesn't seem to
be in bugzilla.

In any case, I'd like to add a setHostPort(int) method to the
o.a.c.m.Email class. Here's the patch:
Index: Email.java
===================================================================
retrieving revision 1.15
diff -u -r1.15 Email.java
--- Email.java	19 Feb 2004 22:38:09 -0000	1.15
+++ Email.java	11 May 2004 16:11:03 -0000
@@ -58,6 +58,7 @@
     public static final String CONTENT_TYPE = "content.type";
 
     public static final String MAIL_HOST = "mail.host";
+    public static final String MAIL_PORT = "mail.smtp.port";
     public static final String MAIL_SMTP_FROM = "mail.smtp.from";
     public static final String MAIL_SMTP_AUTH = "mail.smtp.auth";
     public static final String MAIL_TRANSPORT_PROTOCOL =
"mail.transport.protocol";
@@ -110,6 +111,11 @@
     * to get property from system.properties. If still null, quit
     */
     private String hostName = null;
+    
+    /**
+     * The port of the mail server with which to connect.
+     */
+    private int hostPort = 25;
 
     /** List of "to" email adresses */
     private ArrayList toList = null;
@@ -258,6 +264,7 @@
 
         properties.setProperty(MAIL_HOST, hostName);
         properties.setProperty(MAIL_DEBUG,new
Boolean(this.debug).toString());
+        properties.setProperty(MAIL_PORT, ""+hostPort);
 
         if (this.authenticator!= null)
         {
@@ -753,5 +760,15 @@
             (InternetAddress[]) aList.toArray(new InternetAddress[0]);
 
         return ia;
+    }
+    
+    /**
+     * Set the port of the outgoing mail server
+     *
+     * @param   aHostPort
+     */
+    public void setHostPort(int aHostPort)
+    {
+        this.hostPort = aHostPort;
     }
 }

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Re: [email] is email in bugzilla?

Posted by Martin Cooper <ma...@apache.org>.
On Tue, 11 May 2004, Edelson, Justin wrote:

> I'm trying to find where to submit a patch for email. It doesn't seem to
> be in bugzilla.

The email component is still in the sandbox, so you should choose
'sandbox' as the component name in Bugzilla, and preferably prefix the
summary with '[email]' to make the actual component clear.

--
Martin Cooper


>
> In any case, I'd like to add a setHostPort(int) method to the
> o.a.c.m.Email class. Here's the patch:
> Index: Email.java
> ===================================================================
> retrieving revision 1.15
> diff -u -r1.15 Email.java
> --- Email.java	19 Feb 2004 22:38:09 -0000	1.15
> +++ Email.java	11 May 2004 16:11:03 -0000
> @@ -58,6 +58,7 @@
>      public static final String CONTENT_TYPE = "content.type";
>
>      public static final String MAIL_HOST = "mail.host";
> +    public static final String MAIL_PORT = "mail.smtp.port";
>      public static final String MAIL_SMTP_FROM = "mail.smtp.from";
>      public static final String MAIL_SMTP_AUTH = "mail.smtp.auth";
>      public static final String MAIL_TRANSPORT_PROTOCOL =
> "mail.transport.protocol";
> @@ -110,6 +111,11 @@
>      * to get property from system.properties. If still null, quit
>      */
>      private String hostName = null;
> +
> +    /**
> +     * The port of the mail server with which to connect.
> +     */
> +    private int hostPort = 25;
>
>      /** List of "to" email adresses */
>      private ArrayList toList = null;
> @@ -258,6 +264,7 @@
>
>          properties.setProperty(MAIL_HOST, hostName);
>          properties.setProperty(MAIL_DEBUG,new
> Boolean(this.debug).toString());
> +        properties.setProperty(MAIL_PORT, ""+hostPort);
>
>          if (this.authenticator!= null)
>          {
> @@ -753,5 +760,15 @@
>              (InternetAddress[]) aList.toArray(new InternetAddress[0]);
>
>          return ia;
> +    }
> +
> +    /**
> +     * Set the port of the outgoing mail server
> +     *
> +     * @param   aHostPort
> +     */
> +    public void setHostPort(int aHostPort)
> +    {
> +        this.hostPort = aHostPort;
>      }
>  }
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org