[jira] [Updated] (MINIFICPP-1121) Upgrade spdlog

["Adam Hunyadi (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/MINIFICPP-1121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adam Hunyadi updated MINIFICPP-1121:
------------------------------------
    Flagged: Impediment

> Upgrade spdlog
> --------------
>
>                 Key: MINIFICPP-1121
>                 URL: https://issues.apache.org/jira/browse/MINIFICPP-1121
>             Project: Apache NiFi MiNiFi C++
>          Issue Type: Improvement
>            Reporter: Marton Szasz
>            Assignee: Adam Hunyadi
>            Priority: Minor
>              Labels: MiNiFi-CPP-Hygiene
>          Time Spent: 3h 50m
>  Remaining Estimate: 0h
>
> Or version of spdlog is 2+ years old. The new spdlog version uses a new version of the cppformat (back then)/fmt (now) formatting library.
> We should consider directly depending on {{fmt}} since we already have it as a transitive dependency and it would be useful for e.g. formatting exception/error messages, etc.
>  
> *Update (hunyadi):*
> Seems like we have to skip version 1.0 with upgrading. There are quite a lot of non-documented breaking changes, for example this commit:
>  [https://github.com/gabime/spdlog/commit/6f4cd8d397a443f095c1dce5c025f55684c70eac#diff-9458442ae281c51018015fd2773dc688]
>  breaks ::instance() on stdout/stderr sinks. Unfortunately, changes like this in spdlog are not documented and the codebase is kept up-to-date with commits sent directly to the central repository.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)