You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by soralee <gi...@git.apache.org> on 2017/06/05 06:18:55 UTC
[GitHub] zeppelin pull request #2394: [gh-pages] [ZEPPELIN-2597] adding technologies ...
GitHub user soralee opened a pull request:
https://github.com/apache/zeppelin/pull/2394
[gh-pages] [ZEPPELIN-2597] adding technologies and deployments (Main Page)
### What is this PR for?
This PR is for Improving more comfortable guidance for point of user view in the main zeppelin homepage.
To sum up, Technologies section is consist of 3 interpreters most people search or want (already talking about this on the mailing list.) and, Deployments section describes single or multiple user setting.
### What type of PR is it?
[Improvement]
### What is the Jira issue?
* [ZEPPELIN-2597](https://issues.apache.org/jira/browse/ZEPPELIN-2597)
### How should this be tested?
1. run `bundle exec jekyll serve --watch` in this branch
2. open `localhost:4000`
### Screenshots (if appropriate)
- Look `Technologies` and `Deployments` sections
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? Yes, this is.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/soralee/zeppelin adding_technologies_and_deployments
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2394.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2394
----
commit b8105cd3c09a8c2b56e190a4e18fb64a2c7b114d
Author: soralee <so...@zepl.com>
Date: 2017-06-05T06:08:14Z
adding technologies and deployments
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2394: [gh-pages] [ZEPPELIN-2597] adding technologies and dep...
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/2394
@AhyoungRyu I updated as your mentions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2394: [gh-pages] [ZEPPELIN-2597] adding technologies and dep...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2394
LGTM.
## Chrome on OSX
## Safari on OSX
## Old version Firefox (v31) on OSX
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2394: [gh-pages] [ZEPPELIN-2597] adding technologies and dep...
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/2394
@1ambda, How about that connecting the latest version documentation? we'd better to guide the latest version to user.
```
spark - http://zeppelin.apache.org/docs/0.7.2/interpreter/spark.html
sql - http://zeppelin.apache.org/docs/0.7.2/interpreter/jdbc.html
python - http://zeppelin.apache.org/docs/0.7.2/interpreter/python.html
single user - http://zeppelin.apache.org/docs/0.7.2/install/install.html
multi user - http://zeppelin.apache.org/docs/0.7.2/security/shiroauthentication.html
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2394: [gh-pages] [ZEPPELIN-2597] adding technologies and dep...
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/2394
@1ambda , I've update regarding of `7.Improve layout for mobile browsers.` could you confirm, again?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2394: [gh-pages] [ZEPPELIN-2597] adding technologies and dep...
Posted by sravan-s <gi...@git.apache.org>.
Github user sravan-s commented on the issue:
https://github.com/apache/zeppelin/pull/2394
@soralee , sorry, I am having some trouble installing jekyll and stuff in my machine, but your screenshots looks good :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2394: [gh-pages] [ZEPPELIN-2597] adding technologies and dep...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2394
7. Improve layout for mobile browsers.
7-1. each `panel-content` in the **TECHNOLOGIES** section doesn't have margin-top or bottom. It's not consistent compared to `panel-content-user` in the **DEPLOYMENTS** section.
7-2. It would be nice to add `padding-left` and `padding-left` to `.advertise` (30px might be proper.)
### Current
### After
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2394: [gh-pages] [ZEPPELIN-2597] adding technologies and dep...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2394
@soralee Since https://github.com/apache/zeppelin/pull/2371 was merged, we can fix the URL names in this PR too.
- for spark button: `${PROPER_PREFIX_FOR_0.8.0}/quickstart/spark_with_zeppelin.html`
- for sql button: `${PROPER_PREFIX_FOR_0.8.0}/quickstart/sql_with_zeppelin.html`
- for python button: `${PROPER_PREFIX_FOR_0.8.0}/quickstart/python_with_zeppelin.html`
- single user button: `${PROPER_PREFIX_FOR_0.8.0}/quickstart/install.html`
- multi user button: `${PROPER_PREFIX_FOR0.8.0}/setup/basics/multi_user_support.html`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2394: [gh-pages] [ZEPPELIN-2597] adding technologies ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2394
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2394: [gh-pages] [ZEPPELIN-2597] adding technologies and dep...
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/2394
@1ambda Thanks a lots of! you're the best! :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2394: [gh-pages] [ZEPPELIN-2597] adding technologies and dep...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2394
Yeah second option is better for me :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2394: [gh-pages] [ZEPPELIN-2597] adding technologies and dep...
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/2394
or to decorate in Deployments section, How about this structure?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2394: [gh-pages] [ZEPPELIN-2597] adding technologies and dep...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2394
Looks good to me. Thanks for your contribution.
Merge if no more discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2394: [gh-pages] [ZEPPELIN-2597] adding technologies and dep...
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/2394
@AhyoungRyu, Thanks for review and suggestions!
Sure, I can change the border color in Technologies section and, I can remove icons in Deployments section.
IMO, about Deployments section, actually the current structure is good to me (including icons).
And especially the buttons, it would be better to keep the current structure to match the buttons in the above technologies.
How about this? :slightly_smiling_face:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2394: [gh-pages] [ZEPPELIN-2597] adding technologies and dep...
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/2394
@1ambda Thanks for arranging list
Updated it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2394: [gh-pages] [ZEPPELIN-2597] adding technologies and dep...
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/2394
@1ambda, I just finished the list about all your comment.
For help to easy your review, I involved comment numbers in title message when I commit.
I appreciate for taking care of this PR, all detailed comment as well!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2394: [gh-pages] [ZEPPELIN-2597] adding technologies and dep...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2394
Thanks for your great effort @soralee. LGTM! except
* [ ] - comments 4
* [ ] - comments 8
* [ ] - comments 9-1, 9-2, 9-3
* [ ] - comments 10
* [ ] - comments 11
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2394: [gh-pages] [ZEPPELIN-2597] adding technologies and dep...
Posted by sravan-s <gi...@git.apache.org>.
Github user sravan-s commented on the issue:
https://github.com/apache/zeppelin/pull/2394
I think it would be better if the font sizes inside top box(technologies) and bottom(deployments) were of same size and had a uniform margin / padding scheme. Also about **use now** and **learn more** buttons
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2394: [gh-pages] [ZEPPELIN-2597] adding technologies and dep...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2394
Looks good to me and agree that use old links unile we deploy 0.8.0
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2394: [gh-pages] [ZEPPELIN-2597] adding technologies and dep...
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/2394
@sravan-s, I've fixed to match font size as your mention. Regarding of `uniform margin / padding scheme` I tried to fit the box ratio. could you check this if you have time?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2394: [gh-pages] [ZEPPELIN-2597] adding technologies and dep...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2394
@soralee Could you resolve conflict?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2394: [gh-pages] [ZEPPELIN-2597] adding technologies and dep...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2394
11. Adjustment margin among components
- `padding-bottom: 30px` for `.tech_deploy h2`
- remove the css `tech_deploy` class in `technologies_deployments.md` LINE16: `tech_deploy container` -> `container`
- `padding-top: 22px` and `padding-bottom: 40px` for `.tech_deploy`
- remove `padding-bottom` and `margin-top` in `technologies_deployments.md: LINE 52`
- remove `padding-bottom` and `padding-top` in the `.tech_deploy p` class. (DON'T SET to 0, just remove the style)
- `margin-top: 25px`, `margin-bottom: 30px` for `.tech_deploy p`
- inline style `padding-bottom: 8px;` for **DEPLOYMENTS** `h2`
### Current
### After
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2394: [gh-pages] [ZEPPELIN-2597] adding technologies and dep...
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/2394
@1ambda Fixed!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2394: [gh-pages] [ZEPPELIN-2597] adding technologies and dep...
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/2394
@AhyoungRyu @1ambda @Leemoonsoo, please review again!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2394: [gh-pages] [ZEPPELIN-2597] adding technologies and dep...
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/2394
some improving list
- arranged to same line each 'use now' button in the Technologies.
- changed contents font style in Technologies and Deployments.
- removed bold font of buttons in the Deployments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2394: [gh-pages] [ZEPPELIN-2597] adding technologies and dep...
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/2394
Yeah, I updated it (:
thanks @1ambda
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2394: [gh-pages] [ZEPPELIN-2597] adding technologies and dep...
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/2394
Ping, ready to review!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2394: [gh-pages] [ZEPPELIN-2597] adding technologies and dep...
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/2394
@AhyoungRyu, Thanks for accepting :+1:
Let me improve this and let you know.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2394: [gh-pages] [ZEPPELIN-2597] adding technologies and dep...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2394
Thanks for the great work @soralee! And also thanks for detailed review @1ambda.
Tested and looks nice!
I really like the most of parts. Some minor suggestion is
#### Technologies
- how about using same border color with "Deployment" box `#999` instead of `#4881B3`?
<img width="997" alt="screen shot 2017-06-06 at 7 36 05 pm" src="https://user-images.githubusercontent.com/10060731/26859880-7f3df818-4aef-11e7-9364-a0274c2642bf.png">
#### Deployment
- how about putting "LEARN MORE" buttons in each deployment section box in the middle instead of right side?
- and also we can remove the single & multi user font awesome icons since the text ("single" and "multi") itself already explain what "single-user" and "multi-user" are meaning for.
How about this? It's just my opinion. Please have a look and feel free to share your thought :)
<img width="990" alt="screen shot 2017-06-06 at 7 25 45 pm" src="https://user-images.githubusercontent.com/10060731/26859800-0d9d5cf8-4aef-11e7-804c-3f93a1ae035d.png">
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2394: [gh-pages] [ZEPPELIN-2597] adding technologies and dep...
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/2394
I really thank @1ambda and your a kind explanation as well!
I'll update the following list and let you know that.
```
- comment 4 (SQL text font styling)
- comment 8
- comments 9-1, 9-2, 9-3
- comment 10
- comment 11
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---