You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/04/13 13:18:18 UTC
[GitHub] [arrow] andygrove opened a new pull request #10013: ARROW-12361: [Rust] [DataFusion] Allow users to override physical optimization rules
andygrove opened a new pull request #10013:
URL: https://github.com/apache/arrow/pull/10013
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] Dandandan commented on a change in pull request #10013: ARROW-12361: [Rust] [DataFusion] Allow users to override physical optimization rules
Posted by GitBox <gi...@apache.org>.
Dandandan commented on a change in pull request #10013:
URL: https://github.com/apache/arrow/pull/10013#discussion_r612451940
##########
File path: rust/datafusion/src/execution/context.rs
##########
@@ -680,6 +680,15 @@ impl ExecutionConfig {
self
}
+ /// Replace the physical optimizer rules
+ pub fn with_physical_optimizer_rules(
Review comment:
ah... makes sense :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10013: ARROW-12361: [Rust] [DataFusion] Allow users to override physical optimization rules
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10013:
URL: https://github.com/apache/arrow/pull/10013#issuecomment-818994331
https://issues.apache.org/jira/browse/ARROW-12361
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] Dandandan commented on a change in pull request #10013: ARROW-12361: [Rust] [DataFusion] Allow users to override physical optimization rules
Posted by GitBox <gi...@apache.org>.
Dandandan commented on a change in pull request #10013:
URL: https://github.com/apache/arrow/pull/10013#discussion_r612440254
##########
File path: rust/datafusion/src/execution/context.rs
##########
@@ -680,6 +680,15 @@ impl ExecutionConfig {
self
}
+ /// Replace the physical optimizer rules
+ pub fn with_physical_optimizer_rules(
Review comment:
There is also `add_physical_optimizer_rule` that I added -> don't we want to use that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb closed pull request #10013: ARROW-12361: [Rust] [DataFusion] Allow users to override physical optimization rules
Posted by GitBox <gi...@apache.org>.
alamb closed pull request #10013:
URL: https://github.com/apache/arrow/pull/10013
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] andygrove commented on pull request #10013: ARROW-12361: [Rust] [DataFusion] Allow users to override physical optimization rules
Posted by GitBox <gi...@apache.org>.
andygrove commented on pull request #10013:
URL: https://github.com/apache/arrow/pull/10013#issuecomment-818728829
@Dandandan @alamb @jorgecarleitao fyi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] andygrove commented on a change in pull request #10013: ARROW-12361: [Rust] [DataFusion] Allow users to override physical optimization rules
Posted by GitBox <gi...@apache.org>.
andygrove commented on a change in pull request #10013:
URL: https://github.com/apache/arrow/pull/10013#discussion_r612441792
##########
File path: rust/datafusion/src/execution/context.rs
##########
@@ -680,6 +680,15 @@ impl ExecutionConfig {
self
}
+ /// Replace the physical optimizer rules
+ pub fn with_physical_optimizer_rules(
Review comment:
That won't let me remove rules :wink:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] andygrove commented on a change in pull request #10013: ARROW-12361: [Rust] [DataFusion] Allow users to override physical optimization rules
Posted by GitBox <gi...@apache.org>.
andygrove commented on a change in pull request #10013:
URL: https://github.com/apache/arrow/pull/10013#discussion_r612442268
##########
File path: rust/datafusion/src/execution/context.rs
##########
@@ -680,6 +680,15 @@ impl ExecutionConfig {
self
}
+ /// Replace the physical optimizer rules
+ pub fn with_physical_optimizer_rules(
Review comment:
The specific use case this time is that I want to remove the repartition rule because Ballista does not support that yet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org