You are viewing a plain text version of this content. The canonical link for it is here.
Posted to watchdog-dev@jakarta.apache.org by Justyna Horwat <Ju...@eng.sun.com> on 2001/01/24 21:20:01 UTC

PATCH: watchdog-4.0 build and dist directories

I know some people may be using automated build and testing scripts so
I'm posting to the list first. I would like to create a separate
watchdog-4.0 build and dist directory.

It would be nice if I knew exactly which watchdog build I was using for
the appropriate version of tomcat.


Justy



Index: build.xml
===================================================================
RCS file: /home/cvs/jakarta-watchdog-4.0/build.xml,v
retrieving revision 1.7
diff -u -r1.7 build.xml
--- build.xml   2001/01/24 19:53:57     1.7
+++ build.xml   2001/01/24 20:14:21
@@ -3,8 +3,8 @@
    <!-- System property definitions -->
 
    <property name="build.compiler" value="classic"/>
-   <property name="watchdog.build" value="../build/watchdog"/>
-   <property name="watchdog.dist" value="../dist/watchdog"/>
+   <property name="watchdog.build" value="../build/watchdog-4.0"/>
+   <property name="watchdog.dist" value="../dist/watchdog-4.0"/>
    <property name="watchdog-classpath"
value="../jakarta-servletapi-4/lib/servlet.jar:./src/tools" />
 
    <!-- Prepare the unpacked destination directory -->

Re: PATCH: watchdog-4.0 build and dist directories

Posted by Justyna Horwat <Ju...@eng.sun.com>.
I was going with the status quo when suggesting the higher level build
and dist directories. 

I think that the build process would be more well behaved if the project
did not place files outside of its own directory. Doing this would solve
several issues including when you have a couple different versions of
the same workspace each wanting to place files in the identical
build/dist directory.

+1 on creating the build/dist directories inside the source workspace

Justy


"Craig R. McClanahan" wrote:
> 
> Justyna Horwat wrote:
> 
> > I know some people may be using automated build and testing scripts so
> > I'm posting to the list first. I would like to create a separate
> > watchdog-4.0 build and dist directory.
> >
> > It would be nice if I knew exactly which watchdog build I was using for
> > the appropriate version of tomcat.
> >
> 
> I agree with the desire.
> 
> As an alternative implementation approach, there seems to be a growing sentiment
> on several of the Jakarta projects to create the "build" and "dist" directories
> *inside* your source directory, rather than "up and over" the way we do it now.
> The change would be as follows:
> 
>     -   <property name="watchdog.build" value="../build/watchdog"/>
>     -   <property name="watchdog.dist" value="../dist/watchdog"/>
>     +   <property name="watchdog.build" value="build"/>
>     +   <property name="watchdog.dist" value="dist"/>
> 
> What do you think?
> 
> >
> > Justy
> >
> 
> Craig McClanahan
> 
> >
> > Index: build.xml
> > ===================================================================
> > RCS file: /home/cvs/jakarta-watchdog-4.0/build.xml,v
> > retrieving revision 1.7
> > diff -u -r1.7 build.xml
> > --- build.xml   2001/01/24 19:53:57     1.7
> > +++ build.xml   2001/01/24 20:14:21
> > @@ -3,8 +3,8 @@
> >     <!-- System property definitions -->
> >
> >     <property name="build.compiler" value="classic"/>
> > -   <property name="watchdog.build" value="../build/watchdog"/>
> > -   <property name="watchdog.dist" value="../dist/watchdog"/>
> > +   <property name="watchdog.build" value="../build/watchdog-4.0"/>
> > +   <property name="watchdog.dist" value="../dist/watchdog-4.0"/>
> >     <property name="watchdog-classpath"
> > value="../jakarta-servletapi-4/lib/servlet.jar:./src/tools" />
> >
> >     <!-- Prepare the unpacked destination directory -->

Re: PATCH: watchdog-4.0 build and dist directories

Posted by "Craig R. McClanahan" <Cr...@eng.sun.com>.
Justyna Horwat wrote:

> I know some people may be using automated build and testing scripts so
> I'm posting to the list first. I would like to create a separate
> watchdog-4.0 build and dist directory.
>
> It would be nice if I knew exactly which watchdog build I was using for
> the appropriate version of tomcat.
>

I agree with the desire.

As an alternative implementation approach, there seems to be a growing sentiment
on several of the Jakarta projects to create the "build" and "dist" directories
*inside* your source directory, rather than "up and over" the way we do it now.
The change would be as follows:

    -   <property name="watchdog.build" value="../build/watchdog"/>
    -   <property name="watchdog.dist" value="../dist/watchdog"/>
    +   <property name="watchdog.build" value="build"/>
    +   <property name="watchdog.dist" value="dist"/>

What do you think?

>
> Justy
>

Craig McClanahan



>
> Index: build.xml
> ===================================================================
> RCS file: /home/cvs/jakarta-watchdog-4.0/build.xml,v
> retrieving revision 1.7
> diff -u -r1.7 build.xml
> --- build.xml   2001/01/24 19:53:57     1.7
> +++ build.xml   2001/01/24 20:14:21
> @@ -3,8 +3,8 @@
>     <!-- System property definitions -->
>
>     <property name="build.compiler" value="classic"/>
> -   <property name="watchdog.build" value="../build/watchdog"/>
> -   <property name="watchdog.dist" value="../dist/watchdog"/>
> +   <property name="watchdog.build" value="../build/watchdog-4.0"/>
> +   <property name="watchdog.dist" value="../dist/watchdog-4.0"/>
>     <property name="watchdog-classpath"
> value="../jakarta-servletapi-4/lib/servlet.jar:./src/tools" />
>
>     <!-- Prepare the unpacked destination directory -->