You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2020/05/15 19:05:13 UTC
[kudu-CR] KUDU-2817: Upgrade glog to 0.4.0
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15924
Change subject: KUDU-2817: Upgrade glog to 0.4.0
......................................................................
KUDU-2817: Upgrade glog to 0.4.0
We are currently on glog 0.3.5 which is from 2017. We also have 4 patches
on top of that version in thirdparty.
This patch upgrades us to glog 0.4.0 which was released in 2019 and
removes 3/4 patches that are now included in the release.
I needed to adjust the remaining patch to apply and fix some usage of
the CHECK macros to wrap in parenthesis to prevent macro expansion
issues as well.
Change-Id: I652a852d040fcd3d974002382735610c8621c413
---
M src/kudu/fs/dir_util-test.cc
M src/kudu/util/logging.h
M src/kudu/util/rw_mutex-test.cc
M thirdparty/download-thirdparty.sh
D thirdparty/patches/glog-fix-symbolization.patch
D thirdparty/patches/glog-issue-198-fix-unused-warnings.patch
D thirdparty/patches/glog-issue-54-dont-build-tests.patch
M thirdparty/patches/glog-support-stacktrace-for-aarch64.patch
M thirdparty/vars.sh
9 files changed, 27 insertions(+), 442 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/24/15924/1
--
To view, visit http://gerrit.cloudera.org:8080/15924
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I652a852d040fcd3d974002382735610c8621c413
Gerrit-Change-Number: 15924
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] KUDU-2817: Upgrade glog to 0.4.0
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15924 )
Change subject: KUDU-2817: Upgrade glog to 0.4.0
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15924/1/src/kudu/util/logging.h
File src/kudu/util/logging.h:
http://gerrit.cloudera.org:8080/#/c/15924/1/src/kudu/util/logging.h@a229
PS1, Line 229:
:
:
> This was removed from glog all together: https://github.com/google/glog/com
Well, in this file at lines 253, 257, etc. this macro is still in use. Does it mean it's necessary to remove those usages as well?
Or I'm missing something?
--
To view, visit http://gerrit.cloudera.org:8080/15924
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I652a852d040fcd3d974002382735610c8621c413
Gerrit-Change-Number: 15924
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 15 May 2020 23:18:59 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2817: Upgrade glog to 0.4.0
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15924 )
Change subject: KUDU-2817: Upgrade glog to 0.4.0
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15924/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/15924/1//COMMIT_MSG@15
PS1, Line 15: I needed to adjust the remaining patch to apply and fix some usage of
: the CHECK macros to wrap in parenthesis to prevent macro expansion
: issues as well.
> Those come from gtest.
Yeah, if it's easy enough to patch gtest like we've done for other bug fixes then it'll prevent callers from running into the same issue. Non-blocking comment.
--
To view, visit http://gerrit.cloudera.org:8080/15924
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I652a852d040fcd3d974002382735610c8621c413
Gerrit-Change-Number: 15924
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 15 May 2020 19:43:58 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2817: Upgrade glog to 0.4.0
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15924 )
Change subject: KUDU-2817: Upgrade glog to 0.4.0
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15924
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I652a852d040fcd3d974002382735610c8621c413
Gerrit-Change-Number: 15924
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 19 May 2020 16:40:44 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2817: Upgrade glog to 0.4.0
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Bankim Bhavsar,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15924
to look at the new patch set (#3).
Change subject: KUDU-2817: Upgrade glog to 0.4.0
......................................................................
KUDU-2817: Upgrade glog to 0.4.0
We are currently on glog 0.3.5 which is from 2017. We also have 4 patches
on top of that version in thirdparty.
This patch upgrades us to glog 0.4.0 which was released in 2019 and
removes 3/4 patches that are now included in the release.
I needed to adjust the remaining patch to apply and fix some usage of
the CHECK macros to wrap in parenthesis to prevent macro expansion
issues as well.
I also adjusted the build scripts to use cmake instead of autoconf so
that I could disable building the tests.
Change-Id: I652a852d040fcd3d974002382735610c8621c413
---
M src/kudu/fs/dir_util-test.cc
M src/kudu/util/logging.h
M src/kudu/util/rw_mutex-test.cc
M thirdparty/build-definitions.sh
M thirdparty/download-thirdparty.sh
D thirdparty/patches/glog-fix-symbolization.patch
D thirdparty/patches/glog-issue-198-fix-unused-warnings.patch
D thirdparty/patches/glog-issue-54-dont-build-tests.patch
M thirdparty/patches/glog-support-stacktrace-for-aarch64.patch
M thirdparty/vars.sh
10 files changed, 43 insertions(+), 455 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/24/15924/3
--
To view, visit http://gerrit.cloudera.org:8080/15924
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I652a852d040fcd3d974002382735610c8621c413
Gerrit-Change-Number: 15924
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-2817: Upgrade glog to 0.4.0
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15924 )
Change subject: KUDU-2817: Upgrade glog to 0.4.0
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15924/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/15924/1//COMMIT_MSG@15
PS1, Line 15: I needed to adjust the remaining patch to apply and fix some usage of
: the CHECK macros to wrap in parenthesis to prevent macro expansion
: issues as well.
> Fair enough. Would you be interested in doing that in a follow on change? I
I can take a shot and see what's involved.
--
To view, visit http://gerrit.cloudera.org:8080/15924
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I652a852d040fcd3d974002382735610c8621c413
Gerrit-Change-Number: 15924
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 15 May 2020 21:27:36 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2817: Upgrade glog to 0.4.0
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15924 )
Change subject: KUDU-2817: Upgrade glog to 0.4.0
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15924/1/src/kudu/util/logging.h
File src/kudu/util/logging.h:
http://gerrit.cloudera.org:8080/#/c/15924/1/src/kudu/util/logging.h@a229
PS1, Line 229:
:
:
> Well, in this file at lines 253, 257, etc. this macro is still in use. Doe
Good catch. I replaced those with `static_assert`.
--
To view, visit http://gerrit.cloudera.org:8080/15924
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I652a852d040fcd3d974002382735610c8621c413
Gerrit-Change-Number: 15924
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 19 May 2020 15:20:03 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2817: Upgrade glog to 0.4.0
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Bankim Bhavsar,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15924
to look at the new patch set (#2).
Change subject: KUDU-2817: Upgrade glog to 0.4.0
......................................................................
KUDU-2817: Upgrade glog to 0.4.0
We are currently on glog 0.3.5 which is from 2017. We also have 4 patches
on top of that version in thirdparty.
This patch upgrades us to glog 0.4.0 which was released in 2019 and
removes 3/4 patches that are now included in the release.
I needed to adjust the remaining patch to apply and fix some usage of
the CHECK macros to wrap in parenthesis to prevent macro expansion
issues as well.
Change-Id: I652a852d040fcd3d974002382735610c8621c413
---
M src/kudu/fs/dir_util-test.cc
M src/kudu/util/logging.h
M src/kudu/util/rw_mutex-test.cc
M thirdparty/download-thirdparty.sh
D thirdparty/patches/glog-fix-symbolization.patch
D thirdparty/patches/glog-issue-198-fix-unused-warnings.patch
D thirdparty/patches/glog-issue-54-dont-build-tests.patch
M thirdparty/patches/glog-support-stacktrace-for-aarch64.patch
M thirdparty/vars.sh
9 files changed, 32 insertions(+), 447 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/24/15924/2
--
To view, visit http://gerrit.cloudera.org:8080/15924
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I652a852d040fcd3d974002382735610c8621c413
Gerrit-Change-Number: 15924
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-2817: Upgrade glog to 0.4.0
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15924 )
Change subject: KUDU-2817: Upgrade glog to 0.4.0
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15924
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I652a852d040fcd3d974002382735610c8621c413
Gerrit-Change-Number: 15924
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 20 May 2020 15:08:21 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2817: Upgrade glog to 0.4.0
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15924 )
Change subject: KUDU-2817: Upgrade glog to 0.4.0
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15924/1/src/kudu/util/logging.h
File src/kudu/util/logging.h:
http://gerrit.cloudera.org:8080/#/c/15924/1/src/kudu/util/logging.h@a229
PS1, Line 229:
:
:
> Just curious: why it was necessary to remove this? The issue with wrong se
I think because C++11 introduced static_assert and there aren't any callers of this macro.
--
To view, visit http://gerrit.cloudera.org:8080/15924
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I652a852d040fcd3d974002382735610c8621c413
Gerrit-Change-Number: 15924
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 15 May 2020 19:25:01 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2817: Upgrade glog to 0.4.0
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15924 )
Change subject: KUDU-2817: Upgrade glog to 0.4.0
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15924/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/15924/1//COMMIT_MSG@15
PS1, Line 15: I needed to adjust the remaining patch to apply and fix some usage of
: the CHECK macros to wrap in parenthesis to prevent macro expansion
: issues as well.
Is it possible to change the callee EXPECT_DEATH/ASSERT_DEATH to instead wrap the statement in parenthesis?
--
To view, visit http://gerrit.cloudera.org:8080/15924
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I652a852d040fcd3d974002382735610c8621c413
Gerrit-Change-Number: 15924
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 15 May 2020 19:23:58 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2817: Upgrade glog to 0.4.0
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15924 )
Change subject: KUDU-2817: Upgrade glog to 0.4.0
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15924/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/15924/1//COMMIT_MSG@15
PS1, Line 15: I needed to adjust the remaining patch to apply and fix some usage of
: the CHECK macros to wrap in parenthesis to prevent macro expansion
: issues as well.
> Is it possible to change the callee EXPECT_DEATH/ASSERT_DEATH to instead wr
Those come from gtest.
--
To view, visit http://gerrit.cloudera.org:8080/15924
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I652a852d040fcd3d974002382735610c8621c413
Gerrit-Change-Number: 15924
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 15 May 2020 19:27:33 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2817: Upgrade glog to 0.4.0
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15924 )
Change subject: KUDU-2817: Upgrade glog to 0.4.0
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15924
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I652a852d040fcd3d974002382735610c8621c413
Gerrit-Change-Number: 15924
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 15 May 2020 21:31:30 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2817: Upgrade glog to 0.4.0
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15924 )
Change subject: KUDU-2817: Upgrade glog to 0.4.0
......................................................................
KUDU-2817: Upgrade glog to 0.4.0
We are currently on glog 0.3.5 which is from 2017. We also have 4 patches
on top of that version in thirdparty.
This patch upgrades us to glog 0.4.0 which was released in 2019 and
removes 3/4 patches that are now included in the release.
I needed to adjust the remaining patch to apply and fix some usage of
the CHECK macros to wrap in parenthesis to prevent macro expansion
issues as well.
I also adjusted the build scripts to use cmake instead of autoconf so
that I could disable building the tests.
Change-Id: I652a852d040fcd3d974002382735610c8621c413
Reviewed-on: http://gerrit.cloudera.org:8080/15924
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/fs/dir_util-test.cc
M src/kudu/util/logging.h
M src/kudu/util/rw_mutex-test.cc
M thirdparty/build-definitions.sh
M thirdparty/download-thirdparty.sh
D thirdparty/patches/glog-fix-symbolization.patch
D thirdparty/patches/glog-issue-198-fix-unused-warnings.patch
D thirdparty/patches/glog-issue-54-dont-build-tests.patch
M thirdparty/patches/glog-support-stacktrace-for-aarch64.patch
M thirdparty/vars.sh
10 files changed, 43 insertions(+), 455 deletions(-)
Approvals:
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/15924
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I652a852d040fcd3d974002382735610c8621c413
Gerrit-Change-Number: 15924
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-2817: Upgrade glog to 0.4.0
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15924 )
Change subject: KUDU-2817: Upgrade glog to 0.4.0
......................................................................
Patch Set 2:
I am looking into this TSAN failure.
--
To view, visit http://gerrit.cloudera.org:8080/15924
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I652a852d040fcd3d974002382735610c8621c413
Gerrit-Change-Number: 15924
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 19 May 2020 16:42:54 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2817: Upgrade glog to 0.4.0
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15924 )
Change subject: KUDU-2817: Upgrade glog to 0.4.0
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15924/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/15924/1//COMMIT_MSG@15
PS1, Line 15: I needed to adjust the remaining patch to apply and fix some usage of
: the CHECK macros to wrap in parenthesis to prevent macro expansion
: issues as well.
> Yeah, if it's easy enough to patch gtest like we've done for other bug fixe
Fair enough. Would you be interested in doing that in a follow on change? I can take a look at some point too. Ideally we would then contribute the patch to glog itself.
--
To view, visit http://gerrit.cloudera.org:8080/15924
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I652a852d040fcd3d974002382735610c8621c413
Gerrit-Change-Number: 15924
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 15 May 2020 19:45:37 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2817: Upgrade glog to 0.4.0
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15924 )
Change subject: KUDU-2817: Upgrade glog to 0.4.0
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15924/1/src/kudu/util/logging.h
File src/kudu/util/logging.h:
http://gerrit.cloudera.org:8080/#/c/15924/1/src/kudu/util/logging.h@a229
PS1, Line 229:
:
:
Just curious: why it was necessary to remove this? The issue with wrong severity is addressed somewhere else?
--
To view, visit http://gerrit.cloudera.org:8080/15924
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I652a852d040fcd3d974002382735610c8621c413
Gerrit-Change-Number: 15924
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 15 May 2020 19:21:04 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2817: Upgrade glog to 0.4.0
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15924 )
Change subject: KUDU-2817: Upgrade glog to 0.4.0
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15924/1/src/kudu/util/logging.h
File src/kudu/util/logging.h:
http://gerrit.cloudera.org:8080/#/c/15924/1/src/kudu/util/logging.h@a229
PS1, Line 229:
:
:
> Just curious: why it was necessary to remove this? The issue with wrong se
This was removed from glog all together: https://github.com/google/glog/commit/dd19fb2466fb5c90369eb1387a9ba0689e7d0387
And the usage was removed in the LOG_EVERY_N implementation (Which this KLOG_EVERY_N copies). That commit explains why it is safe:
https://github.com/google/glog/commit/8b3023f7e4ca46e0ecf5f660dd7340c79139bc34#diff-c6aaa6ad4cf2cf8741c91a15c62907ca
--
To view, visit http://gerrit.cloudera.org:8080/15924
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I652a852d040fcd3d974002382735610c8621c413
Gerrit-Change-Number: 15924
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 15 May 2020 19:26:10 +0000
Gerrit-HasComments: Yes