You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/11/17 16:17:43 UTC
[GitHub] [tvm] joshherr-quic opened a new pull request, #13418: [Hexagon][CI] Updated sha for builder LLVM
joshherr-quic opened a new pull request, #13418:
URL: https://github.com/apache/tvm/pull/13418
Updated sha to deal with some codegen issues that came up with the last version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] joshherr-quic commented on pull request #13418: [Hexagon][CI] Updated sha for builder LLVM
Posted by GitBox <gi...@apache.org>.
joshherr-quic commented on PR #13418:
URL: https://github.com/apache/tvm/pull/13418#issuecomment-1320361119
I'm not seeing any codegen errors, but I am seeing a lot of errors
> Hi, @mehrdadh and @joshherr-quic ! Sorry for stupid question, but when I try to use Hexagon docker I run the following command: `./docker/bash.sh ci_hexagon` But as I see from the downloaded image it still uses LLVM-14:
>
> ```
> $ /opt/clang-llvm/bin/llvm-config --version
> 14.0.0
> ```
>
> But even LLVM_SHA=361a27c155ec8b should correspond to LLVM-15.x if I am correct.
>
> What should I do to use up-to-date LLVM version in the docker image? Build the docker locally?
The docker image you download is built according to the tvm commit that corresponds to [this](https://github.com/apache/tvm/blob/main/Jenkinsfile#L60) commit id. That commit still has llvm 14. The PR that we're looking at merely updates the docker image that would get built for **this** commit. We still need to open another PR to update the commit id in the [Jenkinsfile](https://github.com/apache/tvm/blob/main/Jenkinsfile#L60) so that CI will build the new LLVM version. Only after that follow-up commit will the updated docker with the newer llvm be available.
So your intuition is correct! You would need to build the docker locally to take advantage of the newest LLVM right now. New dockers with new llvm should hopefully be available over the weekend for download.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mehrdadh commented on pull request #13418: [Hexagon][CI] Updated sha for builder LLVM
Posted by GitBox <gi...@apache.org>.
mehrdadh commented on PR #13418:
URL: https://github.com/apache/tvm/pull/13418#issuecomment-1318955327
@joshherr-quic thanks for the PR! Could you please build the docker locally and run hexagon tests with the simulator?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mehrdadh commented on pull request #13418: [Hexagon][CI] Updated sha for builder LLVM
Posted by GitBox <gi...@apache.org>.
mehrdadh commented on PR #13418:
URL: https://github.com/apache/tvm/pull/13418#issuecomment-1324126343
@joshherr-quic where do you see those errors? can you post them here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mehrdadh commented on pull request #13418: [Hexagon][CI] Updated sha for builder LLVM
Posted by GitBox <gi...@apache.org>.
mehrdadh commented on PR #13418:
URL: https://github.com/apache/tvm/pull/13418#issuecomment-1397526323
cc @kparzysz-quic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] ibsidorenko commented on pull request #13418: [Hexagon][CI] Updated sha for builder LLVM
Posted by GitBox <gi...@apache.org>.
ibsidorenko commented on PR #13418:
URL: https://github.com/apache/tvm/pull/13418#issuecomment-1319691935
Hi, @mehrdadh and @joshherr-quic !
Sorry for stupid question, but when I try to use Hexagon docker I run the following command:
`./docker/bash.sh ci_hexagon`
But as I see from the downloaded image it still uses LLVM-14:
```
$ /opt/clang-llvm/bin/llvm-config --version
14.0.0
```
But even LLVM_SHA=361a27c155ec8b should correspond to LLVM-15.x if I am correct.
What should I do to use up-to-date LLVM version in the docker image? Build the docker locally?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mehrdadh merged pull request #13418: [Hexagon][CI] Updated sha for builder LLVM
Posted by "mehrdadh (via GitHub)" <gi...@apache.org>.
mehrdadh merged PR #13418:
URL: https://github.com/apache/tvm/pull/13418
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] joshherr-quic commented on pull request #13418: [Hexagon][CI] Updated sha for builder LLVM
Posted by GitBox <gi...@apache.org>.
joshherr-quic commented on PR #13418:
URL: https://github.com/apache/tvm/pull/13418#issuecomment-1318958847
> @joshherr-quic thanks for the PR! Could you please build the docker locally and run hexagon tests with the simulator?
Will do. Is there a wiki with some quick instructions on how to do this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] kparzysz-quic commented on pull request #13418: [Hexagon][CI] Updated sha for builder LLVM
Posted by "kparzysz-quic (via GitHub)" <gi...@apache.org>.
kparzysz-quic commented on PR #13418:
URL: https://github.com/apache/tvm/pull/13418#issuecomment-1406940470
The CI tests have passed with docker image built from this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mehrdadh commented on pull request #13418: [Hexagon][CI] Updated sha for builder LLVM
Posted by GitBox <gi...@apache.org>.
mehrdadh commented on PR #13418:
URL: https://github.com/apache/tvm/pull/13418#issuecomment-1320392503
@ibsidorenko so after @joshherr-quic confirms the tests are passing, we will merge this PR and update the docker image. In the meantime if you need to use docker with updated LLVM, you need to build it locally. We also have automated nightly image build which is published here: https://hub.docker.com/r/tlcpackstaging/ci_hexagon/tags
These images are not necessarily usable because some of them are failing on some tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] joshherr-quic commented on pull request #13418: [Hexagon][CI] Updated sha for builder LLVM
Posted by GitBox <gi...@apache.org>.
joshherr-quic commented on PR #13418:
URL: https://github.com/apache/tvm/pull/13418#issuecomment-1320480081
I'm seeing a lot of "AttributeError: 'HexagonLauncherSimulator' object has no attribute '_se" errors, but nothing related to codegen...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tvm-bot commented on pull request #13418: [Hexagon][CI] Updated sha for builder LLVM
Posted by GitBox <gi...@apache.org>.
tvm-bot commented on PR #13418:
URL: https://github.com/apache/tvm/pull/13418#issuecomment-1318876934
<!---bot-comment-->
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
<!--bot-comment-ccs-start-->
* cc @Icemist, @Mousius, @areusch, @driazati, @gigiblender, @mehrdadh <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
<sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mehrdadh commented on pull request #13418: [Hexagon][CI] Updated sha for builder LLVM
Posted by GitBox <gi...@apache.org>.
mehrdadh commented on PR #13418:
URL: https://github.com/apache/tvm/pull/13418#issuecomment-1397526004
@joshherr-quic any update on this?
Unfortunately This is blocking updating hexagon image. I appreciate if you could provide a follow up on this. thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org