You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "hhhonzik (via GitHub)" <gi...@apache.org> on 2023/08/14 06:54:01 UTC
[GitHub] [superset] hhhonzik opened a new pull request, #24971: feat(docker): Add ARM builds
hhhonzik opened a new pull request, #24971:
URL: https://github.com/apache/superset/pull/24971
### SUMMARY
This adds an ARM build to the superset. This is a naive implementation with buildx and QEMU. I'll be parallelizing these builds before this can get merged (now it takes like 1+ hours to compile)
Notably i've changed:
- build docker images with buildx
- [Firefox installation](https://github.com/seleniumhq-community/docker-seleniarm/blob/trunk/NodeFirefox/Dockerfile.multi-arch) is taken from great selenium-arm image.
TODO:
- [ ] Run builds in parallel and merge manifests at the end
- [ ] Sync firefox to the same version as current image
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
I've enabled Github Actions on my fork, so you can see the result:
- http://hub.docker.com/r/hhhonzik/superset
- Action detail: https://github.com/hhhonzik/superset/actions/runs/5849184577
### ADDITIONAL INFORMATION
- [x] Has associated issue: https://github.com/amancevice/docker-superset/issues/175
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(docker): Add ARM builds [superset]
Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch closed pull request #24971: feat(docker): Add ARM builds
URL: https://github.com/apache/superset/pull/24971
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(docker): Add ARM builds [superset]
Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch commented on PR #24971:
URL: https://github.com/apache/superset/pull/24971#issuecomment-2015499428
Yup this has been tackled, closing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(docker): Add ARM builds [superset]
Posted by "EugeneTorap (via GitHub)" <gi...@apache.org>.
EugeneTorap commented on PR #24971:
URL: https://github.com/apache/superset/pull/24971#issuecomment-2014825666
superseded by #25377
@dpgaspar @rusackas close this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org