[GitHub] [iceberg] stevenzwu edited a comment on pull request #2109: Flink: store watermark as iceberg table's property

[GitBox <gi...@apache.org>]

stevenzwu edited a comment on pull request #2109:
URL: https://github.com/apache/iceberg/pull/2109#issuecomment-763299851


   @dixingxing0 thx a lot for the additional context. that is very helpful. I left a few comments.
   
   Regarding the scenario of multiple writer jobs and single table, I am afraid that the additional config won't help because we are talking one table here.
   
   Somehow, we need to allow a provider to provide the suffix for watermark property key. For us, the suffix is the AWS region. I am not sure what is the cleanest way to achieve that. We can define a provider class config and use reflection to instantiate it. I am hesitant with reflection as it is impossible to pass dependency to reflection instantiated class.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org