[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5748: Prevent null values on Vmware appliances details that are missing a default value

[GitBox <gi...@apache.org>]

DaanHoogland commented on a change in pull request #5748:
URL: https://github.com/apache/cloudstack/pull/5748#discussion_r762930018



##########
File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -4399,6 +4399,8 @@ private void persistVMDeployAsIsProperties(UserVmVO vm, Map<String, String> user
                             value = DBEncryptionUtil.encrypt(value);
                         }
                     }
+                } else if (value == null) {
+                    value = "";

Review comment:
       @nvazquez does this require special handling in the vmware resource/- guru? I mean to make sure vmware get the right type of value.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org