You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/04/27 05:22:04 UTC
[jira] [Commented] (BEAM-1763) TestPipeline should ensure that all
assertions succeeded
[ https://issues.apache.org/jira/browse/BEAM-1763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15986036#comment-15986036 ]
ASF GitHub Bot commented on BEAM-1763:
--------------------------------------
GitHub user aviemzur opened a pull request:
https://github.com/apache/beam/pull/2729
[BEAM-1763] Verify PAssert execution in runners which support metrics.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aviemzur/beam testpipeline-passert-verification
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2729.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2729
----
commit 6ca854c9cbe3e8239945dcb1b277d89fadf5dfdd
Author: Aviem Zur <av...@gmail.com>
Date: 2017-04-27T05:19:06Z
[BEAM-1763] Verify PAssert execution in runners which support metrics.
----
> TestPipeline should ensure that all assertions succeeded
> --------------------------------------------------------
>
> Key: BEAM-1763
> URL: https://issues.apache.org/jira/browse/BEAM-1763
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-java-core
> Reporter: Thomas Groh
> Assignee: Aviem Zur
>
> This doesn't need to be part of each {{PipelineRunner}} implementation if it goes through the {{PipelineResult}} APIs. The assertion can be of the form that if the Pipeline is finished, then the number of successful assertions is equal to the total number of assertions.
> Suggested solution:
> For runners which support metrics, use the counters for successful/failed assertions and compare them to expected number of assertions.
> Runners which do not support metrics should either implement metrics or override {{PAssert}} in a way that verifies its execution.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)