You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@sling.apache.org by fm...@apache.org on 2010/09/23 15:46:16 UTC

svn commit: r1000472 - /sling/trunk/bundles/auth/core/src/main/java/org/apache/sling/auth/core/impl/SlingAuthenticator.java

Author: fmeschbe
Date: Thu Sep 23 13:46:15 2010
New Revision: 1000472

URL: http://svn.apache.org/viewvc?rev=1000472&view=rev
Log:
SLING-1428 Don't "handle" login failure if the AuthenticationFeedbackHandler already committed a response.

Modified:
    sling/trunk/bundles/auth/core/src/main/java/org/apache/sling/auth/core/impl/SlingAuthenticator.java

Modified: sling/trunk/bundles/auth/core/src/main/java/org/apache/sling/auth/core/impl/SlingAuthenticator.java
URL: http://svn.apache.org/viewvc/sling/trunk/bundles/auth/core/src/main/java/org/apache/sling/auth/core/impl/SlingAuthenticator.java?rev=1000472&r1=1000471&r2=1000472&view=diff
==============================================================================
--- sling/trunk/bundles/auth/core/src/main/java/org/apache/sling/auth/core/impl/SlingAuthenticator.java (original)
+++ sling/trunk/bundles/auth/core/src/main/java/org/apache/sling/auth/core/impl/SlingAuthenticator.java Thu Sep 23 13:46:15 2010
@@ -709,8 +709,11 @@ public class SlingAuthenticator implemen
                     authInfo);
             }
 
-            // now find a way to get credentials
-            handleLoginFailure(request, response, authInfo.getUser(), re);
+            // now find a way to get credentials unless the feedback handler
+            // has committed a response to the client already
+            if (!response.isCommitted()) {
+                handleLoginFailure(request, response, authInfo.getUser(), re);
+            }
 
         }