You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/09/06 15:29:32 UTC

[GitHub] [pulsar] tomscut opened a new pull request #11935: Update the default log pattern

tomscut opened a new pull request #11935:
URL: https://github.com/apache/pulsar/pull/11935


   
   Master Issue: [#8298](https://github.com/apache/pulsar/issues/8298)
   
   ### Motivation
   
   To make it easy to track problems and resolve them, we should add date for the logs by default.
   
   ### Modifications
   
   Updated the default logs pattern, added date.
   
   ### Verifying this change
   
   No tests involved.
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (yes / no)
     - The public API: (no)
     - The schema: (no)
     - The default values of configurations: (no)
     - The wire protocol: (no)
     - The rest endpoints: (no)
     - The admin cli options: (no)
     - Anything that affects deployment: (no)
   
   ### Documentation
   
   - [ ] doc-required 
   - [x] no-need-doc 
   - [ ] doc 
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tomscut commented on pull request #11935: Update the default log pattern

Posted by GitBox <gi...@apache.org>.
tomscut commented on pull request #11935:
URL: https://github.com/apache/pulsar/pull/11935#issuecomment-914258022


   > lgtm.
   
   Thanks for you quick reply.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] hangc0276 merged pull request #11935: Update the default log pattern

Posted by GitBox <gi...@apache.org>.
hangc0276 merged pull request #11935:
URL: https://github.com/apache/pulsar/pull/11935


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tomscut commented on pull request #11935: Update the default log pattern

Posted by GitBox <gi...@apache.org>.
tomscut commented on pull request #11935:
URL: https://github.com/apache/pulsar/pull/11935#issuecomment-914058272


   > Overall I agree with this change.
   > But we should discuss about this on [dev@pulsar.apache.org](mailto:dev@pulsar.apache.org)
   > 
   > there are many systems that parse logs and if we change the pattern we are going to break things.
   > So the community must be informed and agree on this change.
   > 
   > I am setting "Request changes" only because I would like to see that we all agree
   
   Thank you for your suggestion and careful consideration. I will initiate a discussion on dev@pulsar.apache.org.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tomscut commented on pull request #11935: Update the default log pattern

Posted by GitBox <gi...@apache.org>.
tomscut commented on pull request #11935:
URL: https://github.com/apache/pulsar/pull/11935#issuecomment-914257153


   > Please include the timezone also.
   > 
   > Rather than a custom format, you can use the log4j2 builtin format.
   > %d{ISO8601_OFFSET_DATE_TIME_HHMM}
   
   I added timezone and replaced custom format with ISO8601_OFFSET_DATE_TIME_HHMM. Could please take a look? Thanks a lot.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tomscut commented on pull request #11935: Update the default log pattern

Posted by GitBox <gi...@apache.org>.
tomscut commented on pull request #11935:
URL: https://github.com/apache/pulsar/pull/11935#issuecomment-915762938


   > Hi @merlimat @Licht-T , could you please look at this problem `CPP, Python Tests failed`. I'm not sure if the failed test is related to this change and how to fix it. Thanks a lot.
   
   I found the problem caused by this code format and it has been fixed. All checks have passed now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tomscut edited a comment on pull request #11935: Update the default log pattern

Posted by GitBox <gi...@apache.org>.
tomscut edited a comment on pull request #11935:
URL: https://github.com/apache/pulsar/pull/11935#issuecomment-915762938


   > Hi @merlimat @Licht-T , could you please look at this problem `CPP, Python Tests failed`. I'm not sure if the failed test is related to this change and how to fix it. Thanks a lot.
   
   I found the problem caused by code format and it has been fixed. All checks have passed now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tomscut commented on pull request #11935: Update the default log pattern

Posted by GitBox <gi...@apache.org>.
tomscut commented on pull request #11935:
URL: https://github.com/apache/pulsar/pull/11935#issuecomment-915130628


   > LGTM
   > 
   > I have dropped the '2.8.2' label because this is an important change and we cannot do it in a point release
   
   Thanks @eolivelli for your review. 
   
   I found that ```CPP, Python Tests``` failed, but I did not see the correlation with this change. Could you please help confirm this problem? I'm worried about introducing some problems.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tomscut commented on pull request #11935: Update the default log pattern

Posted by GitBox <gi...@apache.org>.
tomscut commented on pull request #11935:
URL: https://github.com/apache/pulsar/pull/11935#issuecomment-915320254


   Hi @merlimat @Licht-T , could you please look at this problem ```CPP, Python Tests failed```. I'm not sure if the failed test is related to this change and how to fix it. Thanks a lot.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tomscut commented on pull request #11935: Update the default log pattern

Posted by GitBox <gi...@apache.org>.
tomscut commented on pull request #11935:
URL: https://github.com/apache/pulsar/pull/11935#issuecomment-913908919


   Thanks @codelipenghui for your review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tomscut commented on pull request #11935: Update the default log pattern

Posted by GitBox <gi...@apache.org>.
tomscut commented on pull request #11935:
URL: https://github.com/apache/pulsar/pull/11935#issuecomment-914217530


   > Please include the timezone also.
   > 
   > Rather than a custom format, you can use the log4j2 builtin format.
   > %d{ISO8601_OFFSET_DATE_TIME_HHMM}
   
   Thanks @ivankelly for your review and suggestion. I'm in favor of adding timezone and I will make some change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tomscut commented on pull request #11935: Update the default log pattern

Posted by GitBox <gi...@apache.org>.
tomscut commented on pull request #11935:
URL: https://github.com/apache/pulsar/pull/11935#issuecomment-915079145


   Hi @sijie @merlimat , could you please review this change? Thanks a lot.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tomscut commented on pull request #11935: Update the default log pattern

Posted by GitBox <gi...@apache.org>.
tomscut commented on pull request #11935:
URL: https://github.com/apache/pulsar/pull/11935#issuecomment-913907631


   Hi @sijie @hangc0276 @codelipenghui , could you please review the code and approve running workflows? Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org