You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by hsaputra <gi...@git.apache.org> on 2014/10/22 22:51:03 UTC
[GitHub] incubator-flink pull request: Remove unnecessary final modifier in...
GitHub user hsaputra opened a pull request:
https://github.com/apache/incubator-flink/pull/163
Remove unnecessary final modifier in PlanExecutor.loadExecutorClass method
Remove unnecessary final modifier in PlanExecutor.loadExecutorClass private static method because private means you can not override this method.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hsaputra/incubator-flink remove_unneeded_final_privatetatsic_planexecutor
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-flink/pull/163.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #163
----
commit fe7afc77cc083e0add51af4b2cbc24f763a11e45
Author: Henry Saputra <he...@gmail.com>
Date: 2014-10-22T20:49:45Z
Remove unnecessary final modifier in PlanExecutor's private static method.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: Remove unnecessary final modifier in...
Posted by hsaputra <gi...@git.apache.org>.
Github user hsaputra commented on the pull request:
https://github.com/apache/incubator-flink/pull/163#issuecomment-60627135
Thx, will merge sometimes today
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: Remove unnecessary final modifier in...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/incubator-flink/pull/163#issuecomment-60595788
Looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: Remove unnecessary final modifier in...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-flink/pull/163
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---