You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/11/24 09:17:29 UTC
[GitHub] [hive] abstractdog opened a new pull request #2812: HIVE-25666: Adopt the changes of TEZ-4339: monitor memory usage and handle proper container memory calculation for LLAP
abstractdog opened a new pull request #2812:
URL: https://github.com/apache/hive/pull/2812
Change-Id: Id0ae793291420b8b32896aabc9e1a8c1dce1623e
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] github-actions[bot] closed pull request #2812: HIVE-25666: Realtime memory usage in beeline progress
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #2812:
URL: https://github.com/apache/hive/pull/2812
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] github-actions[bot] commented on pull request #2812: HIVE-25666: Realtime memory usage in beeline progress
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #2812:
URL: https://github.com/apache/hive/pull/2812#issuecomment-1027414770
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Feel free to reach out on the dev@hive.apache.org list if the patch is in need of reviews.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pgaref commented on a change in pull request #2812: HIVE-25666: Realtime memory usage in beeline progress
Posted by GitBox <gi...@apache.org>.
pgaref commented on a change in pull request #2812:
URL: https://github.com/apache/hive/pull/2812#discussion_r756555296
##########
File path: llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskCommunicator.java
##########
@@ -1163,4 +1165,15 @@ private QueryIdentifierProto constructQueryIdentifierProto(int dagIdentifier) {
public String getAmHostString() {
return amHost;
}
+
+ /**
+ * Overrides TezTaskCommunicatorImpl.getTotalUsedMemory in order to provide correct aggregated memory usage.
+ * In LLAP, every container reports the whole used heap of the daemon they're running in, so we need to consider
+ * every usedMemory once per daemon.
+ * @return
+ */
+ @Override
+ public long getTotalUsedMemory() {
+ return pingedNodeMap.values().stream().mapToLong(c -> c.usedMemory).sum();
Review comment:
i.e., could print something like: Avg usage percent: 50%. 80th percentile: 80%, 90th percentile: 99%
##########
File path: llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskCommunicator.java
##########
@@ -1163,4 +1165,15 @@ private QueryIdentifierProto constructQueryIdentifierProto(int dagIdentifier) {
public String getAmHostString() {
return amHost;
}
+
+ /**
+ * Overrides TezTaskCommunicatorImpl.getTotalUsedMemory in order to provide correct aggregated memory usage.
+ * In LLAP, every container reports the whole used heap of the daemon they're running in, so we need to consider
+ * every usedMemory once per daemon.
+ * @return
+ */
+ @Override
+ public long getTotalUsedMemory() {
+ return pingedNodeMap.values().stream().mapToLong(c -> c.usedMemory).sum();
Review comment:
Sum does not provide much value here. Maybe we could print it as an average percentage across daemons, but having some kind of percentile here could actually reveal if some daemons face more pressure than others
##########
File path: llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/AMReporter.java
##########
@@ -431,6 +437,15 @@ protected Void callInternal() {
return null;
}
+
+ private long getUsedMemory() {
Review comment:
Cool stuff, would it make more sense to present it as used percentage? We could even print both values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] abstractdog commented on a change in pull request #2812: HIVE-25666: Realtime memory usage in beeline progress
Posted by GitBox <gi...@apache.org>.
abstractdog commented on a change in pull request #2812:
URL: https://github.com/apache/hive/pull/2812#discussion_r758468637
##########
File path: llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskCommunicator.java
##########
@@ -1163,4 +1165,15 @@ private QueryIdentifierProto constructQueryIdentifierProto(int dagIdentifier) {
public String getAmHostString() {
return amHost;
}
+
+ /**
+ * Overrides TezTaskCommunicatorImpl.getTotalUsedMemory in order to provide correct aggregated memory usage.
+ * In LLAP, every container reports the whole used heap of the daemon they're running in, so we need to consider
+ * every usedMemory once per daemon.
+ * @return
+ */
+ @Override
+ public long getTotalUsedMemory() {
+ return pingedNodeMap.values().stream().mapToLong(c -> c.usedMemory).sum();
Review comment:
thanks for the comments @pgaref
```
Sum does not provide much value here
```
I see, the sum is just one information (we need at least the number of daemons additionally to make it have a meaning), but the percentage looks more useful
I was already thinking about percentage, what should be the value of 100%? I mean, usedMemory is heap usage in daemons, what do you think we should consider as the "whole" memory?
I found adjustedExecutorMemory which would make sense:
https://github.com/apache/hive/blob/1046f41ea36ab3c8b036481128ba9b76dda2882a/llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapDaemon.java#L227
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] abstractdog commented on a change in pull request #2812: HIVE-25666: Realtime memory usage in beeline progress
Posted by GitBox <gi...@apache.org>.
abstractdog commented on a change in pull request #2812:
URL: https://github.com/apache/hive/pull/2812#discussion_r761878622
##########
File path: llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskCommunicator.java
##########
@@ -1163,4 +1165,15 @@ private QueryIdentifierProto constructQueryIdentifierProto(int dagIdentifier) {
public String getAmHostString() {
return amHost;
}
+
+ /**
+ * Overrides TezTaskCommunicatorImpl.getTotalUsedMemory in order to provide correct aggregated memory usage.
+ * In LLAP, every container reports the whole used heap of the daemon they're running in, so we need to consider
+ * every usedMemory once per daemon.
+ * @return
+ */
+ @Override
+ public long getTotalUsedMemory() {
+ return pingedNodeMap.values().stream().mapToLong(c -> c.usedMemory).sum();
Review comment:
also, I need to plan this consciously, because every change needs to flow through tez DagClient API, which is protobuf based and doesn't support map<> with the current protobuf version, so I need to find out another way to propagate arbitrary memory-related data
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org