[GitHub] [superset] kgabryje commented on a change in pull request #16958: fix(build): make npm linking work pt. 2

[GitBox <gi...@apache.org>]

kgabryje commented on a change in pull request #16958:
URL: https://github.com/apache/superset/pull/16958#discussion_r721494332



##########
File path: superset-frontend/webpack.config.js
##########
@@ -289,9 +289,10 @@ const config = {
         APP_DIR,
         './node_modules/@superset-ui/chart-controls',
       ),
+      react: path.resolve('./node_modules/react'),

Review comment:
       Perhaps we should have react as peer dep in superset-ui then?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org