You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by vkorukanti <gi...@git.apache.org> on 2016/02/24 23:52:57 UTC
[GitHub] drill pull request: DRILL-4434: Deprecate GroupScan.enforceWidth A...
GitHub user vkorukanti opened a pull request:
https://github.com/apache/drill/pull/390
DRILL-4434: Deprecate GroupScan.enforceWidth API
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vkorukanti/drill DRILL-4434
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/390.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #390
----
commit 3e55fe1db23e51e39043e3f366b6d1c6bfb73a9c
Author: vkorukanti <ve...@gmail.com>
Date: 2016-02-24T22:13:21Z
DRILL-4434: Deprecate GroupScan.enforceWidth API
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-4434: Deprecate GroupScan.enforceWidth A...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/390
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-4434: Deprecate GroupScan.enforceWidth A...
Posted by sudheeshkatkam <gi...@git.apache.org>.
Github user sudheeshkatkam commented on the pull request:
https://github.com/apache/drill/pull/390#issuecomment-188532721
Sounds good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-4434: Deprecate GroupScan.enforceWidth A...
Posted by sudheeshkatkam <gi...@git.apache.org>.
Github user sudheeshkatkam commented on the pull request:
https://github.com/apache/drill/pull/390#issuecomment-188528781
+1
Can we remove the method? (There was a discussion quite a while back about removing this.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-4434: Deprecate GroupScan.enforceWidth A...
Posted by vkorukanti <gi...@git.apache.org>.
Github user vkorukanti commented on the pull request:
https://github.com/apache/drill/pull/390#issuecomment-188531968
Not sure of the policy around changing public APIs, but I think it is better to keep the method around to avoid breaking existing storage plugins until next major version release (2.x)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---