You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "josix (via GitHub)" <gi...@apache.org> on 2025/01/27 18:51:43 UTC
[PR] Move fab provider to new structure [airflow]
josix opened a new pull request, #46144:
URL: https://github.com/apache/airflow/pull/46144
related: #46045
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move fab provider to new structure [airflow]
Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck commented on PR #46144:
URL: https://github.com/apache/airflow/pull/46144#issuecomment-2616759066
> This one will be a bit tricky and I think it will be best to move those failing tests to FAB @vincbeck -> I think that was also your thought ?
Some of these tests yes but some of them weill be deleted when the legacy UI is deleted. For example, `test_views_variable` should not be moved to FAB provider. Actually just `test_views_acl` and `test_views_custom_user_views` should be moved. Adding that to my todo list :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move fab provider to new structure [airflow]
Posted by "utkarsharma2 (via GitHub)" <gi...@apache.org>.
utkarsharma2 commented on PR #46144:
URL: https://github.com/apache/airflow/pull/46144#issuecomment-2621406475
@josix Is there an ETA for us to close this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move fab provider to new structure [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #46144:
URL: https://github.com/apache/airflow/pull/46144#issuecomment-2624099914
> @potiuk It's not related to the release. But another issue I'm facing is that I'm unable to install the providers from the source and without this PR merged to the main branch, I can't install fab providers explicitly as well.
As discussed - I think `uv pip install` (for speed) and getting rid of `--editable` install should solve at least the installation problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move fab provider to new structure [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl merged PR #46144:
URL: https://github.com/apache/airflow/pull/46144
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move fab provider to new structure [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #46144:
URL: https://github.com/apache/airflow/pull/46144#issuecomment-2628840823
> Awesome job! Thank you for doing it!
fantastic!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move fab provider to new structure [airflow]
Posted by "josix (via GitHub)" <gi...@apache.org>.
josix commented on PR #46144:
URL: https://github.com/apache/airflow/pull/46144#issuecomment-2622702536
Thanks, everyone, for pointing me in the right direction. I'll continue migrating these tests. A conservative ETA is 2/7. I hope this won't block others' work, but if it does, I can try to finish it earlier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move fab provider to new structure [airflow]
Posted by "utkarsharma2 (via GitHub)" <gi...@apache.org>.
utkarsharma2 commented on PR #46144:
URL: https://github.com/apache/airflow/pull/46144#issuecomment-2623862615
> FYI: @utkarsharma2 -> if you are asking about release of Airflow - this one has nothing to do. We need to have fab provider released from the `providers-fab/v1_5` branch - but this one is not needed for that.
@potiuk It's not related to the release. But another issue I'm facing is that I'm unable to install the providers from the source and without this PR merged to the main branch, I can't install fab providers explicitly as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move fab provider to new structure [airflow]
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on PR #46144:
URL: https://github.com/apache/airflow/pull/46144#issuecomment-2621056802
We need also to move the 3rd party licenses of fab
https://github.com/apache/airflow/blob/main/providers/src/airflow/providers/3rd-party-licenses/LICENSES-ui.txt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move fab provider to new structure [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #46144:
URL: https://github.com/apache/airflow/pull/46144#issuecomment-2621763198
> @josix Is there an ETA for us to close this PR?
FYI: @utkarsharma2 -> if you are asking about release of Airflow - this one has nothing to do. We need to have fab provider released from the `providers-fab/v1_5` branch - but this one is not needed for that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move fab provider to new structure [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #46144:
URL: https://github.com/apache/airflow/pull/46144#issuecomment-2616667895
This one will be a bit tricky and I think it will be best to move those failing tests to FAB @vincbeck -> I think that was also your thought ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move fab provider to new structure [airflow]
Posted by "josix (via GitHub)" <gi...@apache.org>.
josix commented on PR #46144:
URL: https://github.com/apache/airflow/pull/46144#issuecomment-2628102217
Hi @vincbeck, I've fixed and moved the related tests, could you help review if the change aligns with your thoughts? thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org