[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #9189: drivers/audio: Add support for the ES8311 codec

["xiaoxiang781216 (via GitHub)" <gi...@apache.org>]

xiaoxiang781216 commented on code in PR #9189:
URL: https://github.com/apache/nuttx/pull/9189#discussion_r1185231730


##########
include/nuttx/audio/i2s.h:
##########
@@ -311,7 +331,8 @@ struct i2s_ops_s
 
   /* Master Clock methods */
 
-  CODE uint32_t (*i2s_mclkfrequency)(FAR struct i2s_dev_s *dev,
+  CODE uint32_t (*i2s_getmclkfrequency)(FAR struct i2s_dev_s *dev);
+  CODE uint32_t (*i2s_setmclkfrequency)(FAR struct i2s_dev_s *dev,
                                      uint32_t frequency);

Review Comment:
   align with line 335



##########
drivers/audio/esxxxx_common.h:
##########
@@ -0,0 +1,175 @@
+/****************************************************************************
+ * drivers/audio/esxxxx_common.h
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.  The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.  See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+#ifndef __DRIVERS_AUDIO_ESXXXX_COMMON_H
+#define __DRIVERS_AUDIO_ESXXXX_COMMON_H
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <nuttx/config.h>
+
+#ifdef CONFIG_AUDIO

Review Comment:
   should we already define or change to ES special macro



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org