[GitHub] [lucene] vigyasharma commented on pull request #738: LUCENE-10448: Avoid instant rate write bursts by writing bytes buffer in chunks

[GitBox <gi...@apache.org>]

vigyasharma commented on PR #738:
URL: https://github.com/apache/lucene/pull/738#issuecomment-1155751419

   Based on @jpountz's response in [Lucene-10448](https://issues.apache.org/jira/browse/LUCENE-10448), looks like it is unusual for lucene to write byte[] arrays that are longer than the `chunk` size in this PR. 
   
   Since chunking with pauses in between would add memory pressure by delaying gc on these arrays, and it is probably not an expected normal scenario, I am planning to close this PR. Will wait for a couple days in case there are follow up comments on this.
   
   On a related note, since `writeBytes()` is the only API that doesn't pause, it may be useful to add this note in comments or docstring somewhere, perhaps with a reference to the jira comment.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org