[GitHub] [cordova-ios] NiklasMerz commented on pull request #1004: Proxy requests through WKURLSchemeHandler to bypass Cookies and ITP restrictions

[GitBox <gi...@apache.org>]

NiklasMerz commented on pull request #1004:
URL: https://github.com/apache/cordova-ios/pull/1004#issuecomment-706009752


   > Hey Niklas
   > 
   > I think this is a great addition.
   > Not having to deal with CORS issue, will make building a Cordova app a lot nicer.
   > I cannot review the code as I am no ios developer, but I think the addition of code looks good structured and is rather small for such a great feature.
   
   Thank you for the feedback
   
   > Will it also work with sending multipartform data to the backend? [ multipart/form-data ]
   > Will it also work for loading local assets like local images or translations or config jsons?
   
   This should work for form data too if you use the special URL. For local stuff you could use `window.WkWebView.convertFileSrc`. This has been part of the platform for a while now.
   
   > In my opinion this must be an addition to the ios platform.
   > This should be the default way for Http requests.
   > 
   > Maybe there should be a flag or setting to Opt out of the proxy. (If this is not yet foreseen)
   
   They way it is built now the "proxy" will only work if you convert you URL like `https://mysite.com` with `convertProxyUrl` to `app://myscheme/_https_proxy_mysite.com`. If you use normal URLs the webview will work just like it used too.
   
   > Another remark is the ability to inspect the HTTP traffic. We are used to inspect it with the network inspector of the browser, but this will not be possible anymore.
   > Maybe there must be an addition in some documentation about how to inspect the network traffic with this setup.
   
   This is no problem somehow. All requests done with the special URLs appear in the inspector as usual.
   
   > Kind regards
   > Pieter
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org