You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Chris Goffinet (JIRA)" <ji...@apache.org> on 2010/01/14 02:16:54 UTC
[jira] Created: (CASSANDRA-698) ClusterProbe
ClusterProbe
------------
Key: CASSANDRA-698
URL: https://issues.apache.org/jira/browse/CASSANDRA-698
Project: Cassandra
Issue Type: New Feature
Affects Versions: 0.9
Reporter: Chris Goffinet
Assignee: Chris Goffinet
Priority: Minor
Fix For: 0.9
I'd like to introduce ClusterProbe, for situations where you want to find information at cluster level. The first operation is get_endpoints, where you can supply a key. I want to also add support for showing hit ratio for column families at cluster level.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-698) ClusterProbe
Posted by "Chris Goffinet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Goffinet updated CASSANDRA-698:
-------------------------------------
Attachment: 0001-Added-ClusterProbe.-Supports-get_endpoints-key.patch
> ClusterProbe
> ------------
>
> Key: CASSANDRA-698
> URL: https://issues.apache.org/jira/browse/CASSANDRA-698
> Project: Cassandra
> Issue Type: New Feature
> Affects Versions: 0.9
> Reporter: Chris Goffinet
> Assignee: Chris Goffinet
> Priority: Minor
> Fix For: 0.9
>
> Attachments: 0001-Added-ClusterProbe.-Supports-get_endpoints-key.patch
>
>
> I'd like to introduce ClusterProbe, for situations where you want to find information at cluster level. The first operation is get_endpoints, where you can supply a key. I want to also add support for showing hit ratio for column families at cluster level.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-698) ClusterProbe
Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12803010#action_12803010 ]
Eric Evans commented on CASSANDRA-698:
--------------------------------------
The following two patches represent a quick stab at the refactoring I've been referring to.
v1-0001-CASSANDRA-698-NodeProbe-refactor-move-main-to-new-clas.txt
v1-0002-NodeProbe-refactor-move-print-methods-to-new-class.txt
> ClusterProbe
> ------------
>
> Key: CASSANDRA-698
> URL: https://issues.apache.org/jira/browse/CASSANDRA-698
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Chris Goffinet
> Assignee: Chris Goffinet
> Priority: Minor
> Fix For: 0.7
>
> Attachments: 0001-Added-ClusterProbe.-Supports-get_endpoints-key.patch, v1-0001-CASSANDRA-698-NodeProbe-refactor-move-main-to-new-clas.txt, v1-0002-NodeProbe-refactor-move-print-methods-to-new-class.txt
>
>
> I'd like to introduce ClusterProbe, for situations where you want to find information at cluster level. The first operation is get_endpoints, where you can supply a key. I want to also add support for showing hit ratio for column families at cluster level.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-698) ClusterProbe
Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12800374#action_12800374 ]
Eric Evans commented on CASSANDRA-698:
--------------------------------------
Isn't this still technically still a node operation, (i.e. it is the end-points according to some node)? This doesn't seem much different in scope to the `ring' sub-command of NodeProbe.
Originally, I had intended for NodeProbe to be a class to abstract all of the tedious JMX-related boilerplate, allowing other applications (be they node or cluster in scope), to be built upon it. I stuck a main() on it mainly so that we'd have *something*. In retrospect, that was probably a mistake.
Would it make sense to move the getEndPoints(key) method to NodeProbe, and refactor all of the other stuff (the stuff there in support of a console application) into another class(es)?
FYI, I think this patch is missing the addition of getLiveNaturalEndpoints(String key) to StorageServiceMBean.
> ClusterProbe
> ------------
>
> Key: CASSANDRA-698
> URL: https://issues.apache.org/jira/browse/CASSANDRA-698
> Project: Cassandra
> Issue Type: New Feature
> Affects Versions: 0.9
> Reporter: Chris Goffinet
> Assignee: Chris Goffinet
> Priority: Minor
> Fix For: 0.9
>
> Attachments: 0001-Added-ClusterProbe.-Supports-get_endpoints-key.patch
>
>
> I'd like to introduce ClusterProbe, for situations where you want to find information at cluster level. The first operation is get_endpoints, where you can supply a key. I want to also add support for showing hit ratio for column families at cluster level.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (CASSANDRA-698) ClusterProbe
Posted by "Chris Goffinet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12800387#action_12800387 ]
Chris Goffinet edited comment on CASSANDRA-698 at 1/14/10 10:10 PM:
--------------------------------------------------------------------
Right, but the reason why I started this was because
a) I wanted a way to hit a cluster of nodes without needing a storage-conf file
b) Start the foundation of other commands (including global snapshot that is coming up)
It could go in nodeprobe, but just didn't feel right to be there.
I still think getEndPoints could live in clusterprobe, as I saw nodeprobe just pertaining to a single node functionality. Since ClusterProbe is more in line with finding information about a cluster (multiple nodes) I thought it made sense here.
Yeah I can add getLiveNaturalEndpoints if I missed that :)
was (Author: lenn0x):
Right, but the reason why I started this was because
a) I wanted a way to hit a cluster of nodes without needing a storage-conf file
b) Start the foundation of other commands (including global snapshot that is coming up)
It could go in nodeprobe, but just didn't feel right to be there.
I still think getEndPoints could live in clusterprobe, as I saw nodeprobe just pertaining to a single node functionality. Since ClusterProbe is more in line with finding information about a cluster (multiple nodes) I thought it made for sense here.
Yeah I can add getLiveNaturalEndpoints if I missed that :)
> ClusterProbe
> ------------
>
> Key: CASSANDRA-698
> URL: https://issues.apache.org/jira/browse/CASSANDRA-698
> Project: Cassandra
> Issue Type: New Feature
> Affects Versions: 0.9
> Reporter: Chris Goffinet
> Assignee: Chris Goffinet
> Priority: Minor
> Fix For: 0.9
>
> Attachments: 0001-Added-ClusterProbe.-Supports-get_endpoints-key.patch
>
>
> I'd like to introduce ClusterProbe, for situations where you want to find information at cluster level. The first operation is get_endpoints, where you can supply a key. I want to also add support for showing hit ratio for column families at cluster level.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CASSANDRA-698) ClusterProbe
Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric Evans resolved CASSANDRA-698.
----------------------------------
Resolution: Fixed
committed
> ClusterProbe
> ------------
>
> Key: CASSANDRA-698
> URL: https://issues.apache.org/jira/browse/CASSANDRA-698
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Chris Goffinet
> Assignee: Eric Evans
> Priority: Minor
> Fix For: 0.6
>
> Attachments: 0001-Added-ClusterProbe.-Supports-get_endpoints-key.patch, v3-0001-CASSANDRA-698-NodeProbe-refactor-move-main-to-new-clas.txt, v3-0002-NodeProbe-refactor-move-print-methods-to-new-class.txt, v3-0003-add-new-getEndPoints-method.txt, v3-0004-add-clustercmd-tool-currently-only-prints-endpoints.txt
>
>
> I'd like to introduce ClusterProbe, for situations where you want to find information at cluster level. The first operation is get_endpoints, where you can supply a key. I want to also add support for showing hit ratio for column families at cluster level.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-698) ClusterProbe
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12803844#action_12803844 ]
Jonathan Ellis commented on CASSANDRA-698:
------------------------------------------
+1 on eric's patches
agreed that removetoken probably belongs in clusterprobe eventually
> ClusterProbe
> ------------
>
> Key: CASSANDRA-698
> URL: https://issues.apache.org/jira/browse/CASSANDRA-698
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Chris Goffinet
> Assignee: Chris Goffinet
> Priority: Minor
> Fix For: 0.6
>
> Attachments: 0001-Added-ClusterProbe.-Supports-get_endpoints-key.patch, v3-0001-CASSANDRA-698-NodeProbe-refactor-move-main-to-new-clas.txt, v3-0002-NodeProbe-refactor-move-print-methods-to-new-class.txt, v3-0003-add-new-getEndPoints-method.txt, v3-0004-add-clustercmd-tool-currently-only-prints-endpoints.txt
>
>
> I'd like to introduce ClusterProbe, for situations where you want to find information at cluster level. The first operation is get_endpoints, where you can supply a key. I want to also add support for showing hit ratio for column families at cluster level.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-698) ClusterProbe
Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12800425#action_12800425 ]
Eric Evans commented on CASSANDRA-698:
--------------------------------------
I probably didn't explain well.
IMO, NodeProbe is a mess, because if it isn't the general purpose JMX client for nodes (and nothing else fills that role), then I see a future with a lot of overlap/duplication (like I can already see happening with ClusterProbe). But, feature creep has convoluted NodeProbe into an operations oriented console application.
So what I'm suggesting is that maybe we could push getEndPoints(key) into NodeProbe, where the more cluster-specific tool you're after could make use of it, and likewise, the parts of NodeProbe that are there to contribute to "an operations oriented console application", could be broken out into something separate as well (and I can do this if you want).
In other words, what I'm suggesting shouldn't be at odds with your goals.
> ClusterProbe
> ------------
>
> Key: CASSANDRA-698
> URL: https://issues.apache.org/jira/browse/CASSANDRA-698
> Project: Cassandra
> Issue Type: New Feature
> Affects Versions: 0.9
> Reporter: Chris Goffinet
> Assignee: Chris Goffinet
> Priority: Minor
> Fix For: 0.9
>
> Attachments: 0001-Added-ClusterProbe.-Supports-get_endpoints-key.patch
>
>
> I'd like to introduce ClusterProbe, for situations where you want to find information at cluster level. The first operation is get_endpoints, where you can supply a key. I want to also add support for showing hit ratio for column families at cluster level.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-698) ClusterProbe
Posted by "Jaakko Laine (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12803288#action_12803288 ]
Jaakko Laine commented on CASSANDRA-698:
----------------------------------------
Yep, having things separated is good. Just thinking whether having two tools for related things is good or bad in the end. Many commands are "obviously" either node or cluster specific, but some are not. removetoken for instance affects the whole cluster but it is in nodeprobe. If there are two tools for related things, some admins are going to curse us when they have to remember which one to use for particular task :-) But we can have two tools, not a problem for me.
> ClusterProbe
> ------------
>
> Key: CASSANDRA-698
> URL: https://issues.apache.org/jira/browse/CASSANDRA-698
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Chris Goffinet
> Assignee: Chris Goffinet
> Priority: Minor
> Fix For: 0.7
>
> Attachments: 0001-Added-ClusterProbe.-Supports-get_endpoints-key.patch, v3-0001-CASSANDRA-698-NodeProbe-refactor-move-main-to-new-clas.txt, v3-0002-NodeProbe-refactor-move-print-methods-to-new-class.txt, v3-0003-add-new-getEndPoints-method.txt, v3-0004-add-clustercmd-tool-currently-only-prints-endpoints.txt
>
>
> I'd like to introduce ClusterProbe, for situations where you want to find information at cluster level. The first operation is get_endpoints, where you can supply a key. I want to also add support for showing hit ratio for column families at cluster level.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-698) ClusterProbe
Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric Evans updated CASSANDRA-698:
---------------------------------
Attachment: v2-0003-add-new-getEndPoints-method.txt
v2-0002-NodeProbe-refactor-move-print-methods-to-new-class.txt
v2-0001-CASSANDRA-698-NodeProbe-refactor-move-main-to-new-clas.txt
> ClusterProbe
> ------------
>
> Key: CASSANDRA-698
> URL: https://issues.apache.org/jira/browse/CASSANDRA-698
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Chris Goffinet
> Assignee: Chris Goffinet
> Priority: Minor
> Fix For: 0.7
>
> Attachments: 0001-Added-ClusterProbe.-Supports-get_endpoints-key.patch, v1-0001-CASSANDRA-698-NodeProbe-refactor-move-main-to-new-clas.txt, v1-0002-NodeProbe-refactor-move-print-methods-to-new-class.txt, v2-0001-CASSANDRA-698-NodeProbe-refactor-move-main-to-new-clas.txt, v2-0002-NodeProbe-refactor-move-print-methods-to-new-class.txt, v2-0003-add-new-getEndPoints-method.txt
>
>
> I'd like to introduce ClusterProbe, for situations where you want to find information at cluster level. The first operation is get_endpoints, where you can supply a key. I want to also add support for showing hit ratio for column families at cluster level.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-698) ClusterProbe
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-698:
-------------------------------------
Fix Version/s: (was: 0.7)
0.6
Assignee: Eric Evans (was: Chris Goffinet)
> ClusterProbe
> ------------
>
> Key: CASSANDRA-698
> URL: https://issues.apache.org/jira/browse/CASSANDRA-698
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Chris Goffinet
> Assignee: Eric Evans
> Priority: Minor
> Fix For: 0.6
>
> Attachments: 0001-Added-ClusterProbe.-Supports-get_endpoints-key.patch, v3-0001-CASSANDRA-698-NodeProbe-refactor-move-main-to-new-clas.txt, v3-0002-NodeProbe-refactor-move-print-methods-to-new-class.txt, v3-0003-add-new-getEndPoints-method.txt, v3-0004-add-clustercmd-tool-currently-only-prints-endpoints.txt
>
>
> I'd like to introduce ClusterProbe, for situations where you want to find information at cluster level. The first operation is get_endpoints, where you can supply a key. I want to also add support for showing hit ratio for column families at cluster level.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-698) ClusterProbe
Posted by "Robert Coli (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12803861#action_12803861 ]
Robert Coli commented on CASSANDRA-698:
---------------------------------------
First off, very happy to see "clusterprobe" style functionality for those cases (get_endpoints! yay!) where you really do want to ask a question to the entire cluster. :D
As to the division of functionality into "clusterprobe" vs "nodeprobe", I have a proposed solution which would seem to result in extended nodeprobe functionality without creating much new user-facing complexity.
Make "clusterprobe" the top level tool and have it take --node=[node1,node2,...,nodeXX] as an argument. This would allow you to both query the entire cluster and query a subset or the nodeprobe case of a single node. Even something like "get_endpoints" might be useful on a subset nodelist, if you do not actually want to ask the entire cluster. This interface also avoids questions of the format "which tool should this new feature go in" or "which tool has this feature", and the possibility of duplicating code which could be used in either/both contexts. If a user specifies a nodelist in the context of a cluster-wide-only operation, syntax erroring out should be simple. In the case of "nodeprobe"-like questions with a nodelist, it'd just produce the answer for each node in the list, possibly including a builtin way to make the nodelist "all nodes"?
I clearly do not know how or how well the implementation of this would work with the existing code, but as an ops-centric "interested party", I thought I would suggest the idea, FWIW!
> ClusterProbe
> ------------
>
> Key: CASSANDRA-698
> URL: https://issues.apache.org/jira/browse/CASSANDRA-698
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Chris Goffinet
> Assignee: Eric Evans
> Priority: Minor
> Fix For: 0.6
>
> Attachments: 0001-Added-ClusterProbe.-Supports-get_endpoints-key.patch, v3-0001-CASSANDRA-698-NodeProbe-refactor-move-main-to-new-clas.txt, v3-0002-NodeProbe-refactor-move-print-methods-to-new-class.txt, v3-0003-add-new-getEndPoints-method.txt, v3-0004-add-clustercmd-tool-currently-only-prints-endpoints.txt
>
>
> I'd like to introduce ClusterProbe, for situations where you want to find information at cluster level. The first operation is get_endpoints, where you can supply a key. I want to also add support for showing hit ratio for column families at cluster level.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-698) ClusterProbe
Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric Evans updated CASSANDRA-698:
---------------------------------
Attachment: (was: v2-0002-NodeProbe-refactor-move-print-methods-to-new-class.txt)
> ClusterProbe
> ------------
>
> Key: CASSANDRA-698
> URL: https://issues.apache.org/jira/browse/CASSANDRA-698
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Chris Goffinet
> Assignee: Chris Goffinet
> Priority: Minor
> Fix For: 0.7
>
> Attachments: 0001-Added-ClusterProbe.-Supports-get_endpoints-key.patch, v3-0001-CASSANDRA-698-NodeProbe-refactor-move-main-to-new-clas.txt, v3-0002-NodeProbe-refactor-move-print-methods-to-new-class.txt, v3-0003-add-new-getEndPoints-method.txt, v3-0004-add-clustercmd-tool-currently-only-prints-endpoints.txt
>
>
> I'd like to introduce ClusterProbe, for situations where you want to find information at cluster level. The first operation is get_endpoints, where you can supply a key. I want to also add support for showing hit ratio for column families at cluster level.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-698) ClusterProbe
Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric Evans updated CASSANDRA-698:
---------------------------------
Attachment: (was: v2-0003-add-new-getEndPoints-method.txt)
> ClusterProbe
> ------------
>
> Key: CASSANDRA-698
> URL: https://issues.apache.org/jira/browse/CASSANDRA-698
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Chris Goffinet
> Assignee: Chris Goffinet
> Priority: Minor
> Fix For: 0.7
>
> Attachments: 0001-Added-ClusterProbe.-Supports-get_endpoints-key.patch, v3-0001-CASSANDRA-698-NodeProbe-refactor-move-main-to-new-clas.txt, v3-0002-NodeProbe-refactor-move-print-methods-to-new-class.txt, v3-0003-add-new-getEndPoints-method.txt, v3-0004-add-clustercmd-tool-currently-only-prints-endpoints.txt
>
>
> I'd like to introduce ClusterProbe, for situations where you want to find information at cluster level. The first operation is get_endpoints, where you can supply a key. I want to also add support for showing hit ratio for column families at cluster level.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-698) ClusterProbe
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-698:
-------------------------------------
Component/s: Tools
> ClusterProbe
> ------------
>
> Key: CASSANDRA-698
> URL: https://issues.apache.org/jira/browse/CASSANDRA-698
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Chris Goffinet
> Assignee: Chris Goffinet
> Priority: Minor
> Fix For: 0.7
>
> Attachments: 0001-Added-ClusterProbe.-Supports-get_endpoints-key.patch
>
>
> I'd like to introduce ClusterProbe, for situations where you want to find information at cluster level. The first operation is get_endpoints, where you can supply a key. I want to also add support for showing hit ratio for column families at cluster level.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-698) ClusterProbe
Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric Evans updated CASSANDRA-698:
---------------------------------
Attachment: (was: v2-0001-CASSANDRA-698-NodeProbe-refactor-move-main-to-new-clas.txt)
> ClusterProbe
> ------------
>
> Key: CASSANDRA-698
> URL: https://issues.apache.org/jira/browse/CASSANDRA-698
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Chris Goffinet
> Assignee: Chris Goffinet
> Priority: Minor
> Fix For: 0.7
>
> Attachments: 0001-Added-ClusterProbe.-Supports-get_endpoints-key.patch, v3-0001-CASSANDRA-698-NodeProbe-refactor-move-main-to-new-clas.txt, v3-0002-NodeProbe-refactor-move-print-methods-to-new-class.txt, v3-0003-add-new-getEndPoints-method.txt, v3-0004-add-clustercmd-tool-currently-only-prints-endpoints.txt
>
>
> I'd like to introduce ClusterProbe, for situations where you want to find information at cluster level. The first operation is get_endpoints, where you can supply a key. I want to also add support for showing hit ratio for column families at cluster level.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-698) ClusterProbe
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-698:
-------------------------------------
Fix Version/s: (was: 0.6)
0.7
Affects Version/s: (was: 0.6)
> ClusterProbe
> ------------
>
> Key: CASSANDRA-698
> URL: https://issues.apache.org/jira/browse/CASSANDRA-698
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Chris Goffinet
> Assignee: Chris Goffinet
> Priority: Minor
> Fix For: 0.7
>
> Attachments: 0001-Added-ClusterProbe.-Supports-get_endpoints-key.patch
>
>
> I'd like to introduce ClusterProbe, for situations where you want to find information at cluster level. The first operation is get_endpoints, where you can supply a key. I want to also add support for showing hit ratio for column families at cluster level.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-698) ClusterProbe
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12804078#action_12804078 ]
Hudson commented on CASSANDRA-698:
----------------------------------
Integrated in Cassandra #332 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/332/])
add clustercmd tool (currently only prints endpoints)
Patch by eevans and goffinet for
add new getEndPoints() method
Patch by eevans for
NodeProbe refactor: move print* methods to new class
Patch by eevans for
NodeProbe refactor: move main to new class
Patch by eevans for
> ClusterProbe
> ------------
>
> Key: CASSANDRA-698
> URL: https://issues.apache.org/jira/browse/CASSANDRA-698
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Chris Goffinet
> Assignee: Eric Evans
> Priority: Minor
> Fix For: 0.6
>
> Attachments: 0001-Added-ClusterProbe.-Supports-get_endpoints-key.patch, v3-0001-CASSANDRA-698-NodeProbe-refactor-move-main-to-new-clas.txt, v3-0002-NodeProbe-refactor-move-print-methods-to-new-class.txt, v3-0003-add-new-getEndPoints-method.txt, v3-0004-add-clustercmd-tool-currently-only-prints-endpoints.txt
>
>
> I'd like to introduce ClusterProbe, for situations where you want to find information at cluster level. The first operation is get_endpoints, where you can supply a key. I want to also add support for showing hit ratio for column families at cluster level.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-698) ClusterProbe
Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric Evans updated CASSANDRA-698:
---------------------------------
Attachment: v1-0002-NodeProbe-refactor-move-print-methods-to-new-class.txt
v1-0001-CASSANDRA-698-NodeProbe-refactor-move-main-to-new-clas.txt
> ClusterProbe
> ------------
>
> Key: CASSANDRA-698
> URL: https://issues.apache.org/jira/browse/CASSANDRA-698
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Chris Goffinet
> Assignee: Chris Goffinet
> Priority: Minor
> Fix For: 0.7
>
> Attachments: 0001-Added-ClusterProbe.-Supports-get_endpoints-key.patch, v1-0001-CASSANDRA-698-NodeProbe-refactor-move-main-to-new-clas.txt, v1-0002-NodeProbe-refactor-move-print-methods-to-new-class.txt
>
>
> I'd like to introduce ClusterProbe, for situations where you want to find information at cluster level. The first operation is get_endpoints, where you can supply a key. I want to also add support for showing hit ratio for column families at cluster level.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-698) ClusterProbe
Posted by "Jaakko Laine (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12802697#action_12802697 ]
Jaakko Laine commented on CASSANDRA-698:
----------------------------------------
What kind of division did you have in mind? Division on class-level or a division to separate tools?
NodeProbe is getting bloated (just added two new commands, #723), so something should be done about it. I think it might be beneficial to have one single "nodeprobe" command for all tasks at least for now, but if there is natural division between commands, then two tools might be better.
> ClusterProbe
> ------------
>
> Key: CASSANDRA-698
> URL: https://issues.apache.org/jira/browse/CASSANDRA-698
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Chris Goffinet
> Assignee: Chris Goffinet
> Priority: Minor
> Fix For: 0.7
>
> Attachments: 0001-Added-ClusterProbe.-Supports-get_endpoints-key.patch
>
>
> I'd like to introduce ClusterProbe, for situations where you want to find information at cluster level. The first operation is get_endpoints, where you can supply a key. I want to also add support for showing hit ratio for column families at cluster level.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-698) ClusterProbe
Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric Evans updated CASSANDRA-698:
---------------------------------
Attachment: v3-0004-add-clustercmd-tool-currently-only-prints-endpoints.txt
v3-0003-add-new-getEndPoints-method.txt
v3-0002-NodeProbe-refactor-move-print-methods-to-new-class.txt
v3-0001-CASSANDRA-698-NodeProbe-refactor-move-main-to-new-clas.txt
> ClusterProbe
> ------------
>
> Key: CASSANDRA-698
> URL: https://issues.apache.org/jira/browse/CASSANDRA-698
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Chris Goffinet
> Assignee: Chris Goffinet
> Priority: Minor
> Fix For: 0.7
>
> Attachments: 0001-Added-ClusterProbe.-Supports-get_endpoints-key.patch, v1-0001-CASSANDRA-698-NodeProbe-refactor-move-main-to-new-clas.txt, v1-0002-NodeProbe-refactor-move-print-methods-to-new-class.txt, v2-0001-CASSANDRA-698-NodeProbe-refactor-move-main-to-new-clas.txt, v2-0002-NodeProbe-refactor-move-print-methods-to-new-class.txt, v2-0003-add-new-getEndPoints-method.txt, v3-0001-CASSANDRA-698-NodeProbe-refactor-move-main-to-new-clas.txt, v3-0002-NodeProbe-refactor-move-print-methods-to-new-class.txt, v3-0003-add-new-getEndPoints-method.txt, v3-0004-add-clustercmd-tool-currently-only-prints-endpoints.txt
>
>
> I'd like to introduce ClusterProbe, for situations where you want to find information at cluster level. The first operation is get_endpoints, where you can supply a key. I want to also add support for showing hit ratio for column families at cluster level.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-698) ClusterProbe
Posted by "Chris Goffinet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12800387#action_12800387 ]
Chris Goffinet commented on CASSANDRA-698:
------------------------------------------
Right, but the reason why I started this was because
a) I wanted a way to hit a cluster of nodes without needing a storage-conf file
b) Start the foundation of other commands (including global snapshot that is coming up)
It could go in nodeprobe, but just didn't feel right to be there.
I still think getEndPoints could live in clusterprobe, as I saw nodeprobe just pertaining to a single node functionality. Since ClusterProbe is more in line with finding information about a cluster (multiple nodes) I thought it made for sense here.
Yeah I can add getLiveNaturalEndpoints if I missed that :)
> ClusterProbe
> ------------
>
> Key: CASSANDRA-698
> URL: https://issues.apache.org/jira/browse/CASSANDRA-698
> Project: Cassandra
> Issue Type: New Feature
> Affects Versions: 0.9
> Reporter: Chris Goffinet
> Assignee: Chris Goffinet
> Priority: Minor
> Fix For: 0.9
>
> Attachments: 0001-Added-ClusterProbe.-Supports-get_endpoints-key.patch
>
>
> I'd like to introduce ClusterProbe, for situations where you want to find information at cluster level. The first operation is get_endpoints, where you can supply a key. I want to also add support for showing hit ratio for column families at cluster level.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-698) ClusterProbe
Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12803063#action_12803063 ]
Eric Evans commented on CASSANDRA-698:
--------------------------------------
Alright, the current round of patches (v3), refactors all of application-specific code into a new class (NodeCmd) which the `nodeprobe' script now uses. It's all transparent to the end-user, but it leaves NodeProbe scoped as a high-level JMX client for cassandra nodes.
The last two patches adds endpoint fetching to NodeProbe and ports Chris's ClusterProbe (renamed to ClusterCmd to be consistent with NodeCmd) to use NodeProbe. It works exactly as before, but has less code/doesn't duplicated code with NodeProbe.
I even wrote a shell wrapper...
bin/clustertool -host localhost get_endpoints canhasendpoint
Key : canhasendpoint
Endpoints : [localhost/127.0.0.1]
> ClusterProbe
> ------------
>
> Key: CASSANDRA-698
> URL: https://issues.apache.org/jira/browse/CASSANDRA-698
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Chris Goffinet
> Assignee: Chris Goffinet
> Priority: Minor
> Fix For: 0.7
>
> Attachments: 0001-Added-ClusterProbe.-Supports-get_endpoints-key.patch, v3-0001-CASSANDRA-698-NodeProbe-refactor-move-main-to-new-clas.txt, v3-0002-NodeProbe-refactor-move-print-methods-to-new-class.txt, v3-0003-add-new-getEndPoints-method.txt, v3-0004-add-clustercmd-tool-currently-only-prints-endpoints.txt
>
>
> I'd like to introduce ClusterProbe, for situations where you want to find information at cluster level. The first operation is get_endpoints, where you can supply a key. I want to also add support for showing hit ratio for column families at cluster level.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-698) ClusterProbe
Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric Evans updated CASSANDRA-698:
---------------------------------
Attachment: (was: v1-0002-NodeProbe-refactor-move-print-methods-to-new-class.txt)
> ClusterProbe
> ------------
>
> Key: CASSANDRA-698
> URL: https://issues.apache.org/jira/browse/CASSANDRA-698
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Chris Goffinet
> Assignee: Chris Goffinet
> Priority: Minor
> Fix For: 0.7
>
> Attachments: 0001-Added-ClusterProbe.-Supports-get_endpoints-key.patch, v3-0001-CASSANDRA-698-NodeProbe-refactor-move-main-to-new-clas.txt, v3-0002-NodeProbe-refactor-move-print-methods-to-new-class.txt, v3-0003-add-new-getEndPoints-method.txt, v3-0004-add-clustercmd-tool-currently-only-prints-endpoints.txt
>
>
> I'd like to introduce ClusterProbe, for situations where you want to find information at cluster level. The first operation is get_endpoints, where you can supply a key. I want to also add support for showing hit ratio for column families at cluster level.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-698) ClusterProbe
Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric Evans updated CASSANDRA-698:
---------------------------------
Attachment: (was: v1-0001-CASSANDRA-698-NodeProbe-refactor-move-main-to-new-clas.txt)
> ClusterProbe
> ------------
>
> Key: CASSANDRA-698
> URL: https://issues.apache.org/jira/browse/CASSANDRA-698
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Chris Goffinet
> Assignee: Chris Goffinet
> Priority: Minor
> Fix For: 0.7
>
> Attachments: 0001-Added-ClusterProbe.-Supports-get_endpoints-key.patch, v3-0001-CASSANDRA-698-NodeProbe-refactor-move-main-to-new-clas.txt, v3-0002-NodeProbe-refactor-move-print-methods-to-new-class.txt, v3-0003-add-new-getEndPoints-method.txt, v3-0004-add-clustercmd-tool-currently-only-prints-endpoints.txt
>
>
> I'd like to introduce ClusterProbe, for situations where you want to find information at cluster level. The first operation is get_endpoints, where you can supply a key. I want to also add support for showing hit ratio for column families at cluster level.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.