[GitHub] [pinot] walterddr commented on a diff in pull request #9974: [multistage] improve scheduling to be more mailbox-aware

[GitBox <gi...@apache.org>]

walterddr commented on code in PR #9974:
URL: https://github.com/apache/pinot/pull/9974#discussion_r1046626561


##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/V2Operator.java:
##########
@@ -0,0 +1,45 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.pinot.query.runtime.operator;
+
+import java.util.List;
+import java.util.Set;
+import org.apache.pinot.core.common.Operator;
+import org.apache.pinot.core.operator.BaseOperator;
+import org.apache.pinot.query.mailbox.MailboxIdentifier;
+import org.apache.pinot.query.runtime.blocks.TransferableBlock;
+
+
+public abstract class V2Operator extends BaseOperator<TransferableBlock> implements ScheduledOperator {

Review Comment:
   I've been thinking about this abstraction for a long time! glad this is happening. 



##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/HashJoinOperator.java:
##########
@@ -121,6 +121,15 @@ protected TransferableBlock getNextBlock() {
     }
   }
 
+  @Override

Review Comment:
   unable to comment to the code above but my question is on the logic inside the try/catch block for getNextBlock()
   ```
         if (!_isHashTableBuilt) {
           // Build JOIN hash table
           buildBroadcastHashTable();  // [RR] if this executes successfully after consuming all the right-side blocks; it doesn't return, which will fall through
         }
         if (_upstreamErrorBlock != null) {
           return _upstreamErrorBlock;
         } else if (!_isHashTableBuilt) { // [RR] and hashtable is built here
           return TransferableBlockUtils.getNoOpTransferableBlock();
         }
         // JOIN each left block with the right block. 
         // [RR] this will be trigger even if the original opChain is scheduled by the RIGHT mailbox, correct? b/c after hashtable built, it will continue to consume left block until left EOS, correct?
         return buildJoinedDataBlock(_leftTableOperator.nextBlock());
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org