You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Guozhang Wang <gu...@linkedin.com> on 2014/04/16 01:25:49 UTC

Review Request 20393: Fix KAFKA-1323: rebase on 0.8.1

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20393/
-----------------------------------------------------------

Review request for kafka.


Bugs: KAFKA-1323
    https://issues.apache.org/jira/browse/KAFKA-1323


Repository: kafka


Description
-------

Rebase on 0.8.1


Diffs
-----

  core/src/main/scala/kafka/cluster/Partition.scala 810952e42448829898ace0e75be3302743c23409 
  core/src/main/scala/kafka/log/LogManager.scala bcd2bb7cb3152f2f6cb99123108fa3a79e393661 
  core/src/main/scala/kafka/server/ReplicaManager.scala 7df56ce1a78ca4ed8639a3dff4812b61b25af98f 
  core/src/test/scala/unit/kafka/log/LogManagerTest.scala b4bee33191ebc0b4ab5a5f82fa232cd3bda8fef8 
  core/src/test/scala/unit/kafka/log4j/KafkaLog4jAppenderTest.scala 67497dd042dfd4ad54875fe29200d67f59137264 

Diff: https://reviews.apache.org/r/20393/diff/


Testing
-------


Thanks,

Guozhang Wang

Re: Review Request 20393: Fix KAFKA-1323: rebase on 0.8.1

Posted by Joel Koshy <jj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20393/#review40600
-----------------------------------------------------------

Ship it!


Ship It!

- Joel Koshy


On April 16, 2014, 7:05 p.m., Guozhang Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20393/
> -----------------------------------------------------------
> 
> (Updated April 16, 2014, 7:05 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1323
>     https://issues.apache.org/jira/browse/KAFKA-1323
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> add tempRelativeDir()
> 
> 
> Sync ReplicaManagerTest with trunk
> 
> 
> Rebase on 0.8.1
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/cluster/Partition.scala 810952e42448829898ace0e75be3302743c23409 
>   core/src/main/scala/kafka/log/LogManager.scala bcd2bb7cb3152f2f6cb99123108fa3a79e393661 
>   core/src/main/scala/kafka/server/ReplicaManager.scala 7df56ce1a78ca4ed8639a3dff4812b61b25af98f 
>   core/src/test/scala/unit/kafka/log/LogManagerTest.scala b4bee33191ebc0b4ab5a5f82fa232cd3bda8fef8 
>   core/src/test/scala/unit/kafka/log4j/KafkaLog4jAppenderTest.scala 67497dd042dfd4ad54875fe29200d67f59137264 
>   core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala b5936d4101b513baa805ab26361fe965bdf980aa 
>   core/src/test/scala/unit/kafka/utils/TestUtils.scala 500eeca2f95d901536b1363b8c4b485c4893179f 
> 
> Diff: https://reviews.apache.org/r/20393/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guozhang Wang
> 
>

Re: Review Request 20393: Fix KAFKA-1323: rebase on 0.8.1

Posted by Guozhang Wang <gu...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20393/
-----------------------------------------------------------

(Updated April 16, 2014, 7:05 p.m.)


Review request for kafka.


Bugs: KAFKA-1323
    https://issues.apache.org/jira/browse/KAFKA-1323


Repository: kafka


Description (updated)
-------

add tempRelativeDir()


Sync ReplicaManagerTest with trunk


Rebase on 0.8.1


Diffs (updated)
-----

  core/src/main/scala/kafka/cluster/Partition.scala 810952e42448829898ace0e75be3302743c23409 
  core/src/main/scala/kafka/log/LogManager.scala bcd2bb7cb3152f2f6cb99123108fa3a79e393661 
  core/src/main/scala/kafka/server/ReplicaManager.scala 7df56ce1a78ca4ed8639a3dff4812b61b25af98f 
  core/src/test/scala/unit/kafka/log/LogManagerTest.scala b4bee33191ebc0b4ab5a5f82fa232cd3bda8fef8 
  core/src/test/scala/unit/kafka/log4j/KafkaLog4jAppenderTest.scala 67497dd042dfd4ad54875fe29200d67f59137264 
  core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala b5936d4101b513baa805ab26361fe965bdf980aa 
  core/src/test/scala/unit/kafka/utils/TestUtils.scala 500eeca2f95d901536b1363b8c4b485c4893179f 

Diff: https://reviews.apache.org/r/20393/diff/


Testing
-------


Thanks,

Guozhang Wang

Re: Review Request 20393: Fix KAFKA-1323: rebase on 0.8.1

Posted by Guozhang Wang <gu...@linkedin.com>.

> On April 16, 2014, 6:57 p.m., Joel Koshy wrote:
> > Ship It!
> 
> Joel Koshy wrote:
>     Actually, I ran into this:
>     
>     ReplicaManagerTest.scala:51: value tempRelativeDir is not a member of object kafka.utils.TestUtils
>         props.put("log.dir", TestUtils.tempRelativeDir("data").getAbsolutePath)

Aheee, my bad. Will upload a new patch.


- Guozhang


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20393/#review40590
-----------------------------------------------------------


On April 16, 2014, 7:05 p.m., Guozhang Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20393/
> -----------------------------------------------------------
> 
> (Updated April 16, 2014, 7:05 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1323
>     https://issues.apache.org/jira/browse/KAFKA-1323
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> add tempRelativeDir()
> 
> 
> Sync ReplicaManagerTest with trunk
> 
> 
> Rebase on 0.8.1
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/cluster/Partition.scala 810952e42448829898ace0e75be3302743c23409 
>   core/src/main/scala/kafka/log/LogManager.scala bcd2bb7cb3152f2f6cb99123108fa3a79e393661 
>   core/src/main/scala/kafka/server/ReplicaManager.scala 7df56ce1a78ca4ed8639a3dff4812b61b25af98f 
>   core/src/test/scala/unit/kafka/log/LogManagerTest.scala b4bee33191ebc0b4ab5a5f82fa232cd3bda8fef8 
>   core/src/test/scala/unit/kafka/log4j/KafkaLog4jAppenderTest.scala 67497dd042dfd4ad54875fe29200d67f59137264 
>   core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala b5936d4101b513baa805ab26361fe965bdf980aa 
>   core/src/test/scala/unit/kafka/utils/TestUtils.scala 500eeca2f95d901536b1363b8c4b485c4893179f 
> 
> Diff: https://reviews.apache.org/r/20393/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guozhang Wang
> 
>

Re: Review Request 20393: Fix KAFKA-1323: rebase on 0.8.1

Posted by Joel Koshy <jj...@gmail.com>.

> On April 16, 2014, 6:57 p.m., Joel Koshy wrote:
> > Ship It!

Actually, I ran into this:

ReplicaManagerTest.scala:51: value tempRelativeDir is not a member of object kafka.utils.TestUtils
    props.put("log.dir", TestUtils.tempRelativeDir("data").getAbsolutePath)


- Joel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20393/#review40590
-----------------------------------------------------------


On April 16, 2014, 6:53 p.m., Guozhang Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20393/
> -----------------------------------------------------------
> 
> (Updated April 16, 2014, 6:53 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1323
>     https://issues.apache.org/jira/browse/KAFKA-1323
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> Sync ReplicaManagerTest with trunk
> 
> 
> Rebase on 0.8.1
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/cluster/Partition.scala 810952e42448829898ace0e75be3302743c23409 
>   core/src/main/scala/kafka/log/LogManager.scala bcd2bb7cb3152f2f6cb99123108fa3a79e393661 
>   core/src/main/scala/kafka/server/ReplicaManager.scala 7df56ce1a78ca4ed8639a3dff4812b61b25af98f 
>   core/src/test/scala/unit/kafka/log/LogManagerTest.scala b4bee33191ebc0b4ab5a5f82fa232cd3bda8fef8 
>   core/src/test/scala/unit/kafka/log4j/KafkaLog4jAppenderTest.scala 67497dd042dfd4ad54875fe29200d67f59137264 
>   core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala b5936d4101b513baa805ab26361fe965bdf980aa 
> 
> Diff: https://reviews.apache.org/r/20393/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guozhang Wang
> 
>

Re: Review Request 20393: Fix KAFKA-1323: rebase on 0.8.1

Posted by Joel Koshy <jj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20393/#review40590
-----------------------------------------------------------

Ship it!


Ship It!

- Joel Koshy


On April 16, 2014, 6:53 p.m., Guozhang Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20393/
> -----------------------------------------------------------
> 
> (Updated April 16, 2014, 6:53 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1323
>     https://issues.apache.org/jira/browse/KAFKA-1323
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> Sync ReplicaManagerTest with trunk
> 
> 
> Rebase on 0.8.1
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/cluster/Partition.scala 810952e42448829898ace0e75be3302743c23409 
>   core/src/main/scala/kafka/log/LogManager.scala bcd2bb7cb3152f2f6cb99123108fa3a79e393661 
>   core/src/main/scala/kafka/server/ReplicaManager.scala 7df56ce1a78ca4ed8639a3dff4812b61b25af98f 
>   core/src/test/scala/unit/kafka/log/LogManagerTest.scala b4bee33191ebc0b4ab5a5f82fa232cd3bda8fef8 
>   core/src/test/scala/unit/kafka/log4j/KafkaLog4jAppenderTest.scala 67497dd042dfd4ad54875fe29200d67f59137264 
>   core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala b5936d4101b513baa805ab26361fe965bdf980aa 
> 
> Diff: https://reviews.apache.org/r/20393/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guozhang Wang
> 
>

Re: Review Request 20393: Fix KAFKA-1323: rebase on 0.8.1

Posted by Guozhang Wang <gu...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20393/
-----------------------------------------------------------

(Updated April 16, 2014, 6:53 p.m.)


Review request for kafka.


Bugs: KAFKA-1323
    https://issues.apache.org/jira/browse/KAFKA-1323


Repository: kafka


Description (updated)
-------

Sync ReplicaManagerTest with trunk


Rebase on 0.8.1


Diffs (updated)
-----

  core/src/main/scala/kafka/cluster/Partition.scala 810952e42448829898ace0e75be3302743c23409 
  core/src/main/scala/kafka/log/LogManager.scala bcd2bb7cb3152f2f6cb99123108fa3a79e393661 
  core/src/main/scala/kafka/server/ReplicaManager.scala 7df56ce1a78ca4ed8639a3dff4812b61b25af98f 
  core/src/test/scala/unit/kafka/log/LogManagerTest.scala b4bee33191ebc0b4ab5a5f82fa232cd3bda8fef8 
  core/src/test/scala/unit/kafka/log4j/KafkaLog4jAppenderTest.scala 67497dd042dfd4ad54875fe29200d67f59137264 
  core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala b5936d4101b513baa805ab26361fe965bdf980aa 

Diff: https://reviews.apache.org/r/20393/diff/


Testing
-------


Thanks,

Guozhang Wang