[jira] [Commented] (IVY-1528) Makepom ignores dependency classifiers

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IVY-1528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16027698#comment-16027698 ] 

ASF GitHub Bot commented on IVY-1528:
-------------------------------------

GitHub user jaikiran opened a pull request:

    https://github.com/apache/ant-ivy/pull/34

    Fix IVY-1528

    The commit here fixes the issue reported in https://issues.apache.org/jira/browse/IVY-1528 and includes a test case to verify the fix. With this fix, the `classifier` extra attribute is no longer ignored while generating the `pom` file through the `makepom` task.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jaikiran/ant-ivy ivy-1528

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ant-ivy/pull/34.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #34
    
----
commit 9fbe0652b74273570f24ba6c3fb20661126ed2fe
Author: Jaikiran Pai <ja...@gmail.com>
Date:   2017-05-28T04:19:27Z

    IVY-1528 Don't ignore the "classifier" when creating pom module descriptor from ivy module descriptor, in makepom task

----


> Makepom ignores dependency classifiers
> --------------------------------------
>
>                 Key: IVY-1528
>                 URL: https://issues.apache.org/jira/browse/IVY-1528
>             Project: Ivy
>          Issue Type: Bug
>          Components: Maven Compatibility
>    Affects Versions: 2.4.0
>            Reporter: Matthias Hannen
>            Priority: Critical
>
> The classifier of a dependency like
> {code:xml}
> <dependency org="foo" name="bar" rev="1.0.0" conf="optional->default" m:classifier="wsdl" />
> {code}
> is ignored by the makepom task. I also checked the code of IvyMakePom.java. The method to set the classifier of a dependency is never called anywhere.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)