You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "guyinyou (via GitHub)" <gi...@apache.org> on 2025/09/16 09:45:39 UTC

[I] [Enhancement] Add enableRunningFlagsInFlush configuration switch for CommitLog [rocketmq]

guyinyou opened a new issue, #9709:
URL: https://github.com/apache/rocketmq/issues/9709

   ### Before Creating the Enhancement Request
   
   - [x] I have confirmed that this should be classified as an enhancement rather than a bug/feature.
   
   
   ### Summary
   
   Add a configuration option enableRunningFlagsInFlush to control whether runningFlags should be used during flush operations in CommitLog. This allows users to optionally enable runningFlags validation for message storage reliability when needed.
   
   ### Motivation
   
   Currently, runningFlags is always passed to MappedFileQueue and MappedFile during initialization, which means runningFlags checks are always performed during flush operations. However, in some scenarios, users may want to disable these checks for specific reasons while maintaining the ability to enable them when message storage reliability is critical.
   This enhancement provides more flexibility in controlling the flush behavior and allows users to make informed decisions about when runningFlags validation is necessary for their specific use cases.
   
   ### Describe the Solution You'd Like
   
   Add a new configuration option enableRunningFlagsInFlush in MessageStoreConfig with default value false
   Update CommitLog constructor to conditionally pass runningFlags to MappedFileQueue based on this configuration
   Update AllocateMappedFileService to conditionally pass runningFlags to MappedFile based on this configuration
   When the configuration is disabled (default), runningFlags will be null during flush operations, bypassing runningFlags checks
   When the configuration is enabled, runningFlags will be passed normally, maintaining existing behavior
   The implementation should be minimal and focused only on CommitLog since it's responsible for message storage reliability.
   
   ### Describe Alternatives You've Considered
   
   Always disable runningFlags checks: This would break existing behavior and could impact message storage reliability
   Always enable runningFlags checks: This maintains current behavior but doesn't provide the flexibility users might need
   Make runningFlags configurable per MappedFileQueue: This would be more complex and overkill for the use case
   Add separate configuration for different components: This would add unnecessary complexity when the main concern is CommitLog reliability
   The chosen solution provides a simple, centralized way to control runningFlags usage specifically for CommitLog while maintaining backward compatibility through the default value of false.
   
   ### Additional Context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Enhancement] Add enableRunningFlagsInFlush configuration switch for CommitLog [rocketmq]

Posted by "RongtongJin (via GitHub)" <gi...@apache.org>.
RongtongJin closed issue #9709: [Enhancement] Add enableRunningFlagsInFlush configuration switch for CommitLog
URL: https://github.com/apache/rocketmq/issues/9709


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org