You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Greg Stein <gs...@gmail.com> on 2012/04/25 20:58:47 UTC
Re: svn commit: r1330455 - /subversion/trunk/subversion/libsvn_repos/hooks.c
On Apr 25, 2012 2:10 PM, <st...@apache.org> wrote:
>...
> +++ subversion/trunk/subversion/libsvn_repos/hooks.c Wed Apr 25 18:10:15
2012
> @@ -232,25 +232,19 @@ run_hook_cmd(svn_string_t **result,
> env_from_env_hash(hooks_env, pool, pool),
> FALSE, FALSE, stdin_handle, result != NULL,
> null_handle, TRUE, NULL, pool);
> -
> - if (err)
> - {
> - /* CMD_PROC is not safe to use. Bail. */
> - return svn_error_createf
> - (SVN_ERR_REPOS_HOOK_FAILURE, err, _("Failed to start '%s'
hook"), cmd);
You lost this potential error return. ??
Re: svn commit: r1330455 - /subversion/trunk/subversion/libsvn_repos/hooks.c
Posted by Philip Martin <ph...@wandisco.com>.
Greg Stein <gs...@gmail.com> writes:
> On Apr 25, 2012 2:10 PM, <st...@apache.org> wrote:
>>...
>> +++ subversion/trunk/subversion/libsvn_repos/hooks.c Wed Apr 25 18:10:15
> 2012
>> @@ -232,25 +232,19 @@ run_hook_cmd(svn_string_t **result,
>> env_from_env_hash(hooks_env, pool, pool),
>> FALSE, FALSE, stdin_handle, result != NULL,
>> null_handle, TRUE, NULL, pool);
>> -
>> - if (err)
>> - {
>> - /* CMD_PROC is not safe to use. Bail. */
>> - return svn_error_createf
>> - (SVN_ERR_REPOS_HOOK_FAILURE, err, _("Failed to start '%s'
> hook"), cmd);
>
> You lost this potential error return. ??
Yes, we discussed it on IRC and it has been restored.
--
uberSVN: Apache Subversion Made Easy
http://www.uberSVN.com