[GitHub] spark pull request #20685: [SPARK-23524] Big local shuffle blocks should not...

[squito <gi...@git.apache.org>]

Github user squito commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20685#discussion_r172226910
  
    --- Diff: core/src/test/scala/org/apache/spark/storage/ShuffleBlockFetcherIteratorSuite.scala ---
    @@ -352,6 +352,63 @@ class ShuffleBlockFetcherIteratorSuite extends SparkFunSuite with PrivateMethodT
         intercept[FetchFailedException] { iterator.next() }
       }
     
    +  test("big corrupt blocks will not be retiried") {
    --- End diff --
    
    typo: retried (or maybe "retired", not sure)
    though I think a better name would be "big blocks are not checked for corruption"


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org