You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by tillrohrmann <gi...@git.apache.org> on 2018/03/23 11:03:24 UTC

[GitHub] flink pull request #5754: [FLINK-8901] [yarn] Set proper Yarn application na...

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/5754

    [FLINK-8901] [yarn] Set proper Yarn application name

    ## What is the purpose of the change
    
    When deploying a session cluster, Flink will register under "Flink session cluster".
    When deploying a per-job cluster, Flink will register under "Flink per-job cluster".
    
    cc @NicoK 
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink fixYarnApplicationName

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5754.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5754
    
----
commit 8688f5ae82c57a42311e03d658298559d1fe833c
Author: Till Rohrmann <tr...@...>
Date:   2018-03-23T11:01:09Z

    [FLINK-8901] [yarn] Set proper Yarn application name
    
    When deploying a session cluster, Flink will register under "Flink session cluster".
    When deploying a per-job cluster, Flink will register under "Flink per-job cluster".

----


---

[GitHub] flink pull request #5754: [FLINK-8901] [yarn] Set proper Yarn application na...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/5754


---

[GitHub] flink issue #5754: [FLINK-8901] [yarn] Set proper Yarn application name

Posted by tillrohrmann <gi...@git.apache.org>.

Github user tillrohrmann commented on the issue:

    https://github.com/apache/flink/pull/5754
  
    Thanks for the review @NicoK. I will remove the `applicationName` from `FlinkYarnSessionCli#createDescriptor`.
    
    Technically when you run `bin/flink run -m yarn-cluster`, Flink will also start a session cluster because you have to support jobs with eager execution calls like `collect` and `print`.
    
    Merging this PR.


---

[GitHub] flink issue #5754: [FLINK-8901] [yarn] Set proper Yarn application name

Posted by arukavytsia <gi...@git.apache.org>.

Github user arukavytsia commented on the issue:

    https://github.com/apache/flink/pull/5754
  
    I found that there is no ability no override the `Application Name` in cluster mode with `YARN`, for instance: `./bin/flink run -m yarn-cluster -nm \"Some custom name\" -yn 4 -yjm 1024 -ytm 4096 ./examples/batch/WordCount.jar`, if I'm wrong, pleae, correct me. 
    p.s. According [to this line](https://github.com/apache/flink/blame/2ec72123e347e684ac40a1e1111a79a11211aadb/flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java#L1033) it's feasible to override `Application Name` but not via cli.


---