You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by jo...@apache.org on 2022/12/15 17:57:25 UTC
[superset] branch john-bodley--fix-21943 created (now f7afd8b00d)
This is an automated email from the ASF dual-hosted git repository.
johnbodley pushed a change to branch john-bodley--fix-21943
in repository https://gitbox.apache.org/repos/asf/superset.git
at f7afd8b00d fix(hive): Fix regression from #21943
This branch includes the following new commits:
new f7afd8b00d fix(hive): Fix regression from #21943
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
[superset] 01/01: fix(hive): Fix regression from #21943
Posted by jo...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
johnbodley pushed a commit to branch john-bodley--fix-21943
in repository https://gitbox.apache.org/repos/asf/superset.git
commit f7afd8b00d590805ba88373dbf302e719a32183f
Author: John Bodley <45...@users.noreply.github.com>
AuthorDate: Fri Dec 16 06:57:18 2022 +1300
fix(hive): Fix regression from #21943
---
superset/db_engine_specs/hive.py | 33 +++++++++++++++++----------------
1 file changed, 17 insertions(+), 16 deletions(-)
diff --git a/superset/db_engine_specs/hive.py b/superset/db_engine_specs/hive.py
index 3c541c357e..60786e417b 100644
--- a/superset/db_engine_specs/hive.py
+++ b/superset/db_engine_specs/hive.py
@@ -225,22 +225,23 @@ class HiveEngineSpec(PrestoEngineSpec):
) as file:
pq.write_table(pa.Table.from_pandas(df), where=file.name)
- engine.execute(
- text(
- f"""
- CREATE TABLE {str(table)} ({schema_definition})
- STORED AS PARQUET
- LOCATION :location
- """
- ),
- location=upload_to_s3(
- filename=file.name,
- upload_prefix=current_app.config[
- "CSV_TO_HIVE_UPLOAD_DIRECTORY_FUNC"
- ](database, g.user, table.schema),
- table=table,
- ),
- )
+ with cls.get_engine(database) as engine:
+ engine.execute(
+ text(
+ f"""
+ CREATE TABLE {str(table)} ({schema_definition})
+ STORED AS PARQUET
+ LOCATION :location
+ """
+ ),
+ location=upload_to_s3(
+ filename=file.name,
+ upload_prefix=current_app.config[
+ "CSV_TO_HIVE_UPLOAD_DIRECTORY_FUNC"
+ ](database, g.user, table.schema),
+ table=table,
+ ),
+ )
@classmethod
def convert_dttm(