You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2022/10/16 02:39:54 UTC

[GitHub] [commons-bcel] KengoTODA commented on a diff in pull request #157: Keep ConstantPool.getConstant(int) backward compatible with v6.5.0

KengoTODA commented on code in PR #157:
URL: https://github.com/apache/commons-bcel/pull/157#discussion_r996378742


##########
src/test/java/org/apache/bcel/verifier/VerifyBadClassesTestCase.java:
##########
@@ -122,6 +123,7 @@ public void testB307() {
      * BCEL-308: NullPointerException in Verifier Pass 3A
      */
     @Test
+    @Disabled("ConstantPool item could be null even when class file is valid")

Review Comment:
   This test failed after I removed the verification logic, but my new suggestion is enough to pass this case so I reverted this `@Disabled` annotation. 🤝 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org