You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by zhengruifeng <gi...@git.apache.org> on 2018/02/08 03:34:58 UTC
[GitHub] spark pull request #20539: [SPARK-22700][ML] Bucketizer.transform incorrectl...
GitHub user zhengruifeng opened a pull request:
https://github.com/apache/spark/pull/20539
[SPARK-22700][ML] Bucketizer.transform incorrectly drops row containing NaN - for branch-2.2
## What changes were proposed in this pull request?
for branch-2.2
only drops the rows containing NaN in the input columns
## How was this patch tested?
existing tests and added tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhengruifeng/spark bucketizer_nan_2.2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/20539.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #20539
----
commit 6ab7a35e22bd315d30a10526b4f538dd66fc42e0
Author: Zheng RuiFeng <ru...@...>
Date: 2018-02-08T03:31:51Z
create pr
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20539: [SPARK-22700][ML] Bucketizer.transform incorrectly drops...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20539
**[Test build #4115 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4115/testReport)** for PR 20539 at commit [`6ab7a35`](https://github.com/apache/spark/commit/6ab7a35e22bd315d30a10526b4f538dd66fc42e0).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20539: [SPARK-22700][ML] Bucketizer.transform incorrectly drops...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20539
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20539: [SPARK-22700][ML] Bucketizer.transform incorrectly drops...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20539
**[Test build #4115 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4115/testReport)** for PR 20539 at commit [`6ab7a35`](https://github.com/apache/spark/commit/6ab7a35e22bd315d30a10526b4f538dd66fc42e0).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20539: [SPARK-22700][ML] Bucketizer.transform incorrectly drops...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20539
**[Test build #87184 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87184/testReport)** for PR 20539 at commit [`6ab7a35`](https://github.com/apache/spark/commit/6ab7a35e22bd315d30a10526b4f538dd66fc42e0).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20539: [SPARK-22700][ML] Bucketizer.transform incorrectl...
Posted by zhengruifeng <gi...@git.apache.org>.
Github user zhengruifeng closed the pull request at:
https://github.com/apache/spark/pull/20539
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20539: [SPARK-22700][ML] Bucketizer.transform incorrectly drops...
Posted by WeichenXu123 <gi...@git.apache.org>.
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/20539
So why this PR still open ?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20539: [SPARK-22700][ML] Bucketizer.transform incorrectly drops...
Posted by zhengruifeng <gi...@git.apache.org>.
Github user zhengruifeng commented on the issue:
https://github.com/apache/spark/pull/20539
ping @jkbradley
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20539: [SPARK-22700][ML] Bucketizer.transform incorrectly drops...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20539
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87184/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20539: [SPARK-22700][ML] Bucketizer.transform incorrectly drops...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20539
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/684/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20539: [SPARK-22700][ML] Bucketizer.transform incorrectly drops...
Posted by jkbradley <gi...@git.apache.org>.
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/20539
LGTM
merging with branch-2.2
Thanks @zhengruifeng !
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20539: [SPARK-22700][ML] Bucketizer.transform incorrectly drops...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20539
**[Test build #87184 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87184/testReport)** for PR 20539 at commit [`6ab7a35`](https://github.com/apache/spark/commit/6ab7a35e22bd315d30a10526b4f538dd66fc42e0).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20539: [SPARK-22700][ML] Bucketizer.transform incorrectly drops...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20539
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org