You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by jc...@apache.org on 2007/08/29 10:42:57 UTC

svn commit: r570698 - /wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/protocol/http/WicketFilter.java

Author: jcompagner
Date: Wed Aug 29 01:42:55 2007
New Revision: 570698

URL: http://svn.apache.org/viewvc?rev=570698&view=rev
Log:
creating the request cycle a bit more lazy, and do create the WebRespone directly so that not a buffered is created.. (that creates a 4K char buffer!!)

Modified:
    wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/protocol/http/WicketFilter.java

Modified: wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/protocol/http/WicketFilter.java
URL: http://svn.apache.org/viewvc/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/protocol/http/WicketFilter.java?rev=570698&r1=570697&r2=570698&view=diff
==============================================================================
--- wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/protocol/http/WicketFilter.java (original)
+++ wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/protocol/http/WicketFilter.java Wed Aug 29 01:42:55 2007
@@ -742,16 +742,19 @@
 			Resource resource = null;
 			try
 			{
-				final WebRequest request = webApplication.newWebRequest(servletRequest);
-				final WebResponse response = webApplication.newWebResponse(servletResponse);
-				RequestCycle cycle = webApplication.newRequestCycle(request, response);
-
 				// Try to find shared resource
 				resource = webApplication.getSharedResources().get(resourceReferenceKey);
 
 				// If resource found and it is cacheable
 				if ((resource != null) && resource.isCacheable())
 				{
+					final WebRequest request = webApplication.newWebRequest(servletRequest);
+					// by pass the webApplication.newWebResponse, this makes a buffered response
+					// that
+					// should be done for head requests
+					final WebResponse response = new WebResponse(servletResponse);
+					RequestCycle cycle = webApplication.newRequestCycle(request, response);
+
 
 					// Set parameters from servlet request
 					resource.setParameters(request.getParameterMap());